From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05C2DC021AA for ; Tue, 18 Feb 2025 19:46:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6B48F280102; Tue, 18 Feb 2025 14:46:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6447B2800FF; Tue, 18 Feb 2025 14:46:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 46770280102; Tue, 18 Feb 2025 14:46:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 1DDF02800FF for ; Tue, 18 Feb 2025 14:46:55 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 83A54C04B4 for ; Tue, 18 Feb 2025 19:46:54 +0000 (UTC) X-FDA: 83134098348.14.52C1740 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.17]) by imf14.hostedemail.com (Postfix) with ESMTP id 3242710000B for ; Tue, 18 Feb 2025 19:46:52 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b="M/RP4gEZ"; spf=pass (imf14.hostedemail.com: domain of dave.hansen@intel.com designates 198.175.65.17 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739908012; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=k072zZZyDd0vvciw2a0lSkoKF38sNitdfPH1012gEnQ=; b=ObpCy9kIOVxp5ROEPBN2E/xqjmDZ5hqQArTZahYQQaqI5fCA9lVYDf0LBOkFaQqOoKBvAc i2QeFowGWfSnoB6uKHV/Dn9AufKwOYBme2efxfqg2E+uFu1Kd2Nr8axxp9yOEDayyNc2sh TlPHT6wYGCSvfFq49A4IXCaV8kpYFpE= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b="M/RP4gEZ"; spf=pass (imf14.hostedemail.com: domain of dave.hansen@intel.com designates 198.175.65.17 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739908012; a=rsa-sha256; cv=none; b=I0VqEUhd6E0msfApjz0e1SZ19WGJaAx4IYAdx+DisvIq5gLjAFJqBsji673ry4IyK40FPY cAAulQxtAndICoWAQKKtKcbzyz1jiHWjiqFWSSWD8Sad+3TCE60vpZPvVjvwZhFEBBaKr9 bfP4UOMOfIZNGMHiOf0sZdAHj3hy4R8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1739908012; x=1771444012; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=pL+YwqNJy9ZFMxbibhGCNVWj4yE1A7x52CS1b9szg0g=; b=M/RP4gEZ8xpip1nEs/2LWCh8VGVie5Ja/QiyS+omka4vkiFSt+25ZAgx FF4GQoD9ZaeJSoHvxfH4Jbegduc2T3yiJGZ4XMiasXqJFzM7Aya9W3qXD HH6eZZW3SwhNJ5XKJ/nt40Zf0jj503WDjRaPDBNBtGG0IEoTEgqUoIjX5 sLDmrMjlBqxRxJewnGrmd9hyBbaW1hOjbtb+RQ3Aa9cCml1lwRf111e99 1+BxcoTI/y52G4Yfyul6Ao/8HfGY5QqTa5YP/JAaHoZSgE6TIpROvWYuf CqeaCYkr9IVdDc/eIrSNGf/dM65Em1vtWIUVV/79Dz3oaD1wgmWxqO1Q7 A==; X-CSE-ConnectionGUID: eBTTAoa2QU6l9GkfqF12Wg== X-CSE-MsgGUID: lfNlXzT9TtK/ptwidu11Mg== X-IronPort-AV: E=McAfee;i="6700,10204,11348"; a="40641137" X-IronPort-AV: E=Sophos;i="6.13,296,1732608000"; d="scan'208";a="40641137" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by orvoesa109.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Feb 2025 11:46:51 -0800 X-CSE-ConnectionGUID: ee0euvK1QfOmbEtKQOCphQ== X-CSE-MsgGUID: qT2x98PfQH+tPeXKC+r0DA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.13,296,1732608000"; d="scan'208";a="119473286" Received: from cmdeoliv-mobl4.amr.corp.intel.com (HELO [10.125.109.167]) ([10.125.109.167]) by orviesa004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Feb 2025 11:46:50 -0800 Message-ID: Date: Tue, 18 Feb 2025 11:46:54 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v11 08/12] x86/mm: use broadcast TLB flushing for page reclaim TLB flushing To: Rik van Riel , x86@kernel.org Cc: linux-kernel@vger.kernel.org, bp@alien8.de, peterz@infradead.org, dave.hansen@linux.intel.com, zhengqi.arch@bytedance.com, nadav.amit@gmail.com, thomas.lendacky@amd.com, kernel-team@meta.com, linux-mm@kvack.org, akpm@linux-foundation.org, jackmanb@google.com, jannh@google.com, mhklinux@outlook.com, andrew.cooper3@citrix.com, Manali Shukla References: <20250213161423.449435-1-riel@surriel.com> <20250213161423.449435-9-riel@surriel.com> From: Dave Hansen Content-Language: en-US Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 3242710000B X-Stat-Signature: zauhrdgukogsyoponjg4e1593s4wuyr7 X-Rspamd-Server: rspam03 X-HE-Tag: 1739908011-836466 X-HE-Meta: U2FsdGVkX18D1ekt09VOsCXjcs89bGO9bBlwXNhz/g0F8vbNgdIjEiSiHBGfbldiaR9ldm/gjTmwd/OszGLvSfxxEsg23Ec3xdRo0xcNSh/LL2DjETBL2KOOq/9uvhaUEMllIU6r/3rfhMjn4fbk9UqkQlMfPGzcli0IWyC42uOns08Xa0YDKC6jPs470JWm4s+RyP2rlYrnv32etiqxmPyzo59b/xdr9rBQfLs9CQzcXXsQKy8ch+qcxbH4VwBJG/BB56T42PRkH/HW4sO0oG6V1rvcSAeJhVgotVJEOduDQRZwcNChRi8tsh7Xj9sHM6RVMWOkDWHuWWo+7lv2k21F03fhECrqh4vQgtM6Y9m4xQzwH6CMxkAUk6t0bASw91TGPmOT3Vf0g0Ace8R4f+IUJTwKiRXvgPhW9S7Em3z1uIRo+VR6jaW2EwHsWWb8NiIb4tBLykOHllO8qAgFOCdmnmVf7mh3v2y3bUo1ovI6V3BPjDctXevPLN3LuEyg0FA8hWpc8fgacFszEqQ0A00N1RAQ8ngHOeVyrk/OWhBmHP4N5nY/S9gmBFzU7HFpS9EIOEw7Wc/wM4dJK0XFiDG/KVu4poQiBvppd+O9XfmvZcc2QBVPnzEqYSUN6OE8dCjnMPGB2Jl9FY6d3RfBDtaS5hc/dtmdlFhBTZzScWOxPkIlj9SKS7Xtcl71m/q8/BThPfXo4SdsmN44dDM5TPMkcpQW8DyMFqvUeIDb6UKtC2DGvCxFmFktouNIXttrCAEAjiaWBu+jyoQzSxLQbzBsmJ7UlIZXCdrHVItasme2u4LuW4nPJ+5zpqpBp2VZ8wmcYnQfXKdCUQjv8u/2S/+08cXmTl0lpst1hk6oaXP91C/us3fFfGAoKvH9H03Jl+XQLiiTF3HHR/ypXMGmmLpPao/joNUbFpRz9UxjisUv4874aiqYhDsek1bvimPTaYoT/o+WMf3vFRAQhXC /WnNx7DI KxyxQxT1LVhClDUhzYnnZQyACE+Tu5hXrh275yeHJ+ZGZEWFWRhMaS/ZrYJs8wvIos0GtF7HmF+2Et4tqTemRY6ryOQvMxeMtsoWoT2NqLDEpLAA58e1sEy5XMzNHkYLyIgEqlpxVBi6p1C6LhOIlsEkhbfVwAFthQtuG+uyxCGKqaPk4cqG8omuX7enJE158BzCVglENe252FuuhiBmMEbBADgzEEgSq17u2lirLuxDNJcDWYAYWTAuri0tiO5DRrMh5vbZNsgaykxmOqM83c1Q2fQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2/18/25 11:31, Rik van Riel wrote: > On Fri, 2025-02-14 at 10:51 -0800, Dave Hansen wrote: >> Would that make sense here? It would also preserve the "common case" >> optimization that's in arch_tlbbatch_flush(). >> > What we do in this patch goes out the window in patch > 10. This is just a temporary stage along the way to > what we have at the end of the series, needed to make > sure we don't break bisect partway through the series. > > I'm not sure we should be doing much with this patch. > > I could fold it into the next patch, but that would > make things harder to read. Ahh, that makes sense. If it's going out the window, could it be temporarily commented, please? Add the comment here and remove it in patch 10 (or whatever).