From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EAB8DC48297 for ; Mon, 12 Feb 2024 18:11:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 556356B0074; Mon, 12 Feb 2024 13:11:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5069F6B0075; Mon, 12 Feb 2024 13:11:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3CE1D6B0078; Mon, 12 Feb 2024 13:11:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 2CC286B0074 for ; Mon, 12 Feb 2024 13:11:54 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 34C1B1C134A for ; Mon, 12 Feb 2024 18:11:51 +0000 (UTC) X-FDA: 81783945222.30.DA0EE51 Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) by imf05.hostedemail.com (Postfix) with ESMTP id 338EC100003 for ; Mon, 12 Feb 2024 18:11:48 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=HKhYVT7T; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf05.hostedemail.com: domain of yakoyoku@gmail.com designates 209.85.210.172 as permitted sender) smtp.mailfrom=yakoyoku@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707761509; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0WioqbTZKq0P+lyta+EQBea/PSsBEYwVMDVbmzi1DgA=; b=XfAA7LRFJFncxPqDoBq0iD367ol/dQSUmzRIitL9lRqw1bnJGjgUw4F1j4ce3A9Y8nBuT7 NSeosN3KG5U6sn1ywW3KKQKPaZMHZQYMr93oc0dy+2fYuR3UMmG5XcI9tUgL1PHc1jflY5 kC90MzjqRB2fghApIoaigO4nKBvPwlw= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=HKhYVT7T; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf05.hostedemail.com: domain of yakoyoku@gmail.com designates 209.85.210.172 as permitted sender) smtp.mailfrom=yakoyoku@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707761509; a=rsa-sha256; cv=none; b=0HT3LO0/5oINdI6kW2CMMsU2dfHwun/JEFog5A+Y38as+scxk4CyxDzB7m5cY7nUX8NYBY BY7Vi0VbnqeqDRT0cUfbibnS08TiJYO0uBkzwu390zOG4++pn+BCHv6I5t93DWszpXlZHJ PY8dcCA/YaCAxfyOfYifJ9yVxg7VElc= Received: by mail-pf1-f172.google.com with SMTP id d2e1a72fcca58-6de3141f041so110998b3a.0 for ; Mon, 12 Feb 2024 10:11:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707761508; x=1708366308; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=0WioqbTZKq0P+lyta+EQBea/PSsBEYwVMDVbmzi1DgA=; b=HKhYVT7TX7f1LbUllFJAo5YqeibQLSNDYVDVp/sp5MDjFee3t7AQ5hn9YZqJ5fniUm d0sixG8PVbwGJG7LzKR9+pxB+aTsRDbF/4Jib+/7H7DYQ1/Tx3E0ELxVa/0xdFU1oxKh nSIZoHxJ3KplR7EoJCMB7roO7W2FGLBXOYZwyXZKmEZz9+05gVEUMRP8gGx1z1biR/wI mS12ch/SZiviv8nuxwOwnLvlYoAXTWajkB8YHzeXkXftIsZ4Aa8q05CLfb5xiHcVtGcx Ih79DycpkmInzKN/xlo5+fZ2oCFmUcj8hmWF0Qp2IK9SpQtmGhBSP0rwENEH5WOuVIWW yFFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707761508; x=1708366308; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0WioqbTZKq0P+lyta+EQBea/PSsBEYwVMDVbmzi1DgA=; b=LCvKRPo/FcJV2U4tiwb9KNEb7UydNxB6DQBwmEaPSqGerUbPUitQ5GpJY35YLDKgqy fhBag9GPOfQ0SUq8cmrSNVBDBGiZfoOm1rtyqWMMYkMTosfGcS4XJhxd/AOm9YEuP9H/ tlC3u8225NLJ2ipQtx1P5CjI7190+WP35B5hzJnt8SnxguFPXwdj6YhT2+MVbItx21D6 kZc4gt3gMpN7qw37fS4uA1X2Gro5GyiK60AIp1ckPm0wDf39++SlV7Rbf4scNF7X5lwb RqMkbW+LzW79BStnxBfK1xlzLbWgeUPkmTbMB+OmiMErbNueoCEovk43QJjHXPcVrTtb MwXg== X-Gm-Message-State: AOJu0YyX0JjkuMhF1AyDKOFEZ4rb+dEBeNA8Gq11NelDdbo5G9bhOfJC o8KSCUF6pNFKcPhGHNFOWMHwBSztoqMg/F7SI8vyZUY87MNnnMFy X-Google-Smtp-Source: AGHT+IGyJf7jH/y0babjrV0MZaAcDBC9ftQRDowzPQylcRGUVugNChhGwD+7Yy8WGFjbxFeD1ag7kw== X-Received: by 2002:a05:6a21:1394:b0:19c:9f1b:1d8d with SMTP id oa20-20020a056a21139400b0019c9f1b1d8dmr5576803pzb.12.1707761507792; Mon, 12 Feb 2024 10:11:47 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCWVmGRxsdj8Y079ZpV3o4NLGHPdhcQA2bxDRk3VfARoc5y1piXpHU68JJhwXAkraD08O7nXuBbCPeRIkLMmRBICsot5LXzuNpBKa7lsL7G3ZoH6t0LcyVaX0LSielyt7tFA6+PrUZevhCHIWMQsoTpJyI3PcrNxE3Lmkf8B/5zHwyiUr2jCkR6QW+/yqobGmBure+JasCZwj8OaBtNZaw4sWA5ffLxrO59vW4ijTZDQOFN8k9x3ggb3MUytIkSWnUAVJ3bJZ2Qt4CHcbncO5GFIGwDI3Em5biy+JJ9ulBbpBGKSvzCz5lj3Zawsk+9kIP/WPbzBUGc72jXGGCrq5/fEWfMwkCA8ZxMmHZH+nP5piBljacMgRfyIH1r3dBYXrReFY1U9ph2WBEIUgoukPsL0BkdvS/4V30ZFPj89ZgG3EGQ+Hl7EqyCh/pSQmq8J6i/u/JXlRbstXeo5+D5qm1Qjn2He7d7KFeY5d1i3cbTQGtjHrUX/DSvGXHhYkjmAhv1o+6RubwclGb1w7QlUnfTG754mkMXbQEv3AU+1fyZfXUTDWmSyaaoVSHxRb49lXj8o5U7o2HrSaLMgGicebPl9ZTue15C4HvPHdgnhuW2vfapCbAqkVP/LiFuhi39nKl5GnfZXsb2ctgeWs1Vgk+v+s0Nfut2C8A+bzMIyIkDDh+4oJeahw5O6jrsyiHfxlhPnseGjVWEpsdYxdkqCZg== Received: from [192.168.54.105] (static.220.238.itcsa.net. [190.15.220.238]) by smtp.gmail.com with ESMTPSA id t187-20020a6281c4000000b006d99f930607sm6287472pfd.140.2024.02.12.10.11.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 Feb 2024 10:11:47 -0800 (PST) Message-ID: Date: Mon, 12 Feb 2024 15:11:41 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 4/4] rust: add abstraction for `struct page` Content-Language: en-US To: Alice Ryhl Cc: Miguel Ojeda , Alex Gaynor , Wedson Almeida Filho , Boqun Feng , Gary Guo , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Kees Cook , Al Viro , Andrew Morton , Greg Kroah-Hartman , =?UTF-8?Q?Arve_Hj=C3=B8nnev=C3=A5g?= , Todd Kjos , Martijn Coenen , Joel Fernandes , Carlos Llamas , Suren Baghdasaryan , Arnd Bergmann , linux-mm@kvack.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, Christian Brauner References: <20240208-alice-mm-v2-0-d821250204a6@google.com> <20240208-alice-mm-v2-4-d821250204a6@google.com> From: Martin Rodriguez Reboredo In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 338EC100003 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: dxxyk99r95j8oa1y6t955mesc8fjuso6 X-HE-Tag: 1707761508-318801 X-HE-Meta: U2FsdGVkX1/XGqNHvVzf3qj9TjyfJl1o6NEO/dHCMKgArdHm2AG5z+iuSxmspWr1HgsLW7NkZY3TqOguyHHO2v5L0n0lc39s5MrBSZc/zzheJOZZ3XboPbo09aDB2Q3TegsF1qdDGwI9X1bqpZ6t5DHHxnKT2eMmHCodRLzTmyYhV3JGKS5UITIK5aFw55COl8RUXZq62KztiUxqUH546QBwYEQbZvar+KQe6raoCvz9gh0mwhl+CM16UvcvVLmCadGODZZpyo7uId+q77wnQcNPOyZF5TfKnqt0jf4BGGdD8kaULDiRbKcj50MfaADkj1/UWHi+2+ctDWngojlZSWRx+eybU3fX96ZVfxivN9+nhj18R2oCvA1hY+nOD5HImg56vLVugrOgIoDN7jzfTDJd8wO303I/arIA/fr3JTxnYLMugKKce4bZyHtqwg1Lot97w8qTK5H9vhKfubtxjGj/d6wa5RmCVVpmih/Ka2pa4rFJahpI69pA+uSr/EdCz0pqf0seSDb/ajUw60JVuOp3AYfJDbeNEIkzt/kNfSXBRiS3HmWSdwYMwXHINszaiXoJ9u0Je/kQLgL0Nw9btt5rUnP3yKnMrDUS2lzdGCj4WxRAoV4nJQFbWCTYsxCngU0UUWvMjcWGNjRGlu9MZVaqXL9QKkuBvEPdNjX1yxj1emPPcj52PKr57IMSlVOYwFXy8NYNS/jAUaq87xjwu5HXrYSYVCVAT2FLutr8EOYZv2Z1PiojIzcBD7OKu+9CCvyZb38GMCV4D/plqSO26m17LnGYcdM0BE0eoLlylvjwXO2buoAnAYqtBc/KEJv3KdR8MfpNOh1A3FAg7Xa3rKI2z2mLTfTkZ+lLAHM0HGpo3w7ED1P+/ZHb6g1+M83Mj0WyaojeGSgRfEeyzfDIEFTbdYEbnTpnUQ12es30DLvjQv7Y+h3oKJyZE04l3f6XHpv0FiVPFQZOvuI4+39 Zkm+uQe3 YyuiDu6uuYe8DF5hXAxLmfPGfQzGxyy0QoZ7IXraMInB4Xj/yJcQjzCGpmOB5J1dvEh2CW09qa9df20KE3E6Gj3i1vqqJkyw0vmofhhaDgDzJ11BD1tykBsqxrixdywqVc0gMD7mhaWKPzkMOFDNxXYVJQWLJ+gP20zVIaOUDWrtD4Rrd5ioRlGSggGDSwpn/iqHVQEBaF7j27cgAKEMj3TRrF7EDrAVQKpeMe9FaEH9cBHABU44bnt9LjDcyiYYU4/fnsaYduDjMbS6BYf/8csL7ZD8Gw7zn61+kgYGETsaIDOpPxOrCWgyhdTTJkjXTfIRf7+9+YrgSjrVQMaFntXMByprOmTHXoEMCczTTeLuhdOrSFRKhCoIl36+A+nYAvHr0B3jD2aXDoxl7oEiWZ5YTE+9N/IUVQrsfXu2XhfpiVgZXSYD/4rWbzywxMkVBu2C5juIQHihPIVszWKHh5vT0RV2YO2LY+GPClIiYnQgRO+q3EN1MluysQbhTOxStgOnhebyHNv2BKamhBEeXydAj6OLrQwKYVvgc0VwjYFts0sNkturpzu6pgRL0fOU3jQbmj5selkeqMwf8MCe2WSSrGw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000005, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2/12/24 06:36, Alice Ryhl wrote: > On Sat, Feb 10, 2024 at 5:23 AM Martin Rodriguez Reboredo > wrote: >> >> On 2/8/24 12:47, Alice Ryhl wrote: >>> [...] >>> + /// Maps the page and reads from it into the given buffer. >>> + /// >>> + /// This method will perform bounds checks on the page offset. If `offset .. >>> + /// offset+len` goes outside ot the page, then this call returns `EINVAL`. >>> + /// >>> + /// # Safety >>> + /// >>> + /// * Callers must ensure that `dst` is valid for writing `len` bytes. >>> + /// * Callers must ensure that this call does not race with a write to the >>> + /// same page that overlaps with this read. >> >> This safety section says that a call mustn't race with a page that >> overlaps this read, hmmmmm. > > Is there a question here? I've said more like introducing the next point, but if you want to use `copy_nonoverlapping` then the safety section should mention that both `src` and `dst` memory areas are forbidden to be overlapping. > [...] > I'll use copy_nonoverlapping. Thanks for the suggestion. > > Alice You're welcome.