From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85D7BC47422 for ; Mon, 29 Jan 2024 08:44:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D62156B0083; Mon, 29 Jan 2024 03:44:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D12956B0087; Mon, 29 Jan 2024 03:44:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BDAD96B0088; Mon, 29 Jan 2024 03:44:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id AAF3E6B0083 for ; Mon, 29 Jan 2024 03:44:34 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 4DB951608DB for ; Mon, 29 Jan 2024 08:44:34 +0000 (UTC) X-FDA: 81731712468.09.EC36B22 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf12.hostedemail.com (Postfix) with ESMTP id 9844E4001D for ; Mon, 29 Jan 2024 08:44:31 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf12.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706517872; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2q1xnXNc5Es/B9LTN7LHTNPlpslVsxuW+ZXikrMu+xo=; b=GkfHRK7wRZPFbqMfes3T3w7XLseMIuuKlyS5Xvt3rc25vdVKMrWDtFyCSugwx5mb6gNYl/ rIHg/tkbeaJ3okXnuMLsyNjRwSU/1w4K0g0+Rr8ObS2B5NVGAoxqmFHBmQmsUfxj72wBIK 8fZ/b4V28QE2bjhAraO3nFD2RTluTc0= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf12.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706517872; a=rsa-sha256; cv=none; b=kutqMRGvV+iVMYbBPxlU4zv5l0in4LOIRD0SxOT37myGpb3uFcbLDA02q8gu8ExYt6zaPB W78gYNHdnmoZ2/JDAeGT20wOH0HPQONZqZYDa3RMXF6YM/MsAzU34MGcKnY8/XY77azFim SWSEeaSFvwslUgfeMx0pmGzcLMLFyFw= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 11ED01FB; Mon, 29 Jan 2024 00:45:14 -0800 (PST) Received: from [10.162.42.11] (a077893.blr.arm.com [10.162.42.11]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C240E3F762; Mon, 29 Jan 2024 00:44:19 -0800 (PST) Message-ID: Date: Mon, 29 Jan 2024 14:14:16 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC v3 03/35] mm: page_alloc: Add an arch hook to filter MIGRATE_CMA allocations Content-Language: en-US To: Alexandru Elisei , catalin.marinas@arm.com, will@kernel.org, oliver.upton@linux.dev, maz@kernel.org, james.morse@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, arnd@arndb.de, akpm@linux-foundation.org, mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, mhiramat@kernel.org, rppt@kernel.org, hughd@google.com Cc: pcc@google.com, steven.price@arm.com, vincenzo.frascino@arm.com, david@redhat.com, eugenis@google.com, kcc@google.com, hyesoo.yu@samsung.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kvmarm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org References: <20240125164256.4147-1-alexandru.elisei@arm.com> <20240125164256.4147-4-alexandru.elisei@arm.com> From: Anshuman Khandual In-Reply-To: <20240125164256.4147-4-alexandru.elisei@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 9844E4001D X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: 8smnyyz1wwj9pb9s85nfuf8yh86u361y X-HE-Tag: 1706517871-358184 X-HE-Meta: U2FsdGVkX1+Srdb4GTdaKSfUIN1ISzFzaw+8EqkEihSGDlkhEcqW1wZ68AVgbZ5udyQ+X+BhI/cv6wCSzalGkIGPdPeOj0TMbxc5eQhxw5SbXQiqd9oNzfWOeIr1W9FuOJsjr2PJsraCStxnX3zOj23Fc8jTibVagXwfIRz/gA4J8fSDspmTK6HuKURG9R+OsvkMRXdvcQRbc0pKgm8/KwHTYs76QFskZWWU6ntVFw7cCBS8XHiU42yduOqHxC/BnMHUakkSAkyfWb+imqbEit28f52pJFIOrn1XZa93TKlqWQNd1GIKw4R1ib61rKk4vNnQhMzCcc03OGqRsjSIP/IxYBsRkc/EjpU8IH4YxbST136EKrO8WYzcJwHy4w+vxWTPT5dGo5DNMCio05VPCf6rcIx099t6KsIBmvhnVFAoMpLKLT4w2MnW7XoERK+J+1lx2X04MoEsHHJIrikdjGLOjGx0PpHcjvHYRqyyICZR80p0D0Mm6D1ym/vg6RHNLezKhhhKjYjK+KP99kQzLB4+lIwqYwcGqQlHVNlrkKQMbNpRcRdc5PGYPSCSGpWEjWxxvbScOe7r1rEX0qR6ndA7lOJ2fbdmfU4mASGDWsNDTgjh4Xs0GAjAdcnZCCdlP8M1phAHeMkPf5bd2CLDUoABl6kXImvTx1q81LAlAfiNWhYhN8njoRwPV84uYt4SKrMWIcoNXAmiPyIQtIkv4LHbusfwjkxB0d1bO1L244Me2vx9hAhnJ4OMv9u1m9Za1QBWRTDVhk8xFfyMAs8U9rq3fgxEKwJ7k1w+fj9M/MLVChrXeGhpmXsY3fb35Q32k8NTgW8zLWRKwqCf1MCvhGnbK4FBlbPz9u6S1doSFhEgiuo8BI7Jgt3AXU8I/67E6lcWsviqLJde0RsoTlZHtxsGqiM+daT12F4ZrC0X0hm/+DS8B1Q8p79sj4a4HPz0YDf25pjg6ayhlrMPfDL gd02itcv TVtZAoJ7c4kL51ppMfy7ta5WI5Ps4292R0Bny7BJ4eUpR4qEyy5ko81vDb5r3wQUrs8bQVpt7xrZnjZN1oFfdEKEwuASlHupGbCzB+VTETOmgtp6CJmuXDGDZZru4ga9O/q9LVDKFCJDnIdJw4XECuqYjDmqx1e3OMsJTZf6trF6c0tJ42N1cmwPCoy1eKqAfqGohlW/35z1S3XoS+jps5eZfc4bFlh/229yDiEJCx2neJteRjD52iW812dJYF6yM4WDQ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 1/25/24 22:12, Alexandru Elisei wrote: > As an architecture might have specific requirements around the allocation > of CMA pages, add an arch hook that can disable allocations from > MIGRATE_CMA, if the allocation was otherwise allowed. > > This will be used by arm64, which will put tag storage pages on the > MIGRATE_CMA list, and tag storage pages cannot be tagged. The filter will > be used to deny using MIGRATE_CMA for __GFP_TAGGED allocations. Just wondering how allocation requests would be blocked for direct alloc_contig_range() requests ? > > Signed-off-by: Alexandru Elisei > --- > include/linux/pgtable.h | 7 +++++++ > mm/page_alloc.c | 3 ++- > 2 files changed, 9 insertions(+), 1 deletion(-) > > diff --git a/include/linux/pgtable.h b/include/linux/pgtable.h > index 6d98d5fdd697..c5ddec6b5305 100644 > --- a/include/linux/pgtable.h > +++ b/include/linux/pgtable.h > @@ -905,6 +905,13 @@ static inline void arch_do_swap_page(struct mm_struct *mm, > static inline void arch_free_pages_prepare(struct page *page, int order) { } > #endif > > +#ifndef __HAVE_ARCH_ALLOC_CMA Same as last patch i.e __HAVE_ARCH_ALLOC_CMA could be avoided via a direct check on #ifndef arch_alloc_cma instead. > +static inline bool arch_alloc_cma(gfp_t gfp) > +{ > + return true; > +} > +#endif > + > #ifndef __HAVE_ARCH_UNMAP_ONE > /* > * Some architectures support metadata associated with a page. When a > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 27282a1c82fe..a96d47a6393e 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -3157,7 +3157,8 @@ static inline unsigned int gfp_to_alloc_flags_cma(gfp_t gfp_mask, > unsigned int alloc_flags) > { > #ifdef CONFIG_CMA > - if (gfp_migratetype(gfp_mask) == MIGRATE_MOVABLE) > + if (gfp_migratetype(gfp_mask) == MIGRATE_MOVABLE && > + arch_alloc_cma(gfp_mask)) > alloc_flags |= ALLOC_CMA; > #endif > return alloc_flags;