From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C9D4C5475B for ; Fri, 1 Mar 2024 12:39:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C63A86B007E; Fri, 1 Mar 2024 07:39:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C12926B0080; Fri, 1 Mar 2024 07:39:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B02086B0081; Fri, 1 Mar 2024 07:39:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 972C16B007E for ; Fri, 1 Mar 2024 07:39:52 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 2F70CA1496 for ; Fri, 1 Mar 2024 12:39:52 +0000 (UTC) X-FDA: 81848427024.02.5658A1D Received: from madrid.collaboradmins.com (madrid.collaboradmins.com [46.235.227.194]) by imf22.hostedemail.com (Postfix) with ESMTP id 6D105C000C for ; Fri, 1 Mar 2024 12:39:50 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b=JYp6ypXH; spf=pass (imf22.hostedemail.com: domain of usama.anjum@collabora.com designates 46.235.227.194 as permitted sender) smtp.mailfrom=usama.anjum@collabora.com; dmarc=pass (policy=quarantine) header.from=collabora.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709296790; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oWIz8jQha/yAtk5LL45fE0ZduBAggSXM/5mEf5+wJKM=; b=D2G/q6lId7LH0TyUUQ+i9GeanKY811qkD/oWIyzHRgAo730F4gmXEAvRXRK0syv3uPUN/J tj4bxATWOman1l17+4B210S2RmB0YuoOmXKsQZ4kUaISMadRsQyJSU85y8vqnwK6H+k2fu +VYff6enTGOxLNWXCTcueh9/JVU2QrY= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b=JYp6ypXH; spf=pass (imf22.hostedemail.com: domain of usama.anjum@collabora.com designates 46.235.227.194 as permitted sender) smtp.mailfrom=usama.anjum@collabora.com; dmarc=pass (policy=quarantine) header.from=collabora.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709296790; a=rsa-sha256; cv=none; b=x45xLpYGBMZrPs3Xx0iS1F6CjTm3cgqSxiPqtjKHJ8aZF6SS57ye2FEAb0lpg35qSfrbQ2 ysgjqJJVOiIiWb/IbaOs+1EKYFAw9zuveadc2LhNPaU11PyqzDZ5cHoapLpR/7TVtgorKW taxgzFqcYXs/LDDrVq0kN2+jgzZuCrE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1709296788; bh=pVS+U4njvtT1fPdTH5A8P3pkgMzukTILrOPUSvgyd9I=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=JYp6ypXHBu9DsA3GeJ135ZUA3Yqp7bsKYXMLKBEH75ze6Cg5e9qsv+qZEC2/gNXRn ra/i6beNUw5Ofjr02CTkKOaEyCRUODTBfMGk+PX4jEUT+kbepPY21SEy/WmsyhAhPd DXN4ZNWNPZo9WoREIFD1LSetSBeqPHRLwB3xp9uizWwVY1cUblCm2KdStAh432gR6z ny6EVjnNyCrGUXJOzqvYpS5Jt6zEC12lU1R1Bzm367raVEqxbmwYt80b/u/6Kew0Bk wVjv/z6sj9w++Z76p1+qUK6DJXxWv3SzkJRFxgAbvUm2UQsT4HpFnsgcV9g9W5vnHq fuCoUQ3fiDDcw== Received: from [10.193.1.1] (broslavsky.collaboradmins.com [68.183.210.73]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: usama.anjum) by madrid.collaboradmins.com (Postfix) with ESMTPSA id 2451337813CA; Fri, 1 Mar 2024 12:39:46 +0000 (UTC) Message-ID: Date: Fri, 1 Mar 2024 17:40:11 +0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: Muhammad Usama Anjum , linux-mm@kvack.org, Naoya Horiguchi , Andrew Morton Subject: Re: [PATCH 0/8] Some cleanups for memory-failure To: Miaohe Lin , "Matthew Wilcox (Oracle)" References: <20240229212036.2160900-1-willy@infradead.org> Content-Language: en-US From: Muhammad Usama Anjum In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 6D105C000C X-Rspam-User: X-Stat-Signature: 97e3mdazrhkbyiarfoz7dhcncgcksnay X-Rspamd-Server: rspam01 X-HE-Tag: 1709296790-169869 X-HE-Meta: U2FsdGVkX19gp5yeyv9X0PXzKis91u9uJMP0AY7pR0hpTjUKlPvrUbG+IiKA9aibtWHU6QFlUcC4QqcMwr+woNf9ntrm844w+sZ8wOuyMMUGC13rCgMApKypJKYRwDIJHw7XaXbQW09ZimK2gTq1/AduVGI09B9Ug4dwNEKB0ec6jdb+1MQ/qvL9oHg8FRf3N6BtZJ1OGznW0/2ERLwc1EUfxFSIevTdXt6DwllKukYa2SOx1QBq0FZV8FCqgiQhBXUchfcTScG3qCrFm9z7itFtwEuYJk1k44+uB4im679JV2U4Fj1ZIZEaPfz+m5QATJWmyiH4PcSwliDtLsGOalrrFAYuYzfXSv4cwZu1CV32B3qApXkUlVKeoSOWmoR712WWyeI2tWWrpKhiEQtJIqHplkmC4Wbj8KHrVeIPLqW22823eKsPzguvjzU+2UnnpMg3F4+UTM6ItAkrIOqt71yYbDcecpyTq/TOYkfmrLUzup2OZcguMS6Tdp4I4dXF3FCmCmFlVmVbKfHZ3OgZbu8fMUocypVZqsxHdAfjRPE7g1uMkHjNLqnyxMFw2wMClL76ue6fBo9MK1U7zL7z1HUwnDDWl37TxUFTtHpOToWc7S/p7u3iUA9Usloy3Dbo/ZsIxSKvrJw7S1MPRU8ZfKcWO5bE3VMSIFZ9pMEvI3J6qTIAsOBjeno0O9UC0D6pCxWzRt3OZ6EBIkH+pbzi8Ex9gAa7bdEvYveEPipyrhGKt/JQpExxhFk/9cX/yhYX/h+E1ph1GdasdwhRdTb1pCVZ4wMSjZxt8o29QA55qWG4UR0XA34A6aoDO0ydI6OYbfMVylYouTfFLfcc7UsqxfMbDNh8UdqrDIYCriTR2BISXyYaymvMiVEWt6NuDuKjbW2YVQfW97cjjRscbJYp2TQj2eaS8JRhs8wl+WoNl/wxbmlQ2etbGF9395AkJQ8GOIywN8dG9PQpY4prrXf N3OU4P2Y rz+EWZLJsgeDVKD7GPz8EusYJ3OWfQ6o2gb+MfRRhyhQKTNBUR0d9vtCNGUrvjjrSrL2xUEpnSHFAi/l/AXSze0WQbbJ7be0NTshLLgg5Sfr6Fd737tGt5i3sKZsiAdgBZX2XsJwH20pAW7bcoHVRNu/nKEKA2emEVeHJDtOA6tlPWYDl/rE8Dvr3+Zsw+pFqK8ybB9lRRVUk7Dq3QfR6vL+Jbp/0WCJIbfbMrG0zKaiNkbLcO5AsWOu+JcazjDrOJFQ+jNxtq8glCbU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 3/1/24 11:28 AM, Miaohe Lin wrote: > On 2024/3/1 5:20, Matthew Wilcox (Oracle) wrote: >> This isn't my complete collection of patches to memory-failure, but >> they're the ones I have the most confidence in. I haven't done any real >> testing of this beyond compiling & running on a system without trying to >> do any memory failure injections. Is there a good test-suite I should >> run before submitting these kinds of patches? > > mm_regression[1] should be a good alternative test-suite to run. It's written by > Naoya Horiguchi and available at https://github.com/nhoriguchi/mm_regression. Any idea why these tests haven't been added to selftests or ltp? > >> >> Matthew Wilcox (Oracle) (8): >> mm/memory-failure: Remove fsdax_pgoff argument from __add_to_kill >> mm/memory-failure: Pass addr to __add_to_kill() >> mm: Return the address from page_mapped_in_vma() >> mm/memory-failure: Convert shake_page() to shake_folio() >> mm: Convert hugetlb_page_mapping_lock_write to folio >> mm/memory-failure: Convert memory_failure() to use a folio >> mm/memory-failure: Convert hwpoison_user_mappings to take a folio >> mm/memory-failure: Add some folio conversions to unpoison_memory > > Thanks for your patches. I will review them as soon as possible. > >> >> include/linux/hugetlb.h | 6 +- >> include/linux/mm.h | 1 - >> include/linux/rmap.h | 2 +- >> mm/hugetlb.c | 6 +- >> mm/hwpoison-inject.c | 11 +-- >> mm/internal.h | 1 + >> mm/memory-failure.c | 144 +++++++++++++++++++++------------------- >> mm/migrate.c | 2 +- >> mm/page_vma_mapped.c | 14 ++-- >> 9 files changed, 97 insertions(+), 90 deletions(-) >> > > -- BR, Muhammad Usama Anjum