From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD919C3ABBE for ; Thu, 8 May 2025 10:45:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 05E8D6B000A; Thu, 8 May 2025 06:45:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 00DD36B0082; Thu, 8 May 2025 06:45:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DF0AB6B0085; Thu, 8 May 2025 06:45:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id C08106B000A for ; Thu, 8 May 2025 06:45:08 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 5E22C1CF9E6 for ; Thu, 8 May 2025 10:45:09 +0000 (UTC) X-FDA: 83419408338.05.3358090 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf13.hostedemail.com (Postfix) with ESMTP id BDA3020003 for ; Thu, 8 May 2025 10:45:06 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="F/Q1A5VQ"; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf13.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746701106; a=rsa-sha256; cv=none; b=iaaPdi4Vi91PoJ23IlUTsMzus8uMvuzRh4W96EhmU15o89xdRrvYd6psAJsYlOXFrVvXrQ jQoRVaCXQhZRHlGt0QRW9AlyXpXprcP8txtEIh6c3RsVWUQgUS8zXoNAzmAfgDI21HAvhr Uijx77tIIXs3EPF6VTjoCA+yNv3uvnQ= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="F/Q1A5VQ"; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf13.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746701106; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=144CCdZ3QqhhoE6LNmKSPB/eWeg7K2Itr6u/8FJkLpE=; b=l0+fvy8G4vaW2UjBJIds4qi4KKA2hIntMFbXsmnBPFnfKkGrnVQfV+tju9Q0zcyu99ANXY USFMs6uZSy62GjWDwRuFNrgSp4R58cSHGw2QJ1Akt/4/zCRM1waS9GHYDDIxmaih/slpkh TIgje06cYtrFErEYJnZe3tW1mM0QB8I= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1746701105; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=144CCdZ3QqhhoE6LNmKSPB/eWeg7K2Itr6u/8FJkLpE=; b=F/Q1A5VQLYdLSo01y7XiYVYw9iZu5vTwTVPvyGvG9w+GbAGm4FQvtW0ZhDaMBJAKJx0pY/ taLHqLV733ZU17EuMuNa0OUoO4+0X1P7v10awYdAdpA4Q1FKJ3NyCWay0JL4glbH0XqCUb 4okYOoxJlt9oJOiHUb29lMeZUqy7Ko4= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-460-z9CqoX3TMM6XuH_NIv6DaQ-1; Thu, 08 May 2025 06:45:04 -0400 X-MC-Unique: z9CqoX3TMM6XuH_NIv6DaQ-1 X-Mimecast-MFC-AGG-ID: z9CqoX3TMM6XuH_NIv6DaQ_1746701103 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-43ea256f039so6549275e9.0 for ; Thu, 08 May 2025 03:45:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746701103; x=1747305903; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=144CCdZ3QqhhoE6LNmKSPB/eWeg7K2Itr6u/8FJkLpE=; b=FORF30F72snuA2bezn+grIgZWg1zaUiYWBI+vsV16XdWg+hpInvo/yiQ8X2bk40xpt yXCgnl1jnh70HJ+gpW9dw82y5V20b2cs2k8u4WF0PbdKpM4QgX9sdY+PJdrCWCiWxoUn Brn85/P0dbhZelattBPEWDgF5U0LvbkXDXXF/IBa6VZHRvfJFNhmfhussCHYIpSvNNFi NndWC+toGTUFuhyP1pSeZrux2zI5x6gIpjrAzsb+d6u5LkGcwwDaJK9DygcXtCzZquCj 9lJMPfA4Ws58OvZBSye9YelcQXfxHn+Qa0vAEX/POeZuVLsl6LPMfD9+EovxahfJgiMK P08A== X-Forwarded-Encrypted: i=1; AJvYcCXS68RUw4dMfH4lVzr/2Cp8dhKuDXFXFt3j27AAL22ir3ROaz5vsPuQD5DygITwUGs1BzY5ODe5uw==@kvack.org X-Gm-Message-State: AOJu0YwbepfJZgb/Rtz7ALf06iFm1EdZ2+i1wTiQT/WnaVh9N5T50gmw Mw5cUfQZ5COHqrAMWqOhtv4j9v9l3ghFwTOl9JKvlwJrL3mUVAEi+oz5o4YI+rnUhOH9uQyaY7K ZyZ1//Ei+PRoLGM7b4npuoApFzVTifuERVO6iSnguYa1k8Fk0 X-Gm-Gg: ASbGncuo7X2ZwwS/PE1VzSLu0CU96OWuOCxqyU4Jdx3bdb7cnHII7kLAksQMofdxisR /UQINwPWe8hXlQUVp5jvz0Dnu+Hhw9J2oEYHmz/CoFhvY0tfN79N87+bCPcf4t/MCv1YK6R3cBQ f8vado+STbYfPAzVnqUkK3aD3LL/bgiBPjX316/JG7zrZje5M3G9h2BUUS52rGckb5Qg14r8aw6 1o2PjYAwWIr+uPHW3gfsb8z2+2wpzkI25RfjdFDhsmYRt/6h8I5ax93tuSkrc/OVxq6hAbxaAiP /aK1xzdlq4ccPZZ+b27/iDiHRPXXRKCg/URE7AB4HKDDJq2mJoKQkIUfzFnLcdsep/VMjH0b7XW JlzXw8TrrcG6ZQDMSkLvNjXeQfLjJ+seTCIRrcKk= X-Received: by 2002:a05:600c:6099:b0:441:d2d8:bd8b with SMTP id 5b1f17b1804b1-442d02eb737mr25234925e9.8.1746701103464; Thu, 08 May 2025 03:45:03 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFJipFDeuAP66y53PUXj/YtGNe0kDSmVFggpMyReSgfoxt7A5u5wr1a0OocAi2q7Qu34MSpWg== X-Received: by 2002:a05:600c:6099:b0:441:d2d8:bd8b with SMTP id 5b1f17b1804b1-442d02eb737mr25234635e9.8.1746701103059; Thu, 08 May 2025 03:45:03 -0700 (PDT) Received: from ?IPV6:2003:d8:2f3e:5900:27aa:5f4a:b65c:3d3c? (p200300d82f3e590027aa5f4ab65c3d3c.dip0.t-ipconnect.de. [2003:d8:2f3e:5900:27aa:5f4a:b65c:3d3c]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-442d14e6d74sm23825945e9.21.2025.05.08.03.45.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 08 May 2025 03:45:02 -0700 (PDT) Message-ID: Date: Thu, 8 May 2025 12:45:01 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Memory hotplug locking issue: Useless (?) zone span seqlock To: Mathieu Desnoyers , Andrew Morton , Oscar Salvador Cc: Michal Hocko , Anshuman Khandual , Vlastimil Babka , Pavel Tatashin , Linus Torvalds , linux-kernel , linux-mm References: From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: pWjJFf04N_E5Dj-5c8nGxx4GkvkCqYc540ap48XxY84_1746701103 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: BDA3020003 X-Rspam-User: X-Rspamd-Server: rspam07 X-Stat-Signature: extfwe6ao414tkxrtu8fe6qteikzdsaw X-HE-Tag: 1746701106-333739 X-HE-Meta: U2FsdGVkX192+EkP+3aOLuHwbd7wSIZH1PrJFVVaoHafXIE81AhhrBktJyNKYDFem6/paKfGBZn/8AK0y7RhyoiK5tR7RWSanlhvkmXc0OZo8be55ceRdJ0t+aq3+afKBeyRukbvb7CCDm/l4BZ48X4nQ35dz3hQXwD7pz1toSYgenNwG2OOKVXGURumEWTAjvaw+MgNnWqNMpBts2TuW7bXmsGxamQWgVYpENz0KecFTowCG/VEMddoUWUQ9LQRfXco87zyECir2BQjyGdlbi+lkQeGp2PSbfBwM48wfA4VwXwhaaiNM7FVYV+yACSK4I3XQjgrKTAxOVCMGwxOB6pjC/ayNd2rqaRIjAGnA6BklAeqp7mowKTLfXDQmOIyQpY+uReqPyaIxW1WYYz9ZmrctDp6ORlZCyVQ2OOJtMhIEmuARkhkAQRmkWOK61e9u9wVn5ZZSpyXoB65bC1u8cBnjs3P2fXE6dYtsk5F1YddEyjWm3s8vlLoF3ozeflg9rlPp7DS8yBa1gw5deLYywIZu6kltdyLMvgVv14KHmurPTOXLLtYg76+vMX753kJ1daJDTafWLPko18RHKyv+GRkvlHi8oSezYdXLqbiSxhGSqg9fiN3sUZ/CV82803HIayvr4sakV8u2sc0SPBhtwafJ4IU1nVliSUiGuknQbPuaFK9SyDFVPwIsxR4rJqSTVGNIS+cl1Lyr3HiQ7IJj2I7pMhSLYdMimAmFDdpw+mz1SRJrg58maTeNEuDCPFYMlZgb+EgUtcz1mr6KrIbDdZ82IZXW5H+c6WX3UI/92qmsqTspeAkYOpVD6yFlNlnchJQuzT5c3IMmJOgiVOf5y1Ah8phmrdZoc5jd/m6purTLWOK30/UxB4CVaveM5TYZL+RsuFucx8dX1ErQNvfAAKcW9wyuZsGBhKOy9fWp+xtHpkIDalBkmzf2et2uShTwPt309HLhEvffzSgsii GRAh/kjC FCgwEPqXkOz5OqGeCpZIl4luJZ0Em+L1d47oP9R6R1zFUgfnYBnV+PnvkyoSHWpAraSd9xVnzoiMf2OC7yq/sh0zycO/HBsv5CNQr/Ao0AS233ruzP+vEKxBZuaIviJQsQpbOJqZSI3aSPWAaTe+6HE9p4Jhqzff49HXAJpsffEYDOUAi8haBzc8Zuf08CKIhfWHtL8mnI+K4H6E8NhqMK1RE0leumGzyd86/xeArG88ggbm4qPR0zq0yDGSQ1CuXhqgTfJsr6DeIwvo0XExkDFyI3le5gEfECaJn4LiqQl0X0tzhDsPIck3DcnqJdz1jvPJLW5QArZvmUQ/8czbs5PHojmKKeZy3Ho28xfnNtNWLcqS6oRS4P4NTRp4/yuM6wJ60faBTebMZiIaTX5i6mCH9mRBfoLA1FZ+RuXCxpGaV/ONHxv6xsWjMEo21VZVHdxWZ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 07.03.25 21:22, Mathieu Desnoyers wrote: > I'm currently perfecting my understanding of the mm code and reviewing > pieces of it as I go, and stumbled on this: > > commit 27cacaad16c5 ("mm,memory_hotplug: drop unneeded locking") > > This commit removes all users of zone_span_writelock(), thus making > the inline useless, but leaves the now useless > zone_span_seqbegin()/zone_span_seqretry() in place within > page_outside_zone_boundaries(). > > So I'm confused. What's going on ? > > And if this commit got things very wrong when removing the > seqlock, I wonder if there are cases where its partial > pgdat_resize_lock() removal can be an issue as well. I stumbled over that myself recently as well. I think I mentioned in the past that we should just store start_pfn + end_pfn instead of start_pfn + nr_pages Then, concurrent resizing could happen (and we could atomically read start_pfn / end_pfn). Right now, when adjusting start_pfn, we always also have to adjust nr_pages. A concurrent reader calculating end_pfn manually could see some crappy result. Having that said, I am not aware of issues in that area, but it all looks like only a partial cleanup to me. -- Cheers, David / dhildenb