From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2F8EEED615 for ; Fri, 15 Sep 2023 15:36:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0D98A6B0371; Fri, 15 Sep 2023 11:36:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 063306B0372; Fri, 15 Sep 2023 11:36:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E1F886B037C; Fri, 15 Sep 2023 11:36:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id D46346B0371 for ; Fri, 15 Sep 2023 11:36:35 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id B64E51CA011 for ; Fri, 15 Sep 2023 15:36:35 +0000 (UTC) X-FDA: 81239233950.06.B4C9FF1 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf09.hostedemail.com (Postfix) with ESMTP id 8F813140003 for ; Fri, 15 Sep 2023 15:36:33 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ivO79Rbs; spf=pass (imf09.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694792193; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QKvZfNUAeqRJOa+1glQDGtoNRuRm5yfurVcRjFqOx34=; b=8dQNAKsWgz+KY7CNrY5r9W8U7Pqrk4/m2y9RoxsHf+d3pXdiIGTYdHV6/W3L//B+iwySHL RE5btTx2xdt5ykRc4HN2f0P8nOe2/4/6zGJlxMWNO7qiP2uQQ/x/FGpEJD80xWDZ9gPOoi 8O3s9OqviCDGQw3eE4WbkYmCkrqzRTE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694792193; a=rsa-sha256; cv=none; b=LMACh3T3jKhxjwWWwTu8is073rU2jckxgnJjXctRS4aLRFSjoziX9d4vJ7/fb84QhaYQWe /s+aDL4CCs2fIeIo9D3dyP+KcZxUATdA2V/upn61IwHLrQKyoPsAWfINxrBgR3R8gis78H msNVim9vEQHVbBjQCYtHQmIzUPFWfSM= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ivO79Rbs; spf=pass (imf09.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1694792192; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QKvZfNUAeqRJOa+1glQDGtoNRuRm5yfurVcRjFqOx34=; b=ivO79RbsbHLEJqodTn5lBhridvZAPtxlVMqJRajFE3eVaBwZAta+BsIDnAq+wK/g39Fwts nULoIsACG3VDRIqKcvJBZmqSDrSV4IPPC3gpynhLo0ddgZvRUj09KOwbGs9sggVdmbq/iK WfbLWYKicJqQzJAnuwttX6OtevSFE8c= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-570-9nSOH1pbP26MYZz7CVPzhw-1; Fri, 15 Sep 2023 11:36:31 -0400 X-MC-Unique: 9nSOH1pbP26MYZz7CVPzhw-1 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-31ff9e40977so239694f8f.3 for ; Fri, 15 Sep 2023 08:36:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694792190; x=1695396990; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=QKvZfNUAeqRJOa+1glQDGtoNRuRm5yfurVcRjFqOx34=; b=Ku/Wt7tFhkPtc9aBVzpmYBMZZ5wOx9vEODe11zRzruZeye2TrWmu5jOxLdKg9BXqz6 t1jZbb37wB81gSPrGZBd08ZtP2u3Z6Uc0lA/7V6QMfln26h/3qauWLfinZdELmCkFczp snp0sV6JPNTOgYHGC7FAo19ozcKXhjW07aOS5Vpw8Pa5x9Q7RR9pUDyYidezy5+01pKH R9ALqiUgwd/AA/3wyXMk6knkq+LXsGIrnyMqDZsdsl7qmTolMeW+Wbzr2wSW+b8nqafY cyNTd1KZQ1KZfogHbLl0r4ESl6umrwT3ie7ZGJZAmjFnGrwZPbO8JPCRJC1rCIlafGmj +Leg== X-Gm-Message-State: AOJu0Yy1N9JR0hui93IWgunGXRdN+4SN2KmNq0CkdX2X7Wx4wy7r/dIC 5mzHTw4bLtUUyZN9k1WIFzlHWfnp20KSbSwVqZ/c6T0BlmF7HqaCf3S9u/6oRAOkjPR2AnabkU7 tanB5YvwpzqI= X-Received: by 2002:a5d:46cf:0:b0:317:ec04:ee0c with SMTP id g15-20020a5d46cf000000b00317ec04ee0cmr1704607wrs.47.1694792189683; Fri, 15 Sep 2023 08:36:29 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHtkB87/+nnfRuxfOJgL+CM9Ct3RseBJxuj5P7xcBr31HK1aWFwbEWtn8JZFFHltZl8Pm3o9Q== X-Received: by 2002:a5d:46cf:0:b0:317:ec04:ee0c with SMTP id g15-20020a5d46cf000000b00317ec04ee0cmr1704581wrs.47.1694792189303; Fri, 15 Sep 2023 08:36:29 -0700 (PDT) Received: from ?IPV6:2003:cb:c728:e000:a4bd:1c35:a64e:5c70? (p200300cbc728e000a4bd1c35a64e5c70.dip0.t-ipconnect.de. [2003:cb:c728:e000:a4bd:1c35:a64e:5c70]) by smtp.gmail.com with ESMTPSA id y14-20020a5d4ace000000b003176eab8868sm4793784wrs.82.2023.09.15.08.36.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 15 Sep 2023 08:36:28 -0700 (PDT) Message-ID: Date: Fri, 15 Sep 2023 17:36:27 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 0/6] shmem: high order folios support in write path To: Matthew Wilcox Cc: Daniel Gomez , "minchan@kernel.org" , "senozhatsky@chromium.org" , "axboe@kernel.dk" , "djwong@kernel.org" , "hughd@google.com" , "akpm@linux-foundation.org" , "mcgrof@kernel.org" , "linux-kernel@vger.kernel.org" , "linux-block@vger.kernel.org" , "linux-xfs@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" , "linux-mm@kvack.org" , "gost.dev@samsung.com" , Pankaj Raghav References: <20230915095042.1320180-1-da.gomez@samsung.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 8F813140003 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: n3yqy455eu5t9ytktsjswgh9q5oheajg X-HE-Tag: 1694792193-729360 X-HE-Meta: U2FsdGVkX193xOlfevJejPcjtxsv5SKNtVwpgkNIbupWBzTbw8284PJ63EsgqyspvfCwzRGXpLYfjW/eViey6m0rglOucyRqGYkwyUbW5fDVqKcFhmYdzEmcLhhZ/gF/X0B8v74ZEFhA04RIQatvZz3yhKzohLwMopI+Avr1NhE0xEcVtn/eYtGHuqNpVvACDEGcSsXnmC0oGUtG9V5IStKX/I5n4PlTkAepU/J167+KwKwKKmNZY947DKAgiQUWq0DNJf52jLetZgbyek/lsxZPsAqiLWT5Kg9Ou8V6UGAYRbYTwAG4MQ/6BI/9eP/eyM2WgckPNtvTgafYpg3SpzjOHxMndOqcBbRPNy9uVy1uD9LsTyuBlci3spjDdCH/jGiROAfcybdUfJX9PuK2lyX4OHytpZn9F/SWOBadicPpM2B5L4S4zPDF5/mD37gkZCW0bHjABj4KB67hHIV/SLDTs+8SgEJMJgQZtS++r5SWsoRWnhsYooBRB3uNIuRYf5kpt/fJizP6FkcIMKYNzqtzqZpojyP7M371oXAplo+ZaVrfBCWdeSk10pmK8lVUxUROZ5UnPF31NZbFIQacHpJuk0N5/i3e6+pWndRrntMnEctVAYHuLV0OA1awlgvuFuVHPum3d9IQdye0SiRlZPCPqVfCqijHXpkLtOeR0LqdE7SPacVidc7EWbYzmmWFio3nbgyGVz44H8wHkZYz+xRvchFztj6mvimT8Jwrv1uY8nigah1AhvkgrKBeiGjJR3qD9gbdlti/hgNVSIcA09BjUXJrhfz/KZ3BFnlU/qynpibCamHUeZumjCxn5TNJTK0dDk/erQpb/LHQ16nD1gsRUa2Z1GhsatBmNXWXBbEVHveJ+cGKxUnia9SNK33Vz0KYnToNoC3RFYSVbGzze4Bpn2cy9ETGZkyBpTQWWgjjuxi+1rbxHa2/cA+nt0Fzvp6x6lc7c8r7TD2yLWl CMLYUdef j0f1I5UaPoCt8y7uV3ZFPNmv9e44XPkSrdf6DRlwKVnUnkjF/zxF5quHYq2r4uMVnhglIjyS2UNsrBnpxyULm+6kIYdJEVyUcVB4eAa7/eZYPuz19tpyMj1AIlTQAaPmVkKbq/MWDyYqJf56cFRvcqrRzFcqxzgaWMERso+VtC9kwVKUnp7T5jS94hz6rHR43jBqbvgpyJPCRATGYMK2LSE+LQqZ9Yu5xZMsWpPG85qpYgtyQC6YsskvZ6cKjG0ddSd+7NDCtKmfi13HM45AgurEQfszeDZaSJ4i9GEPaYo0GIZpEZPs9C2JQI2UVZSpPya97uSRWVA9tj+PrNOxVYvHWJAonXReFtAEMKb+Ps2KWDgdpm5MasM/jNhj6tgPRI+uiD2lQHr+7Y/tXOcKirvic4eQGMHlFIfAdHawSli5jWy0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 15.09.23 17:34, Matthew Wilcox wrote: > On Fri, Sep 15, 2023 at 05:29:51PM +0200, David Hildenbrand wrote: >> On 15.09.23 11:51, Daniel Gomez wrote: >>> This series add support for high order folios in shmem write >>> path. >>> There are at least 2 cases/topics to handle that I'd appreciate >>> feedback. >>> 1. With the new strategy, you might end up with a folio order matching >>> HPAGE_PMD_ORDER. However, we won't respect the 'huge' flag anymore if >>> THP is enabled. >>> 2. When the above (1.) occurs, the code skips the huge path, so >>> xa_find with hindex is skipped. >> >> Similar to large anon folios (but different to large non-shmem folios in the >> pagecache), this can result in memory waste. > > No, it can't. This patchset triggers only on write, not on read or page > fault, and it's conservative, so it will only allocate folios which are > entirely covered by the write. IOW this is memory we must allocate in > order to satisfy the write; we're just allocating it in larger chunks > when we can. Oh, good! I was assuming you would eventually over-allocate on the write path. -- Cheers, David / dhildenb