From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1ED8C02188 for ; Mon, 27 Jan 2025 10:38:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3A26728013E; Mon, 27 Jan 2025 05:38:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3531328013A; Mon, 27 Jan 2025 05:38:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1F2C128013E; Mon, 27 Jan 2025 05:38:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id F382A28013A for ; Mon, 27 Jan 2025 05:38:14 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 73816B2F19 for ; Mon, 27 Jan 2025 10:38:14 +0000 (UTC) X-FDA: 83052882108.10.E30BEE6 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf05.hostedemail.com (Postfix) with ESMTP id 338C4100007 for ; Mon, 27 Jan 2025 10:38:11 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=ujQ6jATg; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=iNozitFL; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=lf+wJak6; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=Pz3Ed0hO; spf=pass (imf05.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737974292; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7xZ9s/iwkA5vByA5ZEVnxTS5K9/0xpzlaG6UM0vCcZI=; b=2lI/RDi6zNQKeP0zOAPV0MYB4IkeXI6byECo0KXqUJFbo236VPigbmW/Ff7Hietud4mNdB Oi+is2GJ+4z9NMaIkOVXgIc4Oi+wteqlEbos5hdNen760MRVWwBeQ57qYGLu1/K10rmE+1 fCQEK4t3hYc+Y2ShjbeMS+x3hHV065Q= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737974292; a=rsa-sha256; cv=none; b=M7/wNYw5iOQvi+Vxcu4I8Rv+SIDm2O//8evjPs7zaIUVGCa2POP7yEVqK4tmITXq072RMm nQOCRm05oseghcMOf27jQk4SLHayV/RxTAg6+0NrWkVvvIIRABfFcHKJq/U7w4cZh0h5YR gEtpd1FokJ5sZbHSy9Uk0vBnlKZoyZU= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=ujQ6jATg; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=iNozitFL; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=lf+wJak6; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=Pz3Ed0hO; spf=pass (imf05.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 637FF21114; Mon, 27 Jan 2025 10:38:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1737974290; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7xZ9s/iwkA5vByA5ZEVnxTS5K9/0xpzlaG6UM0vCcZI=; b=ujQ6jATgQp3pJeZ/9nNEePKWDgdg/sW6p1ZLV5hUlcqxeTl6F1T8I3K6PP8V5zOyGG4BDW cgfKFGdSCDGXQf7F19Nf2+po6+4kZaILrdkFl+wkkF1GO/XtwgV+1Bn2Yq0Z4yuiasFGvK YPo0MUHZLKCZs7jpfWN2d31dZYu7vMo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1737974290; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7xZ9s/iwkA5vByA5ZEVnxTS5K9/0xpzlaG6UM0vCcZI=; b=iNozitFLSEnBka0kZXOCnTCSsS5coN8WW32Hm2Nl5FrKRq92ljp4Oi4H3fqgGUUS95rniK E4j0hI3Ucm/rXxCw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1737974288; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7xZ9s/iwkA5vByA5ZEVnxTS5K9/0xpzlaG6UM0vCcZI=; b=lf+wJak6Dw74/aXAkCCf5MmjSx6z03jq4IQStHmhMFcNRqzp+PF52bYGRgwM2CnRZRAngT z8E+/+G93ts7zomP8DY+VhqU5Iaqr/8JloD5ha2FsoMRQQcEHuqzebnvEB/AzAOgULwtR2 yS847fAKM1lVLMHFL5AvsSBzlrt+b6E= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1737974288; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7xZ9s/iwkA5vByA5ZEVnxTS5K9/0xpzlaG6UM0vCcZI=; b=Pz3Ed0hOr+FcmAgpjYdRcolY9kvUh/HgP3+ncNHxBOxgMrs13NbjgtPZ0Gc6yuTBcYoFod Hpxa/CDOEqWy1FCQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 5034B13715; Mon, 27 Jan 2025 10:38:08 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id reUsExBil2f1ZQAAD6G6ig (envelope-from ); Mon, 27 Jan 2025 10:38:08 +0000 Message-ID: Date: Mon, 27 Jan 2025 11:38:08 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] mm/compaction: remove low watermark cap for proactive compaction Content-Language: en-US To: Michal Clapinski , Andrew Morton , Nitin Gupta , Pasha Tatashin Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20250124182140.2243862-1-mclapinski@google.com> <20250124182140.2243862-2-mclapinski@google.com> From: Vlastimil Babka In-Reply-To: <20250124182140.2243862-2-mclapinski@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Stat-Signature: fxwcprgwf1x7ckop8ce9zo7oxstwqc5r X-Rspamd-Queue-Id: 338C4100007 X-Rspam-User: X-Rspamd-Server: rspam06 X-HE-Tag: 1737974291-973955 X-HE-Meta: U2FsdGVkX182hKJNsNsdvLd6lpHHlLfNLqHwqOmQsCnIliwq8T3B1QB0Q0VkhWzxaH3Dfh6ernbRRloaCklQtJ61qR9+M0/qh54FidMojuunKr8wMu3zmj90zyBuw8+uabntBrrZjBw00jkk+iSgG2qvq721yk15SQVBA8PHMPfOaTUmIofAJGrDpCm7FUOD+no1Zbhlrhn40DpCqkdQQBumzfV+oY4UGUQXJLHi6c3oYf6g0GK8fWeKHLJtyBAdiO3lNEzOyNcutG39av+yIFQbdy2W0q+x7L5G9otOpMlPmgRW8d1+ZjOrnZCm29hm1hfKEgga+RDtbgY/qKdLvmB/Rwdns1mSX194BBtpEEoigzc1i9q+wYt3D/dZnYWN3nNOzJNTUSg8DUur7Q5hGlZbCy1xsFhKaEo6B2M5gZtkOnnR9esV99B+GEnHbxS2UmJXjedq6IDxQLh0TRTyN5Lghk3TWX4wm+NOA67zsCnmt3q/mk/2Na3fEHI15ZhmxGisf5m+a8U5QE0kWGp61VPsrfit7y54aJcPXjPwE5n+dvDN5htZi1UduullMTiErV/uqf4JRWpKq+W45dCbROzlkf6bb6ux+lak0CBrI+EmxARIZj6ARu6W/OrWMgfiblXQkYibnhg7utRCbjCSferinacqyoo4ckVuc8z3ago407kJdSLidJi6a39cwyZ3onD8vExN+AHXX5A+zKmcmGzhuDDCwgVziLNGPgN1uCn/AE4axFvA1ZrLE23O0IpUaFH0nOjECrxZtPv+OrhT7VNIFPen9gb2vgmZnbHTf8yRoes0+t3U3vidF12OslcB4PY6v1zCb7Qa6XKJqn+yIOTRnj4/+4f5DKPZl8M4I0ghdjk2Pyc/t/WUrcwsZqIV+4PGZWCfFtwQZ+bPFOqcSadKI0Nbl3XcUne/kOazblKKwcn9i2NrOQV/GPYchpK6zQ5yAkF56PQUjlefjMu Br7ex1E5 C9PJ7FKfsUCT0hGyfSmGNlMwq2PnZcnLbAXJQtHIogHBP0HJ+6BlL2yZ7pjyAd6SveoVnVdYb3OQBZL6OgDdF3XMmF76QstoX/UBC4RX9mT/FEQyGOyWcKRAKs1HTGmiTMqQImJAkWZPUugIgN1V0zBqP5Y5X07fY1tu/1hxOxHWJngHqBZuxfKwdUn9ojziuJYWavAphY8hALBzokZo4rZ4o8kvH5/bvVeHJoa33ya/4P4FBbr076/J6ARSEwvNKkYhq3ZEii9n4JqR8AAjT405Mn0DvJEYHIzriyZfgXtqRXBQvnpYd5M9vDQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 1/24/25 19:21, Michal Clapinski wrote: > Previously a min cap of 5 has been set in the commit introducing > proactive compaction. This was to make sure users don't hurt themselves > by setting the proactiveness to 100 and making their system > unresponsive. But the compaction mechanism has a backoff mechanism that > will sleep for 30s if no progress is made, so I don't see a significant > risk here. My system (20GB of memory) has been perfectly fine with > proactiveness set to 100 and leeway set to 0. What if you don't set the leeway to 0? In other words, should we keep the cap in some sense but make it depend on the leeway? > Signed-off-by: Michal Clapinski > --- > mm/compaction.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/compaction.c b/mm/compaction.c > index a2b16b08cbbff..29524242a16ef 100644 > --- a/mm/compaction.c > +++ b/mm/compaction.c > @@ -2253,7 +2253,7 @@ static unsigned int fragmentation_score_wmark(bool low) > * activity in case a user sets the proactiveness tunable > * close to 100 (maximum). > */ > - wmark_low = max(100U - sysctl_compaction_proactiveness, 5U); > + wmark_low = 100U - sysctl_compaction_proactiveness; > return low ? wmark_low : min(wmark_low + 10, 100U); > } >