From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A411AC77B7F for ; Thu, 26 Jun 2025 08:17:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2FAA06B0088; Thu, 26 Jun 2025 04:17:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2D0066B00A7; Thu, 26 Jun 2025 04:17:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1BF406B00A3; Thu, 26 Jun 2025 04:17:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 05D858D0001 for ; Thu, 26 Jun 2025 04:17:22 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 8250A5B74C for ; Thu, 26 Jun 2025 08:17:21 +0000 (UTC) X-FDA: 83596847082.20.FA2318C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf01.hostedemail.com (Postfix) with ESMTP id 00BD14000A for ; Thu, 26 Jun 2025 08:17:18 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=I51doo+2; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750925839; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=55+jYEaEhNtGFPfW/0vKnlZGNZZvZBUpEkOyrpcO9hQ=; b=WsPEhoag5lMCkW2Ez2mOYiLmrJTIIUdYSasLxe9OOMaY+LJz5Zsur5JyRz6eLWqlzM3OfI l+5XM05QNlbx5ei7scgS6drMgdxz3IGBaIZBL3/R8al0pO8DS8kDyQQQLQfDQTkTFEoANE nGG/7eNttMwltCYWYeJB8l98hgM2+a0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750925839; a=rsa-sha256; cv=none; b=asWBlmFsMOIsDuL3YcayRW2Tfc+5jWdG9lGolWMfHDXKbQKlLu8iYlSNF09GOlsqpAhaD7 KIjBLaM9UCaP82OcgvEHY6xcutllPIHLW1xfd8rwn4rkAyG/4MFRlJfk6qpqSaaDnBBHgX SfVh3unkFhntQBoY4JBQ10t69nSC0zw= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=I51doo+2; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1750925838; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=55+jYEaEhNtGFPfW/0vKnlZGNZZvZBUpEkOyrpcO9hQ=; b=I51doo+2FbzXJUee5kVio9RN6k+Ny9DK6CaTsRNjIGWxzHgfaGkV313mxV9FeUlXYMZ6HI wWxUFm6NkYSgciuv1uPUNC5+oAGJTsrfqO9eLscFwcjrFrcTUnxzFmpagGZtMXyYTZtw3O zVh8EVJkd7u70kvqMLqh2sNwzDCYDKQ= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-632-uBuAtnDjP6CQs4vIZErxcg-1; Thu, 26 Jun 2025 04:17:17 -0400 X-MC-Unique: uBuAtnDjP6CQs4vIZErxcg-1 X-Mimecast-MFC-AGG-ID: uBuAtnDjP6CQs4vIZErxcg_1750925836 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-3a4f85f31d9so262358f8f.1 for ; Thu, 26 Jun 2025 01:17:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750925836; x=1751530636; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=55+jYEaEhNtGFPfW/0vKnlZGNZZvZBUpEkOyrpcO9hQ=; b=gtlm1rL8JG9TC++ybxD49p14sF0YmevQZfyxuJwWZB0RfK/mGIH9fl30RmQBgMH2JP vYNfmFFlp+cdEYCMLXYRrbcsmORKFb2/0DZqdL2Jlrj9HdJSY1FHW1qOKG2rl7pjJEdr o+XrX0fDyxblL2DHOXByxzOMhe60WJRE2a2KxUcTtJ7mJGbib3B/f3T5Es+77/juNn+1 S3sGfYM4hRo+ALROTl4VEp6HnHZY7DRd0hSzVt4hVQPqEcZUI+rTvdPfYAzEA50jZcef 4j5dNBMUzTg0pszPDgG+A3Cy/2fKYGOkUnKtdMwrsqCtkyrvGssfvaIZGGQudQ4JXrDr HeNw== X-Forwarded-Encrypted: i=1; AJvYcCUeSYjph7TpyN/BXo/hIY4E+D6pSH69UcndJ3tq0Thl68Av2GNVdj3BnMI4S+YCJ7yyFBSQlKQe/Q==@kvack.org X-Gm-Message-State: AOJu0Yy9P4zcyi+dT5IYCcj0bl4LPLf9PGRGRsZD/1XxCp1SUVDKCQr3 JPzFseZBOhLSmbgsYVjblewoH81ywRd24izIyM48rQLu6P9wjVA0LuuRS30sRSsyfNFRvi4r1kB rLAGOMVVWvNGcFj7eQTg2+jhBcpf7VRpuS9vhXSg6Te7Yzi7nS34k X-Gm-Gg: ASbGncvPWBjNgPgtjMXwPK0ycbDUHONtctxzID9Cq6VwqWTCT2XThA7P8AigiOZT6t3 vkYOSlF7+580SR7Q9oX46w1JZ0c3eS75s3TMts7qXsbv9NansMOotOX7O4KILHY61p87Jqay9zE s6nLiK79Nk1yIMOcSSId9n5Dxax7Cz7ztvqMEN51H5LWlA+nhLLNn1gY+4wqzbbwxPzOjtibc9S P43IdQ72GAXO3ky54kKv6+NfrJu3KugscD/kDZI3CGR6lFMIGx4RqntI97Be1i/L8b24qVrKMg9 ixn8V46+ORCPXBF7UgkM/t06sEdPG4M2Fc/rsaWDTCdHogIIugvQ0MrW8LJwC1EW2Y1psiLxnSu PrfOen0LdAtmqXq2PCfGcIXCzOhXjOhZw76424Dw6JiC2HvRoCw== X-Received: by 2002:a05:6000:1885:b0:3a1:f564:cd9d with SMTP id ffacd0b85a97d-3a6ed664553mr4593032f8f.36.1750925835703; Thu, 26 Jun 2025 01:17:15 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEhcXZypQm7XHMVnXTuYK23gyUnWaEv0Gc3DtKcA7Ooe9VhmSlfjk+Trd4HOr6R6kONFyi0fg== X-Received: by 2002:a05:6000:1885:b0:3a1:f564:cd9d with SMTP id ffacd0b85a97d-3a6ed664553mr4593002f8f.36.1750925835318; Thu, 26 Jun 2025 01:17:15 -0700 (PDT) Received: from ?IPV6:2003:d8:2f3c:2f00:8afc:23fe:3813:776c? (p200300d82f3c2f008afc23fe3813776c.dip0.t-ipconnect.de. [2003:d8:2f3c:2f00:8afc:23fe:3813:776c]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4538a3a6716sm11886905e9.11.2025.06.26.01.17.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 26 Jun 2025 01:17:14 -0700 (PDT) Message-ID: Date: Thu, 26 Jun 2025 10:17:13 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 3/4] mm: Support batched unmap for lazyfree large folios during reclamation To: Lance Yang , Barry Song <21cnbao@gmail.com> Cc: akpm@linux-foundation.org, baolin.wang@linux.alibaba.com, chrisl@kernel.org, kasong@tencent.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-riscv@lists.infradead.org, lorenzo.stoakes@oracle.com, ryan.roberts@arm.com, v-songbaohua@oppo.com, x86@kernel.org, ying.huang@intel.com, zhengtangquan@oppo.com, Lance Yang References: <2c19a6cf-0b42-477b-a672-ed8c1edd4267@redhat.com> <20250624162503.78957-1-ioworker0@gmail.com> <27d174e0-c209-4851-825a-0baeb56df86f@redhat.com> <938c4726-b93e-46df-bceb-65c7574714a6@linux.dev> <5ba95609-302b-456a-a863-2bd5df51baf2@redhat.com> <6179dd30-5351-4a79-b0d6-f0e85650a926@redhat.com> <5db6fb4c-079d-4237-80b3-637565457f39@redhat.com> <42f1d84f-2d17-43b7-8fa2-83322fcca44f@linux.dev> <9bb1e917-891d-4e1b-915f-98cdd5fc578b@redhat.com> <42343413-7089-404e-8ce0-dd0025dca04c@linux.dev> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <42343413-7089-404e-8ce0-dd0025dca04c@linux.dev> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: RbcJGmRcVelUEKi3I1g2TmizESk8BFlS2-GCloAjLi4_1750925836 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 00BD14000A X-Stat-Signature: 36j6e18ckizpwpqi9kz9r4wmnoesn5mm X-Rspam-User: X-HE-Tag: 1750925838-273889 X-HE-Meta: U2FsdGVkX1+vUZTkVrrlfwdA0SFwF/ZMDmq42qEgz7mpJD4yjNle+P209H4LI+dNuWbORSdcTibEL3Ls5QduQUB5mdwXLPpyo5LsnOEhhtCCxAOL+92y98Hmcfn+MlSlgnjHI75thPTppwVWpDjuSgCymY9gvZVG9rrG4W2Pv5xtMlQPj1MK6pfk0ai18MnTFa882DtZ4vlJ0ZvBI/15DQJlz45dw0Txr3LjIxL8b9kfuZOJaNKrpn81p5/DNcp9uePzItuhWS/D/8YNcL+k48+A08xUZx2iDVZ9bct79dtSVWcs+yWT64p4yf5gChd1HiwIosLXuRZoRrC+zieIQAio/CF8E0XAz2RlZet07zw/Rs+FMlKk9bHOL8Incs5+BpUwQdqzayJwUZRNp0CXUi0DxdDhRMuPx9q4h6ZApfWp0F2WCeLtPw+56nyqEiW/LmbbIKgDnZqXIJwPvmc/eCrGYmhIq+B/Sf3zo1/SiFV2mGEMzSNQOouFhkVAYurZMtaUP4Fikes6T2hzTwhFtwiSKGWubtk7dpLk2m4TnWOALKS5WJGnuXMuK9LVAzfgk3Fpe9YnSBBICva6aypS71k7n8ODcJOW0cL4RA0Q2XcDAY4qEnE5gsQib86YaSDkBLDIRfumIC1IWctqAJvAlzF9MWOb+OIzyx/AhzIpwbzEEaW5/8KhIggw7sg7VIXekh+Xyv8zBK+GwN/ERctSaU28lFS3nktw4XjyUa7Jua8qoH4jpO627RyaX9f4yuWD70oJ3xGZC58GMG2hQmMgpj92Fxp4l24BP4jVUQ9KgMc7RSgorL0L9rX4UC0tb0RJcupUSiYVvXKxHynPxwCO/DkzNlNYyHZY3pLif6X2G5aR4vos4UD9V1yBMW36NTgMEa1wgVM9uRnMZPTwcvnCJkEhOw7cb9zMXBkfpxH05hwiDOVH7qxCJfIbC7+obPFUQeZRlaPWi0G7NO27tNN tREvEr5S xsXtwy3OiXgByGqPwbzaXADdhOzS7Q+mCgdCwI6dEHoy7t2ThA62hGc3LjjdjYTjFV1UTw+TM2NsAMMKfTRO9/Jm22+CgoQGwZNi5SezUKz4vQ2DbTcD6C4I5hXc3On89T+md1HKMyTUEtfHeZY4Qgf14FCgMqsL+BRJNTlGhsEaqNOQwHr/0xqBbOvHjAz7XBEVvx1axqXeHuaL9u7gVA9Ef6/8qbcJu4vPIoBQG+KI2h7mvSW1Gt46AaCAwZ6g7S5lgjfR4dnBnCad9MqBtAifrsDazUWLjm5CkDo29SkZfxOsPSVQFGICeh3su9H71CJAXw4YTF0ualJqM6pPNRLGq9rpcr+x7wEqX6Yib5ZtL9TGptBsUyClhKJH0EFwhBWe5LtKJvxd5Rbdwvq3fvYmH21S+tMn4Ga0G9bdm5nihIy4D4w8DQC/tSL7Pu9C0bl+MDSrrwIPsAYcmY4mUyKcrp0LqTAKAcgRS X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 26.06.25 03:17, Lance Yang wrote: > > > On 2025/6/26 05:03, Barry Song wrote: >> On Thu, Jun 26, 2025 at 12:25 AM David Hildenbrand wrote: >>> >>> On 25.06.25 14:20, Lance Yang wrote: >> [...] >>>> Hmm... I have a question about the reference counting here ... >>>> >>>> if (vma->vm_flags & VM_LOCKED) >>>> mlock_drain_local(); >>>> folio_put(folio); >>>> /* We have already batched the entire folio */ >>>> >>>> Does anyone else still hold a reference to this folio after folio_put()? >>> >>> The caller of the unmap operation should better hold a reference :) >>> >>> Also, I am not sure why we don't perform a >>> >>> folio_put_refs(folio, nr_pages); >> >> Because we've already called folio_ref_sub(folio, nr_pages - 1); >> Looking back, it’s kind of ugly, huh. >> >> discard: >> if (unlikely(folio_test_hugetlb(folio))) { >> hugetlb_remove_rmap(folio); >> } else { >> folio_remove_rmap_ptes(folio, subpage, nr_pages, vma); >> folio_ref_sub(folio, nr_pages - 1); >> } >> >> I assume Lance will send a patch? If so, remember to remove this >> when switching to folio_put_refs(folio, nr_pages); > > Ah, got it. Thanks for pointing that out! Obviously I was hinting that the split refcount update can be merged into a single refcount update :) -- Cheers, David / dhildenb