From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94C71C433EF for ; Tue, 26 Apr 2022 05:38:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8EC156B0073; Tue, 26 Apr 2022 01:38:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 89C1B6B0074; Tue, 26 Apr 2022 01:38:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 78AB96B0075; Tue, 26 Apr 2022 01:38:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.27]) by kanga.kvack.org (Postfix) with ESMTP id 691706B0073 for ; Tue, 26 Apr 2022 01:38:12 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 4079760814 for ; Tue, 26 Apr 2022 05:38:12 +0000 (UTC) X-FDA: 79397924424.10.BF5FDC6 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf27.hostedemail.com (Postfix) with ESMTP id DCF7440041 for ; Tue, 26 Apr 2022 05:38:09 +0000 (UTC) Received: from dggpemm500023.china.huawei.com (unknown [172.30.72.57]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4KnVy25GdFzfbCX; Tue, 26 Apr 2022 13:37:14 +0800 (CST) Received: from dggpemm500001.china.huawei.com (7.185.36.107) by dggpemm500023.china.huawei.com (7.185.36.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Tue, 26 Apr 2022 13:38:07 +0800 Received: from [10.174.177.243] (10.174.177.243) by dggpemm500001.china.huawei.com (7.185.36.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Tue, 26 Apr 2022 13:38:06 +0800 Message-ID: Date: Tue, 26 Apr 2022 13:38:06 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.5.1 Subject: Re: [PATCH] mm: use pgprot_val to get value of pgprot Content-Language: en-US To: liusongtang , Anshuman Khandual , CC: , , , , References: <20220425081736.249130-1-liusongtang@huawei.com> <22536b1c-f38d-45b1-8187-636c158b8e4b@huawei.com> From: Kefeng Wang In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggpemm500001.china.huawei.com (7.185.36.107) X-CFilter-Loop: Reflected X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: DCF7440041 X-Stat-Signature: bruudu8ifo8smfw5pyq6d8esh8f7sopy Authentication-Results: imf27.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf27.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com X-Rspam-User: X-HE-Tag: 1650951489-212929 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/4/25 21:48, liusongtang wrote: > OK, Shall I add "Suggested-by: Kefeng Wang > " to these patches? > It is unnecessary ；） > On 2022/4/25 18:40, Kefeng Wang wrote: >> >> On 2022/4/25 18:29, Anshuman Khandual wrote: >>> Should have added 'memory_hotplug' in the subject line. Otherwise >>> this does not specify where the change is (neither does the commit >>> message below). >>> >>> mm/memory_hotplug: use pgprot_val to get value of pgprot >> >> >> $ git grep "pgprot\.pgprot" >> arch/ia64/mm/init.c:    if (WARN_ON_ONCE(params->pgprot.pgprot != >> PAGE_KERNEL.pgprot)) >> arch/s390/mm/init.c:    if (WARN_ON_ONCE(params->pgprot.pgprot != >> PAGE_KERNEL.pgprot)) >> arch/sh/mm/init.c:      if (WARN_ON_ONCE(params->pgprot.pgprot != >> PAGE_KERNEL.pgprot)) >> mm/memory_hotplug.c:    if (WARN_ON_ONCE(!params->pgprot.pgprot)) >> >> You can change other's codes too. >>