From: Kefeng Wang <wangkefeng.wang@huawei.com>
To: liusongtang <liusongtang@huawei.com>,
Anshuman Khandual <anshuman.khandual@arm.com>,
<akpm@linux-foundation.org>
Cc: <linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>,
<nixiaoming@huawei.com>, <young.liuyang@huawei.com>,
<trivial@kernel.org>
Subject: Re: [PATCH] mm: use pgprot_val to get value of pgprot
Date: Tue, 26 Apr 2022 13:38:06 +0800 [thread overview]
Message-ID: <a5b58a66-bdc3-94df-6af5-c647da888c17@huawei.com> (raw)
In-Reply-To: <a22d0e25-cc72-3cf8-c893-e962c0001028@huawei.com>
On 2022/4/25 21:48, liusongtang wrote:
> OK, Shall I add "Suggested-by: Kefeng Wang
> <wangkefeng.wang@huawei.com>" to these patches?
>
It is unnecessary ；）
> On 2022/4/25 18:40, Kefeng Wang wrote:
>>
>> On 2022/4/25 18:29, Anshuman Khandual wrote:
>>> Should have added 'memory_hotplug' in the subject line. Otherwise
>>> this does not specify where the change is (neither does the commit
>>> message below).
>>>
>>> mm/memory_hotplug: use pgprot_val to get value of pgprot
>>
>>
>> $ git grep "pgprot\.pgprot"
>> arch/ia64/mm/init.c: if (WARN_ON_ONCE(params->pgprot.pgprot !=
>> PAGE_KERNEL.pgprot))
>> arch/s390/mm/init.c: if (WARN_ON_ONCE(params->pgprot.pgprot !=
>> PAGE_KERNEL.pgprot))
>> arch/sh/mm/init.c: if (WARN_ON_ONCE(params->pgprot.pgprot !=
>> PAGE_KERNEL.pgprot))
>> mm/memory_hotplug.c: if (WARN_ON_ONCE(!params->pgprot.pgprot))
>>
>> You can change other's codes too.
>>
prev parent reply other threads:[~2022-04-26 5:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-25 8:17 liusongtang
2022-04-25 10:29 ` Anshuman Khandual
2022-04-25 10:40 ` Kefeng Wang
2022-04-25 13:48 ` liusongtang
2022-04-26 5:38 ` Kefeng Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a5b58a66-bdc3-94df-6af5-c647da888c17@huawei.com \
--to=wangkefeng.wang@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liusongtang@huawei.com \
--cc=nixiaoming@huawei.com \
--cc=trivial@kernel.org \
--cc=young.liuyang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox