From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43384D3C525 for ; Thu, 17 Oct 2024 17:10:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D596E6B0083; Thu, 17 Oct 2024 13:10:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CE1E86B0088; Thu, 17 Oct 2024 13:10:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B0DF76B008A; Thu, 17 Oct 2024 13:10:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 8F23B6B0083 for ; Thu, 17 Oct 2024 13:10:27 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id AEEFB81423 for ; Thu, 17 Oct 2024 17:10:17 +0000 (UTC) X-FDA: 82683732600.30.5C38BE6 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf11.hostedemail.com (Postfix) with ESMTP id 105CB40017 for ; Thu, 17 Oct 2024 17:10:12 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=iakK532Y; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf11.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729184976; a=rsa-sha256; cv=none; b=tzic62PFFViJZvhNaZMhKAOmLDgLd5rakIzJNJeSFlWNDlv1bsT6IDo2dAO2jA4x9HEZ6m wEBOO9DjW4+OWCdSQ0+WwjiqGTuWqPI9QJ6g84HVHIXMszDySCdFW2/1lAMt0xr7d5HMAg Ne5a1/5/TXH85DOCdEXxH2t2ZC+e3eQ= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=iakK532Y; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf11.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729184976; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=aRigJuIDB/xTaE7A8orTIswNtUgAH5fWYtB0DzmEb9s=; b=WIMbDdjBryI4Tn2XKM6NQJgvLGQ9ViRBVnEHU5P1hcsg/4BTl5qw62vCS0gxjnUJgBQdUV M8NB2lo0gv8U3qIBPrRpiZUudULobwHP7lqsaCSEubasKCwrJU1aa5qzgepxsN9mTSpF0Y yqZY0/qpselSyGxXOMh9LaZXOwafjrU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1729185024; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=aRigJuIDB/xTaE7A8orTIswNtUgAH5fWYtB0DzmEb9s=; b=iakK532YCDoG7SMkzc5s9yOXk/oOAZXgbuY5rc3ToGxDkSW2bXcJ9AUsCV04ukFRL04lb3 fadDnVUQ135lyh8A645KDKlxWZlmGSqcXZwcZeEjeD4P/YM9cqZDRfEy8VlqS89VGxQMPL 4muS6RfmKAj23HZAAtDwUCkjMYaPnf0= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-627-p2wO2FYgOCGJufS7LgnCsQ-1; Thu, 17 Oct 2024 13:10:23 -0400 X-MC-Unique: p2wO2FYgOCGJufS7LgnCsQ-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-4315ad4938fso6996745e9.0 for ; Thu, 17 Oct 2024 10:10:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729185022; x=1729789822; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=aRigJuIDB/xTaE7A8orTIswNtUgAH5fWYtB0DzmEb9s=; b=NgAvq9cCnV+NmnjuT6MNNnTqfNSAqJfgmbNV/eFse3MHPjOglyDVR6ZBh5umJifXAl bQ8lgYS4+coY70QvuLTn6cClEKxDdffp/41u90hM/bt4ymlyKi+aXdGmhV87ANwqQK8K DyW5oxG495cpyzDz+4+jMFMeQYMYOY3WBm50FjQwqjX8sgAdftUXqWbUwUbCmuv0qzMv 2XYvHwIHoBt/tZKSLagETtFJtT9DpHxB68dU7/OylTKkKVGEvtkZmvGrKNiXbxO4AVx3 5Y6znyHKeyGcS4zEKWGk2oRGEGsHUitHIG42hi9jxopkGTWnMnFbbH+HXHnTOzXn/8Sy noVw== X-Forwarded-Encrypted: i=1; AJvYcCUqK74BfO/0Clfn8veOMk/6GXdxVaNXSelDoEVQ3HOdLae3s0aMcv9bbUQMUA4JvjzT2iZFMtSF8g==@kvack.org X-Gm-Message-State: AOJu0Ywx+XDMIPRDrjcvUZGvO1Svbyev04ygA1uHfsy5P1OXP8xUp8Fn XsQep2JfUlN40h9fTQVcjGDVtR1qlIiVmKQ0RQkfG1udD/eBuWEuH+0WxQIcHfkQCh3tcJxmuod uMGY2vfqQXYy1GBTEXwtNQBmGpwYYF4CPWsRyfsuhmx0fIFgwZOa3rxQP3ys= X-Received: by 2002:a05:600c:1991:b0:42c:a580:71cf with SMTP id 5b1f17b1804b1-4314a384625mr69295485e9.30.1729185022005; Thu, 17 Oct 2024 10:10:22 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEs3zbSgz2t2BrSUeLT1tNXcidU7WUKKFeXlutV2SkuOujObegNY06KCbWB26fyjuXWz4IVvw== X-Received: by 2002:a05:600c:1991:b0:42c:a580:71cf with SMTP id 5b1f17b1804b1-4314a384625mr69295225e9.30.1729185021555; Thu, 17 Oct 2024 10:10:21 -0700 (PDT) Received: from ?IPV6:2003:cb:c705:7600:62cc:24c1:9dbe:a2f5? (p200300cbc705760062cc24c19dbea2f5.dip0.t-ipconnect.de. [2003:cb:c705:7600:62cc:24c1:9dbe:a2f5]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4316068d08dsm1417875e9.15.2024.10.17.10.10.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 17 Oct 2024 10:10:21 -0700 (PDT) Message-ID: Date: Thu, 17 Oct 2024 19:10:20 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/gup: stop leaking pinned pages in low memory conditions To: John Hubbard , Andrew Morton Cc: LKML , linux-mm@kvack.org, Alistair Popple , Shigeru Yoshida , Jason Gunthorpe , Minchan Kim , Pasha Tatashin References: <20241016202242.456953-1-jhubbard@nvidia.com> <1f8dcae1-416e-43cf-8dda-5440e0db4c00@redhat.com> <9a2232d6-74c4-426f-bfab-668c5c5ad143@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Queue-Id: 105CB40017 X-Rspamd-Server: rspam01 X-Stat-Signature: n5c35nedgei18fh9nczufdt6c8ppe4wy X-HE-Tag: 1729185012-975848 X-HE-Meta: U2FsdGVkX1+Ihh9JCWPTRNxBafQ9iPk0aOeanoINV/rhAfeFTsWbiKeP2IiaKtfiwU4HuGCSiOEm1jCTxucMeYJ+MuN4MpDoIYHEU7jzZwkVwz3zbgDNHv0FOyKvBN4eR762wXY99zv0Moo2mfgMArQxDp9wwKf2m8xSsBYgEbZwGEczOjFDbAj+sNgX98RZatrXAQF/Q1wH78lkTRYPGFPFcIjeA1OTHb62Sw7CO08LR72t8RFC3qoPm9r7ZiV36GVQQAjiswhn03/kBivblaOyxkuCE4C2qMIKY1pW172UdkpmH5qK7EJhqXgeouxFaZEK+m6vquPRuZMql5phlgAvxW8JJ9MvpG/a0Iyc1SR3XaTMyh1ggsKQ5XWla9E1xbk7WEjcKvkC9V+XyxQjg6v2arJ3TmOnkpYWCg4y65jHGl9TYSrvZPtYuaLnAIub/KCD0kBp+ZchTD+/iKq4x3jLKxqFf5tsh8Z2J275xHXHGZqyTkS2ofPSC6NFAA6KR7o1a37UzbEBrLEQRAH5KzJUMbw8FbxxQGyTLD314XOkfuEUjILNOs8Dohb9JvvZJVbaMIrk1XQafLrVwAFNzDPnJ+tS6THSm+0VuupDuZZ+8CSyYQ1+qK+Ztel1G5yGv2BMfUdPWwtcBR76byHYIN6w0L1A9KNXRZPtNVboTl75dfPbY0A3ba4etdFdxaogXG31E8nEkEwtOaW/DFPlM13Uw8CcCP4JK9eeIzkFBjvO7Nqn90RD+A36gsPym6jJw+8N0T3QDBtzOr+QQka+53JULDm4C9VQEohzWaS3j76g4HKjT1ZZZsejUAgYd/Ltqj/ItczVsO6MaJx0JjEMPKhRngO2L4oMnk26AzDAWnBcJ7Yf4xa4Fx1jE5e7BPqmmYCeHceLXmpUEyUVKF7Qu4YVMKr8+YxXqY5Bi6TM+1nwokiLnuiKg/Rn6qkMLl0Nf8hG+lkwzBX6XD/Ouqe 1sbxX55j xEuTbtlKrPzOSgkEQz5HQ6AVBzeY3FxhGK5yUUWVVjytumY39sBoNqI60xvub0tdI5I+E4aRivXJzG1WMBKwFmIxYWriXjJwJ6WS3JEMCM5ueD+BEHK35D7db9hwGlM4RP6Gpeo8J71MgxKoHr+ld1NpY28u2jsSd1aoRKm83ms4xiWbPG2OdlwW92nYMxc0MCKZHuOrajcISomfBNZY0y56L0JMYPA23QUKvQsy19Cz1qxc6Yfd7HFYKOXxDO4vMVzhKENfYJIxg3AeWtiZ0G65He5f69XaWwNNKLUSDegIOuuPiYb3MlFuC6T/RzYm8/1MD4YwS05RjRhWUbc5EcljAm2oF7fNiJqMNu0IkpubVnKDiQzTIuiTvdgkY/NB461GcUcF3e6VreBQgSzCEdo14hTot9n3NYzS3 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 17.10.24 19:06, John Hubbard wrote: > On 10/17/24 1:53 AM, David Hildenbrand wrote: >> On 17.10.24 10:51, David Hildenbrand wrote: >>> On 16.10.24 22:22, John Hubbard wrote: > ... >> And staring at memfd_pin_folios(), don't we have the same issue there if >> check_and_migrate_movable_folios() fails? > > Yes, it looks very clearly like the exact same bug, in a different location. > This complicated return code is the gift that keeps on giving. Although > likely people are just copying the pattern, which had the problem. > > >> >> diff --git a/mm/gup.c b/mm/gup.c >> index a82890b46a36..f79974d38608 100644 >> --- a/mm/gup.c >> +++ b/mm/gup.c >> @@ -3708,12 +3708,10 @@ long memfd_pin_folios(struct file *memfd, loff_t >> start, loff_t end, >>                 ret = check_and_migrate_movable_folios(nr_folios, folios); >>         } while (ret == -EAGAIN); >> >> -       memalloc_pin_restore(flags); >> -       return ret ? ret : nr_folios; >>  err: >>         memalloc_pin_restore(flags); >> -       unpin_folios(folios, nr_folios); >> - >> -       return ret; >> +       if (ret) >> +               unpin_folios(folios, nr_folios); >> +       return ret ? ret : nr_folios; > > That looks correct. I can send this out with the other patch as a tiny > 2-patch series since they are related. Would you prefer to appear > as a Signed-off-by, or a Suggested-by, or "other"? :) Suggested-by: please :) -- Cheers, David / dhildenb