From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DDEF4C47DB3 for ; Tue, 30 Jan 2024 03:36:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 722546B0096; Mon, 29 Jan 2024 22:36:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6D06E6B0098; Mon, 29 Jan 2024 22:36:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 522EA6B00AF; Mon, 29 Jan 2024 22:36:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 3EE996B0096 for ; Mon, 29 Jan 2024 22:36:44 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id EF983A1F69 for ; Tue, 30 Jan 2024 03:36:43 +0000 (UTC) X-FDA: 81734565486.27.CCAC02A Received: from mail-oa1-f48.google.com (mail-oa1-f48.google.com [209.85.160.48]) by imf22.hostedemail.com (Postfix) with ESMTP id 269F7C001A for ; Tue, 30 Jan 2024 03:36:41 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=BjNtJdrt; spf=pass (imf22.hostedemail.com: domain of zhouchengming@bytedance.com designates 209.85.160.48 as permitted sender) smtp.mailfrom=zhouchengming@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706585802; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jkSLJRp1f0GwczdGFgnBAEqAFYQupxf3SUPmnpRy8AM=; b=JYlts2lsDj4ONfTb4JWsypYSSqPxRHVJEeyWm3YEPHjzvIwlPWaBbQWJ1W87at9F7llreu X14lLyv8YKdnm1SiQxvKqn19rpDCvXZmPNqWF6sk8htiZkA9E1uASrmnA5FYJIJnxiHHcO g3i846HVGK82zQdHtPxJM47jrqNPLRk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706585802; a=rsa-sha256; cv=none; b=hjtfF/Zj7oBAB8SEQ0H4yisLH2PVY+bS174TBvclR1dRvHcy8TYcrUWf6iVRkwWLMnp8C4 0Ko9ISdyAqfjWdYds1sfpWRqLrnQICX7cIPC0MLXFk1BRw3RqvcvGrIU2egMHU9GQ3TJiB +104OoWf0d2bhVI7gRvBUHOH7Sb8w3M= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=BjNtJdrt; spf=pass (imf22.hostedemail.com: domain of zhouchengming@bytedance.com designates 209.85.160.48 as permitted sender) smtp.mailfrom=zhouchengming@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com Received: by mail-oa1-f48.google.com with SMTP id 586e51a60fabf-216f774c827so836227fac.2 for ; Mon, 29 Jan 2024 19:36:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1706585801; x=1707190601; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=jkSLJRp1f0GwczdGFgnBAEqAFYQupxf3SUPmnpRy8AM=; b=BjNtJdrtLlbQJXdo0ZFq7mGD6xGFKsQNqAl8n1DG0iOCp/aQwK11dTKBRp6UWjop/Y fL29uXrgIk5Vn+JRSvX4+lfLUklih6u711NCfAARDY9aqc7C7IMb1eIFB7M38S3vaVE2 RswALduM5NK8o8l1+3dk05R6U2yirOJNjhP7Ae6VXKTFo0ttGcoa5gooOssQ1Uqy881y hjeF9sA0JcBVyLJH0eiWYNrQWIdPKnzMWOX9z8ULgp37r8g7Urru2EiHAcrsQeUilzCM Q1IOSvF27G9DNqN29geutdM99Z+IbsaD3Sz9PGEj/mMs2wABmPl2Vw1xda91XQUGrKQy 3/Hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706585801; x=1707190601; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jkSLJRp1f0GwczdGFgnBAEqAFYQupxf3SUPmnpRy8AM=; b=rtVY5Q+fHzEUUSUrQSAG7r1Lr33ZGCrY6DEKpHRINvWHaBo3XYMA84UUXNIpzEj11E XUuPqZjv3Ono6QyycO55EEYgTOntdgKrVMVLNcAItG4/gPMqaJAHeRh2DLQuHZVQ1XBH FWpqqNhSHlpQUvzTaibunitW+GZz6t6O4nDfcxN2WdMm5TWhjr/cS2S/Gp9fu72UrKPq 2eDcX96vUocBaNoLoRBuELsX8XoaUM2RuGFRlKxCDsMp5pSs33SBu28YUZCHG+HCfzQD LIncZLj9t1nOs2lQNT2f5M0L0yy2PAUMFgMPxMa13ue3tmFYcFCHKviX7veFmxcWHjeW 4twg== X-Gm-Message-State: AOJu0YzY5LCXjUjT0AUx8c/gIoeXMBWp1xjuBjM37CyEjk4JMU7a/RnC nDvBSZsqgoSGNyJ9zQvMQF52bZDI5Gp+kJQ//rovn1ja5qs0HiQ/N3ACvCisEKw= X-Google-Smtp-Source: AGHT+IGhejiwxqUrfIq7Qwbr9y9UAsaa9m0NcDmC3zPYmk95tMEjPTt/WMFF2//2tHkkjTICnb2+uQ== X-Received: by 2002:a05:6870:47a4:b0:206:a798:8d88 with SMTP id c36-20020a05687047a400b00206a7988d88mr3337698oaq.29.1706585801353; Mon, 29 Jan 2024 19:36:41 -0800 (PST) Received: from [10.4.207.234] ([139.177.225.234]) by smtp.gmail.com with ESMTPSA id y17-20020a63b511000000b005d8b481c4d3sm5561909pge.87.2024.01.29.19.36.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 29 Jan 2024 19:36:41 -0800 (PST) Message-ID: Date: Tue, 30 Jan 2024 11:36:38 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 01/20] mm: zswap: rename zswap_free_entry to zswap_entry_free Content-Language: en-US To: Johannes Weiner , Andrew Morton Cc: Nhat Pham , Yosry Ahmed , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20240130014208.565554-1-hannes@cmpxchg.org> <20240130014208.565554-2-hannes@cmpxchg.org> From: Chengming Zhou In-Reply-To: <20240130014208.565554-2-hannes@cmpxchg.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 269F7C001A X-Rspam-User: X-Stat-Signature: xhhmsnr7n3qrniqwfzrzhryzmbumkrw8 X-Rspamd-Server: rspam03 X-HE-Tag: 1706585801-169672 X-HE-Meta: U2FsdGVkX1+beu73y3AHgsEuh0d2V6hcegX5IUzukKpaKA3C0SzXCr3jz5n5c5Av1dLpC65AhXGsyhYgeQUCvo7iH9a06CiEFPRFkIKJmMXvlfPEDFAIZxAjyM9Y9FwlfTZxEANxrfKu1HRoKjFkxpix7aE1y3eHiAf895EBHtjoNk3Lyl5S8YJ4/+kWYv6yyZfr1LKxu+zdeVzMWTyDlKfUAFHF1s6+IZ5bfhucZE1InammoPQR4wJCts7gvC/NYbr46qVmuKV8sydb4MboB9LkVYgglH+GRE/UiKgUgjgCi21LJjnhf4XFcpkTO96Ooi2qN5WNa/BpsoDP/KTxQRVabnl6NxC4UutRtyMJ2bmoX3FeLOSzuhjRDE102NtOH1iJKHda84nQ4jQq9jyRESKB2+Yw5IeUgnO2q2uUdp/3GkNFah1zkJLSHUeRXu+F42ietkVF6UFicPNdTKp8dlH4HObAiKu7V1R2B7VNm+hlqLFDsnHb+hwgD0iWDBL7vlW9hCzzt34uamdmCweOMu9Zxn5pGdPCfPBLTiIBFoUjF8reSzOhnzIROiyLsl9PVJcEeJEjgnF4R91+cVEcjMl7BCdLYoUCKkYHc0Y7DGE4hn6xIVnvc/Ek/N4Y2A4kwKzriRmxMLPrO5P7HaYBGB/qAK/z7l/V6NFun0YfJWcSNsnhNKXAjRy/C93DlJodaPH7lZnC9fiMd4fnEGpSTS1uwm4zSnIZ8iwlUvXXZuAMfnQRExrm05/6FiwEpC/Psmwe6Dndfy5kEneFbGupR0/O0OdK1nlBYf0ZDG9MPO12Ubvk/jTxU8Icy6lnPfsIMwASqqEV0iJxQ93wDi9pJwtBlcBQ8trK9DRNK5SWrkhuZnmWLBcMy+xT5uHeJky0leltuMNi0B8IGGT5JMKl4+K94Rr4L3dWWC7PhSPjfXsOjymSb8Q8P4VTn02Cl/0EryURVCo1Ucb/FwhegMo jJGPH/GG xNFkV+jTOJT4zrJaclPiv1Vk+lFCLxnCSAmadS9qgHDWM4QwG9FeGcAtSP4mXT7+42iGez+gfzx+nKTqrOopgBYQM/S7Yw68x2mNb04CsSsx/3WxTgFsBCMcXStDll8sji6ivRVHWOxcWj+klJeHISXiu3ZkGrJTK8hO9uXYaqMGbI5tCowF1nEdlCavLkwTYW+j2Mqpaju/FyW1cTxGm6lSon0/dSiPTpBnBu//KYZPDF/Y5uwa8rsbl73qmsA5h7fNtWZmOviLnotQsS+nwKw1mW8ynhkV4IEeykhgeOAfN2PgA06qXdixknfLlPjyeoGM+gMHzLsvULL7IzowAg6jFQch4CZj+Wa7XBOiIUHhYjSxIO61HQpDj6CVtnfyZog7GOxSbhhyn15JLWpW2BPfeVlImXnP6QnJDiWrU8UXeRvHQvsfKqEMa4ysd+LDT7F5jv03LILrIavasbsOwrMGsNrSA8TCOoBDXQHXMN5dx5eAe1c2s10Mlu3GRXVToMDaA6DZ3SS4dMw6nUR8QPEdveSIPIq2AeKaHUelj6M1mw0OalOSPtOrWbZfV9y3h+vnu X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/1/30 09:36, Johannes Weiner wrote: > There is a zswap_entry_ namespace with multiple functions already. > > Signed-off-by: Johannes Weiner Reviewed-by: Chengming Zhou > --- > mm/zswap.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/zswap.c b/mm/zswap.c > index 7f88b3a77e4a..173f2e6657de 100644 > --- a/mm/zswap.c > +++ b/mm/zswap.c > @@ -520,7 +520,7 @@ static struct zpool *zswap_find_zpool(struct zswap_entry *entry) > * Carries out the common pattern of freeing and entry's zpool allocation, > * freeing the entry itself, and decrementing the number of stored pages. > */ > -static void zswap_free_entry(struct zswap_entry *entry) > +static void zswap_entry_free(struct zswap_entry *entry) > { > if (!entry->length) > atomic_dec(&zswap_same_filled_pages); > @@ -555,7 +555,7 @@ static void zswap_entry_put(struct zswap_entry *entry) > WARN_ON_ONCE(refcount < 0); > if (refcount == 0) { > WARN_ON_ONCE(!RB_EMPTY_NODE(&entry->rbnode)); > - zswap_free_entry(entry); > + zswap_entry_free(entry); > } > } >