From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1AD3C001CC for ; Thu, 11 Apr 2024 15:00:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 204C26B0082; Thu, 11 Apr 2024 11:00:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 18F216B0083; Thu, 11 Apr 2024 11:00:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F22F26B0085; Thu, 11 Apr 2024 11:00:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id D4C676B0082 for ; Thu, 11 Apr 2024 11:00:30 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 87172120A98 for ; Thu, 11 Apr 2024 15:00:30 +0000 (UTC) X-FDA: 81997562220.25.188248B Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf17.hostedemail.com (Postfix) with ESMTP id 2F1084000F for ; Thu, 11 Apr 2024 15:00:27 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=cI0mTFyI; spf=pass (imf17.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712847628; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Sq04QCIHSO2/rjx13aYOGeEQxe2Gyi/wBqeQq9TfDNg=; b=pry+RPzCEjWzHLVh4BY6m21srGo1u1RW6NwBS/8ikVFr8sKxE9lmU5mDWKeMxEFI61IRZe aWblJJi3unAMu9tBK24sVsi+1t6YYz+SCXfp/YgfB+kUgAaA8EJFOgrxZTUNLf8xE44RuJ qLJiv08JSxhdJDg8ypXoJBTTEUqEpXA= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=cI0mTFyI; spf=pass (imf17.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712847628; a=rsa-sha256; cv=none; b=G/iJHr/9Incpjuy9do3rymEp5y9E/nRvSV9ulUHmR/npubOgyJJwOysxW+NaqWvVKl2Twf mI98wkIOuaFsAwOp5b60t5ZUO54aORBvHS9GEqSMjQW1QRvHz304OV9NsREd8SRGl7FHhw o4uET41lcu6+3Xt+bC8+PJzvDo66b58= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712847627; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Sq04QCIHSO2/rjx13aYOGeEQxe2Gyi/wBqeQq9TfDNg=; b=cI0mTFyIUjP0LZyR3sWuFd2gL4DEjF+vtQ515ua/Ey9vEYuGjrhypGk72T81JRA+PALQPf KscUO38wtVJx+TUF0VVKSFyHzCh8CiubjkeuUKBcn+qp2EJl2ZjzEvFjKzxg0xEeiEuTFq gaGNxHd2XbZPo9i+fI27N/Ju2/IW9Ew= Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-661-zy1mnBqiP4mvV_tkOiXPVA-1; Thu, 11 Apr 2024 11:00:25 -0400 X-MC-Unique: zy1mnBqiP4mvV_tkOiXPVA-1 Received: by mail-lf1-f71.google.com with SMTP id 2adb3069b0e04-516ddd6d66fso4521533e87.1 for ; Thu, 11 Apr 2024 08:00:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712847624; x=1713452424; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=Sq04QCIHSO2/rjx13aYOGeEQxe2Gyi/wBqeQq9TfDNg=; b=mNt1/gxHW86DrraOiSLlJL20xq4obgclGGe7tQWY8FXvhbdqx5DcadE0Bq1nH9cxHD oN0/VzW0UX7JJQBD0RrHwmkr8QGlCEqL0ejwyHpoS7bdCBWLRrmjxZlcA4Zsgu0AnCra TsIdlF5GXFMlbdWfw/bF/v8Jd+7+jOEMAjMSEsb7yyA4MB/2U5LGrxLHtjsl7NZSW+AI Q7yGM9avaJwkWQx2CUwRfIcO+feGsbwYXWzZX88T9xGpWCWiBtI0nbSfsI/04Ff0Vemm YXC9Mpwe2NSOMEI+XJsTR4S3A7MMx/oEtBBNNMG9z2cHmfV+fC+rVP8/OZ8ZzhYTHBWj q+9Q== X-Forwarded-Encrypted: i=1; AJvYcCUaaPHYnUYjH+fhJ/FkjIwXH3hcAqkQfizf7Fl+FM/FMwmw0/lZgZ83qS9Wv1/vJB9Zx0TYhC6bZZKLhSDGmJEb0mw= X-Gm-Message-State: AOJu0YxR4lPo6cy8irOPLA9dHoB1QCWHKhQ66Bh+BMF9mPpNGmo2JJLJ mpM4XrNJXO13XsFKdNiC/3IUDlJ5mw+lKQ9Ne9IUc+NmDrxfULswQVPsyJ95UwdyOwoYEEfpJet FnWcFY3fidYE9BP+LDeESykF9GPbhpznHr34xqZMQ2CKf0m6G X-Received: by 2002:a05:6512:ad0:b0:518:6d46:a39e with SMTP id n16-20020a0565120ad000b005186d46a39emr1048023lfu.42.1712847624261; Thu, 11 Apr 2024 08:00:24 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHnvf09190Wa6fQ8E3ycep+zG/BHglEbtRd1UZD5VmxzDozsM+O/c0H8xHubfEfCUC4vdiPSQ== X-Received: by 2002:a05:6512:ad0:b0:518:6d46:a39e with SMTP id n16-20020a0565120ad000b005186d46a39emr1047978lfu.42.1712847623722; Thu, 11 Apr 2024 08:00:23 -0700 (PDT) Received: from ?IPV6:2003:cb:c724:4300:430f:1c83:1abc:1d66? (p200300cbc7244300430f1c831abc1d66.dip0.t-ipconnect.de. [2003:cb:c724:4300:430f:1c83:1abc:1d66]) by smtp.gmail.com with ESMTPSA id g2-20020adff3c2000000b00343300a4eb8sm1972637wrp.49.2024.04.11.08.00.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Apr 2024 08:00:23 -0700 (PDT) Message-ID: Date: Thu, 11 Apr 2024 17:00:21 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/5] mm: swap_pte_batch: add an output argument to reture if all swap entries are exclusive To: Ryan Roberts , Barry Song <21cnbao@gmail.com>, akpm@linux-foundation.org, linux-mm@kvack.org Cc: baolin.wang@linux.alibaba.com, chrisl@kernel.org, hanchuanhua@oppo.com, hannes@cmpxchg.org, hughd@google.com, kasong@tencent.com, surenb@google.com, v-songbaohua@oppo.com, willy@infradead.org, xiang@kernel.org, ying.huang@intel.com, yosryahmed@google.com, yuzhao@google.com, ziy@nvidia.com, linux-kernel@vger.kernel.org References: <20240409082631.187483-1-21cnbao@gmail.com> <20240409082631.187483-4-21cnbao@gmail.com> <744f795b-7ce8-40ab-911b-60906aa4fed1@arm.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <744f795b-7ce8-40ab-911b-60906aa4fed1@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 2F1084000F X-Rspam-User: X-Stat-Signature: e66x4fwp4y3yrhd7afognt5ad3ozrtjh X-Rspamd-Server: rspam01 X-HE-Tag: 1712847627-859114 X-HE-Meta: U2FsdGVkX18paOLvfqciLx/3+r93hXMeMSHWItSF8ZvG9VTnLnlNK/FY4wIc4y/bFQO/0AeHF4Ev7zi354rDwWxRCROualpApwkrfJEU/ZFhiTF97ObHL96/+Hpqg36btC6aY76sPQB+pRTphroO07KhkpSSb1EYUlMZOlGHVlA/mQlF+lsnNLDaU7xiYkxTRn+FJXlvQGJrPmLprfRtTY2t0KPYjgL0G7wcBLE5UmiJ6ffZIZtedJc+NNOgL9gCrHBM/WKX54ypXU2QGgZFuGnDMpnJUPm5A1d4oGBwndkmZJDTgdKOlFTSGTev33WeBW8G4fAYlQU5tcOIv9gEE0bScb2q+DPyDhTXvvhhKQq46fWDgCnGhpZ4cZT/9zdJ+CwGTZ4lG1IvOJC1mazHh+N72ll1wOpuNjIPoVDs5AE5yqG77eucFkiGgc+I8/JqrPFnC8bztBj/YhStlm/q6MSg3yNTwcttwgCX0QpIhhWeVIF/WysxVyVGbRqDrLXZhEGcxbDjwSOLmPxdrg9MYCkaRvbKiJRp0s6yy7IJT6UbnooFQlgY9tUxYe7NvOX2/lN7FHuHzxyi5x6x4K0nZ6eCO16QX+x5MfZ6ILvsUX7OztWfuX6XasMle2sHBWlcuvWlg092/Y5GT9/bP6AFQsvMMfRwlAowYis8fcbounU77yM+DvBVT2Rz5KwtLuS4l0J36pzBdqct5BDVNp3vEMnPU6JMpkHEUpyI0+Ke69sRHnKXLnFKYCOzDcQI5t9G/xiDkgS60wjEGRj9PUO6xdPNCjbmek2U+Fft4VOcm1xgX9d3xvyUyX414Yk9M8lFjF5AZaZ72ylvQ1sZgo9mD5hq3wME6FD1e/uq6gTllj6+//RepVtmlsxv73CMv2EYRPGa5o8M+podDGHmm3X1Edr6GLwu1NDB6+45sIhxzmDynn13yZjT0Jlz19kVK2nNGFbrfxB8ewxRuSvIRV1 ruX9JRkU NK4cSWo6J20QU2E+OEX49ITFMMKb+lYhy22d2+1G1vp9S7Na2xzAj1cl/AuQ0kRtR/uJavSh3XxaOb0zPIVX7SfsdlWDLOCAh1BjFn6nfz4pk9vO3i0PBjXs8iQLuqiBxQMfR3bOltVVyD02SnORKQ0GvrERGss1jAp6OmcqC9Fe64Cbb0ButoA9c5Z8aPY4Uqg41+HbjAOqKVoGStdCl1b3WGFQibuWSmSnuaaoZMdhlT9dnzxAxt964vELk2q8LwZqQG+fSup6aznW6FmRTOV0X4wbITDaVXhESJBSgO5J5puif2VyBWEGcC4Z0UNS69A42NrJEgZXDSkvJocd1Uz4vo353PxM0vg4y8419atXF07TX1DIQd9PmhT/MhSxgPdLG5f6esySo67WikBTc/rIEHMgDqNnjaPlzbueWviyqkMJ3LQA33131LcLanV0j/HqhXqWkSdtyRKwDVvDtGHITv77bsqCsjj4+0vnt2+6t0g1+SU53fb4VRKXZXrMM0KDcA+3Iy3KqQIgoIoXQfdA3bQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 11.04.24 16:54, Ryan Roberts wrote: > On 09/04/2024 09:26, Barry Song wrote: >> From: Barry Song >> >> Add a boolean argument named any_shared. If any of the swap entries are >> non-exclusive, set any_shared to true. The function do_swap_page() can >> then utilize this information to determine whether the entire large >> folio can be reused. >> >> Signed-off-by: Barry Song >> --- >> mm/internal.h | 9 ++++++++- >> mm/madvise.c | 2 +- >> mm/memory.c | 2 +- >> 3 files changed, 10 insertions(+), 3 deletions(-) >> >> diff --git a/mm/internal.h b/mm/internal.h >> index 9d3250b4a08a..cae39c372bfc 100644 >> --- a/mm/internal.h >> +++ b/mm/internal.h >> @@ -238,7 +238,8 @@ static inline pte_t pte_next_swp_offset(pte_t pte) >> * >> * Return: the number of table entries in the batch. >> */ >> -static inline int swap_pte_batch(pte_t *start_ptep, int max_nr, pte_t pte) >> +static inline int swap_pte_batch(pte_t *start_ptep, int max_nr, pte_t pte, >> + bool *any_shared) > > Please update the docs in the comment above this for the new param; follow > folio_pte_batch()'s docs as a template. > >> { >> pte_t expected_pte = pte_next_swp_offset(pte); >> const pte_t *end_ptep = start_ptep + max_nr; >> @@ -248,12 +249,18 @@ static inline int swap_pte_batch(pte_t *start_ptep, int max_nr, pte_t pte) >> VM_WARN_ON(!is_swap_pte(pte)); >> VM_WARN_ON(non_swap_entry(pte_to_swp_entry(pte))); >> >> + if (any_shared) >> + *any_shared |= !pte_swp_exclusive(pte); > > This is different from the approach in folio_pte_batch(). It inits *any_shared > to false and does NOT include the value of the first pte. I think that's odd, > personally and I prefer your approach. I'm not sure if there was a good reason > that David chose the other approach? Because in my case calling code does nr = folio_pte_batch(folio, addr, src_pte, pte, max_nr, flags, &any_writable); ... if (any_writable) pte = pte_mkwrite(pte, src_vma); ... and later checks in another function pte_write(). So if the common pattern is that the original PTE will be used for checks, then it doesn't make sense to unnecessary checks+setting for the first PTE. -- Cheers, David / dhildenb