linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Miaohe Lin <linmiaohe@huawei.com>
To: Mike Kravetz <mike.kravetz@oracle.com>, <akpm@linux-foundation.org>
Cc: <linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm/hugetlb: Remove redundant VM_BUG_ON_PAGE on putback_active_hugepage()
Date: Tue, 9 Feb 2021 10:10:00 +0800	[thread overview]
Message-ID: <a5a09912-72ab-f494-0f29-5e3b7fb7c5a4@huawei.com> (raw)
In-Reply-To: <7e1cdef7-e3cd-79c1-c30c-5f5e9e9f85ac@oracle.com>

Hi:
On 2021/2/9 9:26, Mike Kravetz wrote:
> On 2/8/21 12:37 AM, Miaohe Lin wrote:
>> PageHead(page) is implicitly checked in set_page_huge_active() via the
>> PageHeadHuge(page) check. So remove this explicit one.
> 
> I do not disagree with the code change.  However, this commit message
> is not accurate.  set_page_huge_active() no longer exists in the tree
> you are changing.  It was replaced with SetHPageMigratable.  Also, the
> VM_BUG_ON_PAGE(!PageHeadHuge(page), page) was removed in the process.
> So, there is no redundant check.
> 
> However, a quick audit of calling code reveals that all callers know they
> are operating on a hugetlb head page.
> 

So I should change the commit log like:

	All callers know they are operating on a hugetlb head page. So this VM_BUG_ON_PAGE
	can't catch anything useful.

and send a v2. Right?


  reply	other threads:[~2021-02-09  2:10 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-08  8:37 Miaohe Lin
2021-02-09  1:26 ` Mike Kravetz
2021-02-09  2:10   ` Miaohe Lin [this message]
2021-02-09  3:39     ` Mike Kravetz
2021-02-09  6:19       ` Miaohe Lin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a5a09912-72ab-f494-0f29-5e3b7fb7c5a4@huawei.com \
    --to=linmiaohe@huawei.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mike.kravetz@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox