From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EDA1AC47258 for ; Tue, 16 Jan 2024 23:38:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 615816B0078; Tue, 16 Jan 2024 18:38:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 59E466B0085; Tue, 16 Jan 2024 18:38:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 441086B0089; Tue, 16 Jan 2024 18:38:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 29C5F6B0078 for ; Tue, 16 Jan 2024 18:38:54 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 024AFA20CA for ; Tue, 16 Jan 2024 23:38:53 +0000 (UTC) X-FDA: 81686791788.20.0FFAA4F Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) by imf19.hostedemail.com (Postfix) with ESMTP id 0789C1A0004 for ; Tue, 16 Jan 2024 23:38:51 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=GqMTrQuZ; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf19.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.128.47 as permitted sender) smtp.mailfrom=lstoakes@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705448332; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BxQ/BWYR+PjxzLrNnVyzasE/2yl2t/5YvcquSYRLHa4=; b=otp7JRONf/EFyGRSptWoDXZt0QjoeTUBP1Ly+UHcxYq9helO7dbvSK6eyrggRidcbusGRD s7s+bQtwwvvg1s+L3su0B7+aTChAUpRitcQNOTpLx8s5b5174n2l4sAqB19tI6BMd9PdjU +BI+Ns8m8CyPhjgrvTAAi72d5M3aPKw= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=GqMTrQuZ; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf19.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.128.47 as permitted sender) smtp.mailfrom=lstoakes@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705448332; a=rsa-sha256; cv=none; b=hpnFEdRhaAdyZ6fv9cp/T025YaBM5ikL3EkKpfJBl3hE7p8rd0y56j/tqUdIaMnh1JZId5 FD+q9HB+oZGYdaguAcYZDQjEq+jcNMUp7oSybJF8nO5lSNLov+UNXhwAyiGX9CS9BupuKM mFe91ZUMvdmB/mTr+mAEVpP8hSEYtGU= Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-40e879cf632so4649965e9.1 for ; Tue, 16 Jan 2024 15:38:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1705448330; x=1706053130; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=BxQ/BWYR+PjxzLrNnVyzasE/2yl2t/5YvcquSYRLHa4=; b=GqMTrQuZw9atDq1Nlyo2SBtMg1E05tnUshB2Kp9PKOyDV8TLR5/1Ble+4E+2DWyM2D cdTc6OVpjnVPtdsAQOuJkpKp38Y5kTDRAQNqUKSU0ejVvaXEdwLizdOt6PdrCecFL1GK jSZ+xv5lLu8bMtM0TY8lvCJfPxbsR+2eXX37+L65AOnv72WZP9MnGr+hmDOQywzI9X67 PR63Rl38bNEFRnvB5VJKBFoXvDs7L0XFV3+gDwzVko3C1CPXwBB73XLvQsFGhPcCgmCv PG7AXJbNxPsiblZzGi8XOmnse8JSThdQxCGXnd96iaOS/fuDRislGAXcqWkMiT2ZUFEc EkOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705448330; x=1706053130; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=BxQ/BWYR+PjxzLrNnVyzasE/2yl2t/5YvcquSYRLHa4=; b=m6hyf+9MPMumrFvDKpCttHZjp9XMk8eVvykoDvPl+Dg3dJ0E9r55aSpmsUWbzdu2Le nZI2d2+r562gpUSiItcFcFWQFarFuTzUXz61oO7wUTSyZcr7Vq115DjTIcsF8nUrTF/g 37y9zJFviqB6WH3qWDhK+PA/FkfmcN273hulxgQ5YWZ54+H3uSbPQudNn17/3K9T86uj fqNEildVBaBskbnM807AniWdoNPWub/1xHI1jKwmxn6fnKmxlfmkGrYrFYNPxsFms3FQ kIN0KbPRh0xvyjty/bgNP1O0iMRE9mhvroRCnjGtNv11MEFbPoP8tJo8mKTs0Ax1kElc wDEw== X-Gm-Message-State: AOJu0YzpLfyNXi0XJr8+S1aXTjiVMJ+NFrBJYLYTkoxU/P2J223tWqQ6 CbZJQu8N2YnxA+UD1lrZI7oxG69/T9A= X-Google-Smtp-Source: AGHT+IEjCsioEZdDVJlyKy7MIaIRPNF+lvtLUa1ogCBD9vDCKU+cVFFygcJqpJOV53yY86Wy//8LpA== X-Received: by 2002:a7b:cd82:0:b0:40e:6930:4c99 with SMTP id y2-20020a7bcd82000000b0040e69304c99mr1719322wmj.113.1705448330318; Tue, 16 Jan 2024 15:38:50 -0800 (PST) Received: from localhost (host86-162-136-255.range86-162.btcentralplus.com. [86.162.136.255]) by smtp.gmail.com with ESMTPSA id o31-20020a05600c511f00b0040e703ad630sm11812802wms.22.2024.01.16.15.38.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Jan 2024 15:38:49 -0800 (PST) Date: Tue, 16 Jan 2024 23:36:35 +0000 From: Lorenzo Stoakes To: "Uladzislau Rezki (Sony)" Cc: linux-mm@kvack.org, Andrew Morton , LKML , Baoquan He , Christoph Hellwig , Matthew Wilcox , "Liam R . Howlett" , Dave Chinner , "Paul E . McKenney" , Joel Fernandes , Oleksiy Avramchenko Subject: Re: [PATCH v3 05/11] mm/vmalloc: remove vmap_area_list Message-ID: References: <20240102184633.748113-1-urezki@gmail.com> <20240102184633.748113-6-urezki@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240102184633.748113-6-urezki@gmail.com> X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 0789C1A0004 X-Stat-Signature: p9wneu6cewttk7hy7y6dkgza496i8bae X-HE-Tag: 1705448331-720522 X-HE-Meta: U2FsdGVkX18f3ULrY1rywb79W6H/c5nrQxvAJaTwgYR4J8stdkDcuaEWeWdi9IQ3jVcBDPz+wKyTZbLH3OHdfCfteUqQa7dfO23voHNs2ClJPQkDtvx6vEXrr4nHHKwT0W/xDdi+RvR3HI/eRuD063fG3D2VPOSDHesc/i7tHk7wIrvsoVDjs2AivdODp6z7IWRjh7C5DxrNELOuUSHcHHA0YNQr/XjqloU4XiyMSlXiLki1oAzVN/kH45npknknmjuG9Ea0TO3noEPldAwh7N0zG8+bq/5GwrtUQY/YCnW4ERQwpT5cQwZUTcDLAE1wLv12jb88vuPY/oKqL4UydqhufnJGyDOT38yF5F0k51wgNx83g+11Y+C4AfAol5TpVlBc9UhcB4iX2BtQyCc6xai+APDsdZllPgGKw5Je+/ykO/qIO1m+ERpdpV7y8EjXXFHTVMDmUUGrfxT4V+JdsH9IchnNUidMCUhPnLxWP+lDV++OXToy312d4b25hmuGm4KrMm17k8vyOfO8tLhhFKyp0kooL3y8rA1Mi7LOZxznz/4sspkPEtuAEHhev7fleOJAOcKYmTFMJkuXJjKwQHD15Bo0kRzigSWhFYltHy/yYXgVBWsXwdBbmZ0bG0RfyPlKcis4TcCCU+vxmP+uwvcP0w30P0Wlsf8lXi8/VlsCSbP1JSrXpwpTbZCTTQImxuoGxFnF8sILDiZA50wM26MrezWYjWFwe8Kwt8JG5OIayyzm+o6pT7csIPuhgBPxMmYh5v2BI4/kJfB9KdCf/flbgIS6o/KKqoQwmaE11ZjgaFkHI941n2fsAa6zgoRGUvS7DeYqQqwOJFkcNBS3ZWBa/FE18fhUo4h0+DMaHBEQK09tm0FwHQlCgcLoCUfBHUBefiZSMH9EGm67ll2bcQCZjZ3mjvlj2Nz+pSvhZQOdyLlkiHDzYHWJvojeeh89FV0Pnm0DomZddGE+kzO hojybw5k nnwGSOVuH4P5bV6gsHoaMlExpFO9CHNq4A907V1GLSLPzFkcAgKyxZu4BYjEalTjbIq77FnKU2ejKmOYWQea554h2pYzXMrh98+S/goySpvmdaSm1PZMEBLT+4w2QFGAXSZ+vv59kPyh0J3wKYG4Y/CTSChir1Zy54qDaRgCU21FTH/yX3yvNurPdinris0G937yeMzOlFD0Gx8gXH0OmH+/NLPXwZx3XS3PNMtKpnnxN13YCb6IYdSNxlP7xWBCw1R8vR5ET/klu7opsVO31KkTs8V93oe6a6s539WVMxDWRqjmAHIbwj3+TXGBhwQRZmfVOW7bzOmUIHthHzeyXQJqRnwSciSPdOCoP6Jfh7H7QevHCpA0OhgiruhfxFDMHoDrkfUBcH5V8Z+0AGx3egJwSlrSKaYpPVU+ubwLT9DeS9bqzseyBNNdORvv1cTH2SSCobSn7Ox6bPwUEF8vPXIgmWh5G5CiL6+79BdSUs9HThQ0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jan 02, 2024 at 07:46:27PM +0100, Uladzislau Rezki (Sony) wrote: > From: Baoquan He > > Earlier, vmap_area_list is exported to vmcoreinfo so that makedumpfile > get the base address of vmalloc area. Now, vmap_area_list is empty, so > export VMALLOC_START to vmcoreinfo instead, and remove vmap_area_list. > > Signed-off-by: Baoquan He > Signed-off-by: Uladzislau Rezki (Sony) > --- > Documentation/admin-guide/kdump/vmcoreinfo.rst | 8 ++++---- > arch/arm64/kernel/crash_core.c | 1 - > arch/riscv/kernel/crash_core.c | 1 - > include/linux/vmalloc.h | 1 - > kernel/crash_core.c | 4 +--- > kernel/kallsyms_selftest.c | 1 - > mm/nommu.c | 2 -- > mm/vmalloc.c | 2 -- > 8 files changed, 5 insertions(+), 15 deletions(-) > > diff --git a/Documentation/admin-guide/kdump/vmcoreinfo.rst b/Documentation/admin-guide/kdump/vmcoreinfo.rst > index 78e4d2e7ba14..df54fbeaaa16 100644 > --- a/Documentation/admin-guide/kdump/vmcoreinfo.rst > +++ b/Documentation/admin-guide/kdump/vmcoreinfo.rst > @@ -65,11 +65,11 @@ Defines the beginning of the text section. In general, _stext indicates > the kernel start address. Used to convert a virtual address from the > direct kernel map to a physical address. > > -vmap_area_list > --------------- > +VMALLOC_START > +------------- > > -Stores the virtual area list. makedumpfile gets the vmalloc start value > -from this variable and its value is necessary for vmalloc translation. > +Stores the base address of vmalloc area. makedumpfile gets this value > +since is necessary for vmalloc translation. > > mem_map > ------- > diff --git a/arch/arm64/kernel/crash_core.c b/arch/arm64/kernel/crash_core.c > index 66cde752cd74..2a24199a9b81 100644 > --- a/arch/arm64/kernel/crash_core.c > +++ b/arch/arm64/kernel/crash_core.c > @@ -23,7 +23,6 @@ void arch_crash_save_vmcoreinfo(void) > /* Please note VMCOREINFO_NUMBER() uses "%d", not "%x" */ > vmcoreinfo_append_str("NUMBER(MODULES_VADDR)=0x%lx\n", MODULES_VADDR); > vmcoreinfo_append_str("NUMBER(MODULES_END)=0x%lx\n", MODULES_END); > - vmcoreinfo_append_str("NUMBER(VMALLOC_START)=0x%lx\n", VMALLOC_START); > vmcoreinfo_append_str("NUMBER(VMALLOC_END)=0x%lx\n", VMALLOC_END); > vmcoreinfo_append_str("NUMBER(VMEMMAP_START)=0x%lx\n", VMEMMAP_START); > vmcoreinfo_append_str("NUMBER(VMEMMAP_END)=0x%lx\n", VMEMMAP_END); > diff --git a/arch/riscv/kernel/crash_core.c b/arch/riscv/kernel/crash_core.c > index 8706736fd4e2..d18d529fd9b9 100644 > --- a/arch/riscv/kernel/crash_core.c > +++ b/arch/riscv/kernel/crash_core.c > @@ -8,7 +8,6 @@ void arch_crash_save_vmcoreinfo(void) > VMCOREINFO_NUMBER(phys_ram_base); > > vmcoreinfo_append_str("NUMBER(PAGE_OFFSET)=0x%lx\n", PAGE_OFFSET); > - vmcoreinfo_append_str("NUMBER(VMALLOC_START)=0x%lx\n", VMALLOC_START); > vmcoreinfo_append_str("NUMBER(VMALLOC_END)=0x%lx\n", VMALLOC_END); > #ifdef CONFIG_MMU > VMCOREINFO_NUMBER(VA_BITS); > diff --git a/include/linux/vmalloc.h b/include/linux/vmalloc.h > index c720be70c8dd..91810b4e9510 100644 > --- a/include/linux/vmalloc.h > +++ b/include/linux/vmalloc.h > @@ -253,7 +253,6 @@ extern long vread_iter(struct iov_iter *iter, const char *addr, size_t count); > /* > * Internals. Don't use.. > */ > -extern struct list_head vmap_area_list; > extern __init void vm_area_add_early(struct vm_struct *vm); > extern __init void vm_area_register_early(struct vm_struct *vm, size_t align); > > diff --git a/kernel/crash_core.c b/kernel/crash_core.c > index d4313b53837e..b427f4a3b156 100644 > --- a/kernel/crash_core.c > +++ b/kernel/crash_core.c > @@ -759,7 +759,7 @@ static int __init crash_save_vmcoreinfo_init(void) > VMCOREINFO_SYMBOL_ARRAY(swapper_pg_dir); > #endif > VMCOREINFO_SYMBOL(_stext); > - VMCOREINFO_SYMBOL(vmap_area_list); > + vmcoreinfo_append_str("NUMBER(VMALLOC_START)=0x%lx\n", VMALLOC_START); > > #ifndef CONFIG_NUMA > VMCOREINFO_SYMBOL(mem_map); > @@ -800,8 +800,6 @@ static int __init crash_save_vmcoreinfo_init(void) > VMCOREINFO_OFFSET(free_area, free_list); > VMCOREINFO_OFFSET(list_head, next); > VMCOREINFO_OFFSET(list_head, prev); > - VMCOREINFO_OFFSET(vmap_area, va_start); > - VMCOREINFO_OFFSET(vmap_area, list); > VMCOREINFO_LENGTH(zone.free_area, MAX_ORDER + 1); > log_buf_vmcoreinfo_setup(); > VMCOREINFO_LENGTH(free_area.free_list, MIGRATE_TYPES); > diff --git a/kernel/kallsyms_selftest.c b/kernel/kallsyms_selftest.c > index b4cac76ea5e9..8a689b4ff4f9 100644 > --- a/kernel/kallsyms_selftest.c > +++ b/kernel/kallsyms_selftest.c > @@ -89,7 +89,6 @@ static struct test_item test_items[] = { > ITEM_DATA(kallsyms_test_var_data_static), > ITEM_DATA(kallsyms_test_var_bss), > ITEM_DATA(kallsyms_test_var_data), > - ITEM_DATA(vmap_area_list), > #endif > }; > > diff --git a/mm/nommu.c b/mm/nommu.c > index b6dc558d3144..5ec8f44e7ce9 100644 > --- a/mm/nommu.c > +++ b/mm/nommu.c > @@ -131,8 +131,6 @@ int follow_pfn(struct vm_area_struct *vma, unsigned long address, > } > EXPORT_SYMBOL(follow_pfn); > > -LIST_HEAD(vmap_area_list); > - > void vfree(const void *addr) > { > kfree(addr); > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index 786ecb18ae22..8c01f2225ef7 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -729,8 +729,6 @@ EXPORT_SYMBOL(vmalloc_to_pfn); > > > static DEFINE_SPINLOCK(free_vmap_area_lock); > -/* Export for kexec only */ > -LIST_HEAD(vmap_area_list); > static bool vmap_initialized __read_mostly; > > static struct rb_root purge_vmap_area_root = RB_ROOT; > -- > 2.39.2 > Looks good to me, I'm not _hugely_ familiar with this crash core stuff so: Acked-by: Lorenzo Stoakes