From: Vladimir Murzin <vladimir.murzin@arm.com>
To: Anshuman Khandual <anshuman.khandual@arm.com>, linux-mm@kvack.org
Cc: Chris Zankel <chris@zankel.net>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Michael Ellerman <mpe@ellerman.id.au>,
linux-xtensa@linux-xtensa.org, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org,
Russell King <linux@armlinux.org.uk>,
linux-mips@vger.kernel.org, Max Filippov <jcmvbkbc@gmail.com>,
Ingo Molnar <mingo@redhat.com>, Paul Mackerras <paulus@samba.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Thomas Gleixner <tglx@linutronix.de>,
Will Deacon <will@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] mm/memtest: Add ARCH_USE_MEMTEST
Date: Fri, 5 Feb 2021 09:20:07 +0000 [thread overview]
Message-ID: <a58f1a92-087d-cf90-ce2b-0c88b39a8116@arm.com> (raw)
In-Reply-To: <1612498242-31579-1-git-send-email-anshuman.khandual@arm.com>
Hi Anshuman,
On 2/5/21 4:10 AM, Anshuman Khandual wrote:
> early_memtest() does not get called from all architectures. Hence enabling
> CONFIG_MEMTEST and providing a valid memtest=[1..N] kernel command line
> option might not trigger the memory pattern tests as would be expected in
> normal circumstances. This situation is misleading.
Documentation already mentions which architectures support that:
memtest= [KNL,X86,ARM,PPC] Enable memtest
yet I admit that not all reflected there
>
> The change here prevents the above mentioned problem after introducing a
> new config option ARCH_USE_MEMTEST that should be subscribed on platforms
> that call early_memtest(), in order to enable the config CONFIG_MEMTEST.
> Conversely CONFIG_MEMTEST cannot be enabled on platforms where it would
> not be tested anyway.
>
Is that generic pattern? What about other cross arch parameters? Do they already
use similar subscription or they rely on documentation?
I'm not against the patch just want to check if things are consistent...
Cheers
Vladimir
next prev parent reply other threads:[~2021-02-05 9:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-05 4:10 Anshuman Khandual
2021-02-05 7:35 ` Max Filippov
2021-02-08 3:04 ` Anshuman Khandual
2021-02-05 9:20 ` Vladimir Murzin [this message]
2021-02-08 3:17 ` Anshuman Khandual
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a58f1a92-087d-cf90-ce2b-0c88b39a8116@arm.com \
--to=vladimir.murzin@arm.com \
--cc=anshuman.khandual@arm.com \
--cc=benh@kernel.crashing.org \
--cc=catalin.marinas@arm.com \
--cc=chris@zankel.net \
--cc=jcmvbkbc@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-xtensa@linux-xtensa.org \
--cc=linux@armlinux.org.uk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
--cc=tglx@linutronix.de \
--cc=tsbogend@alpha.franken.de \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox