From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D4FAC433F5 for ; Tue, 12 Apr 2022 16:39:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 88BD66B0072; Tue, 12 Apr 2022 12:39:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 83A7E6B0073; Tue, 12 Apr 2022 12:39:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6B4EF6B0074; Tue, 12 Apr 2022 12:39:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.a.hostedemail.com [64.99.140.24]) by kanga.kvack.org (Postfix) with ESMTP id 5C8BF6B0072 for ; Tue, 12 Apr 2022 12:39:14 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 2ED8B24083 for ; Tue, 12 Apr 2022 16:39:14 +0000 (UTC) X-FDA: 79348787028.14.FB22818 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf08.hostedemail.com (Postfix) with ESMTP id 51ACE160002 for ; Tue, 12 Apr 2022 16:39:13 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6399E1424; Tue, 12 Apr 2022 09:39:12 -0700 (PDT) Received: from [10.1.196.40] (e121345-lin.cambridge.arm.com [10.1.196.40]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 319403F5A1; Tue, 12 Apr 2022 09:39:10 -0700 (PDT) Message-ID: Date: Tue, 12 Apr 2022 17:39:04 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [RFC PATCH -next V3 6/6] arm64: add cow to machine check safe Content-Language: en-GB To: Tong Tiangen , Mark Rutland , James Morse , Andrew Morton , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , Catalin Marinas , Will Deacon , Alexander Viro , x86@kernel.org, "H . Peter Anvin" Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Kefeng Wang , Xie XiuQi References: <20220412072552.2526871-1-tongtiangen@huawei.com> <20220412072552.2526871-7-tongtiangen@huawei.com> From: Robin Murphy In-Reply-To: <20220412072552.2526871-7-tongtiangen@huawei.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 51ACE160002 X-Stat-Signature: cawijzs336pj6fhucisbbsucufbrd1sy X-Rspam-User: Authentication-Results: imf08.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf08.hostedemail.com: domain of robin.murphy@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=robin.murphy@arm.com X-HE-Tag: 1649781553-955226 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 12/04/2022 8:25 am, Tong Tiangen wrote: [...] > +100: ldp x2, x3, [x1] > +101: ldp x4, x5, [x1, #16] > +102: ldp x6, x7, [x1, #32] > +103: ldp x8, x9, [x1, #48] > +104: ldp x10, x11, [x1, #64] > +105: ldp x12, x13, [x1, #80] > +106: ldp x14, x15, [x1, #96] > +107: ldp x16, x17, [x1, #112] > + > + add x0, x0, #256 > + add x1, x1, #128 > +1: > + tst x0, #(PAGE_SIZE - 1) > + > +alternative_if ARM64_HAS_NO_HW_PREFETCH > + prfm pldl1strm, [x1, #384] > +alternative_else_nop_endif > + > + stnp x2, x3, [x0, #-256] > +200: ldp x2, x3, [x1] > + stnp x4, x5, [x0, #16 - 256] > +201: ldp x4, x5, [x1, #16] > + stnp x6, x7, [x0, #32 - 256] > +202: ldp x6, x7, [x1, #32] > + stnp x8, x9, [x0, #48 - 256] > +203: ldp x8, x9, [x1, #48] > + stnp x10, x11, [x0, #64 - 256] > +204: ldp x10, x11, [x1, #64] > + stnp x12, x13, [x0, #80 - 256] > +205: ldp x12, x13, [x1, #80] > + stnp x14, x15, [x0, #96 - 256] > +206: ldp x14, x15, [x1, #96] > + stnp x16, x17, [x0, #112 - 256] > +207: ldp x16, x17, [x1, #112] > + > + add x0, x0, #128 > + add x1, x1, #128 > + > + b.ne 1b > + > + stnp x2, x3, [x0, #-256] > + stnp x4, x5, [x0, #16 - 256] > + stnp x6, x7, [x0, #32 - 256] > + stnp x8, x9, [x0, #48 - 256] > + stnp x10, x11, [x0, #64 - 256] > + stnp x12, x13, [x0, #80 - 256] > + stnp x14, x15, [x0, #96 - 256] > + stnp x16, x17, [x0, #112 - 256] > + > +300: ret > + > +_asm_extable_copy_page_mc 100b, 300b > +_asm_extable_copy_page_mc 101b, 300b > +_asm_extable_copy_page_mc 102b, 300b > +_asm_extable_copy_page_mc 103b, 300b > +_asm_extable_copy_page_mc 104b, 300b > +_asm_extable_copy_page_mc 105b, 300b > +_asm_extable_copy_page_mc 106b, 300b > +_asm_extable_copy_page_mc 107b, 300b > +_asm_extable_copy_page_mc 200b, 300b > +_asm_extable_copy_page_mc 201b, 300b > +_asm_extable_copy_page_mc 202b, 300b > +_asm_extable_copy_page_mc 203b, 300b > +_asm_extable_copy_page_mc 204b, 300b > +_asm_extable_copy_page_mc 205b, 300b > +_asm_extable_copy_page_mc 206b, 300b > +_asm_extable_copy_page_mc 207b, 300b Please add a USER_MC() macro to parallel the existing USER() one (we can worry about names and eventually consolidating things later), then use that to save all the label mess here. Thanks, Robin.