From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E01AE7716A for ; Mon, 16 Dec 2024 00:01:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 25E906B007B; Sun, 15 Dec 2024 19:01:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 20D616B0082; Sun, 15 Dec 2024 19:01:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0D5936B0083; Sun, 15 Dec 2024 19:01:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id E16926B007B for ; Sun, 15 Dec 2024 19:01:11 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 66CE61642FD for ; Mon, 16 Dec 2024 00:01:11 +0000 (UTC) X-FDA: 82898865798.03.48190D9 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) by imf04.hostedemail.com (Postfix) with ESMTP id 6BFFF4000B for ; Mon, 16 Dec 2024 00:00:39 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=3oc2iHc7; spf=pass (imf04.hostedemail.com: domain of rientjes@google.com designates 209.85.214.177 as permitted sender) smtp.mailfrom=rientjes@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734307238; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CIixeN/LZEdYYSOUrwMdQ6JCRhKiZy+eBdF1XeYsSjo=; b=btqs8xfuJ0E/bjiFyJ3Do0XeSHoTbeXZ4fpBEMazYfs/DpCZ9vciPGRSbAVHTb6L6OvbRH TIjTk5OqyIwniWFIIZeFYCNE+x9H2l1PmXrRbs6wx8rKmWopCrnZXOg14jd/g6kkRdLwSh DAemSrXAV08UU69zsz66NlYP+i+O/cw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734307238; a=rsa-sha256; cv=none; b=vHXfhGNtAuRmj1/R2lYCj6arJnnsG6QfMf6IQ9dHmaqAfQdYMrkkr+Bg+NILSuOfE5/QT1 rMQV2ooQDCFPTYqUxq49W4qyoThqYI5QzNcbxG7Jv/RrdKo3O1fp6ITP1ihu3kfDifYk4X ILpNiLZRzYAmcZvqWOKcVY+/WulUqWo= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=3oc2iHc7; spf=pass (imf04.hostedemail.com: domain of rientjes@google.com designates 209.85.214.177 as permitted sender) smtp.mailfrom=rientjes@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-215740b7fb8so162785ad.0 for ; Sun, 15 Dec 2024 16:01:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1734307268; x=1734912068; darn=kvack.org; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to; bh=CIixeN/LZEdYYSOUrwMdQ6JCRhKiZy+eBdF1XeYsSjo=; b=3oc2iHc7R8/Ytjoj4qcSTaMqKlM/9UUyC3yZ5cPN/YcVl3VjfRPH/bxYXDELBF+E5t QyGyK/NLRXG/JylSiMMYCEoz40sZBqw7I7MDDF0KWQFJTcUNFWlPLQ2jXp4osD94fb8x EYLzZSHY+C3T1B27yXi5DQ3pGO0o6Thwoi5XU8wdhGbvGWthXuxK1w3hsnFADzoCZXj+ a3AQ0+M7faoL7fvoenW+u7HF4YY2CDCYvdcGRP1MZujFahgTfqjKqKStfObXvS9Eq6I0 fJwr+0g5r14gHkGvyMAPmxTLvEqNVNVpjZwsAMhgAETygjtYEvw8Xl9NYYVpcCueMjMK NgJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734307268; x=1734912068; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=CIixeN/LZEdYYSOUrwMdQ6JCRhKiZy+eBdF1XeYsSjo=; b=tncSokrj0H5JJYpvQjqeZxcObat0tQ+VeOFEXENpOuXKqcaqVGC+ikBU9234T6gUdG GJ8t+A8Ut7594VzG8f47yQ8CFIQw0ZC1SWKte2BONqkMMD6Bm1w+5e8IILTU08mhug9D /aNwxqimzPJi41stcApNZcjjOhqbaxyPOdOC3zuZ1o+co8OxmfAknAwRlhHD9K26Xw4c 0yX2mfSiDmlHMYzSD9GKVfBKrPQTqgFZBEvkBljg37DZQI4f6RxSjF7qaoakjpyJkE4n FS8kOygIX7+ZzrwnQRjtnXPLxYieixeT1SQ2amoDgQg+GCEPwsjbj5Nr4MYZ/otvYTou katA== X-Forwarded-Encrypted: i=1; AJvYcCWuEaaG64YjQMhLrHAkc6HxaC4C8CdqZnAdllMkxinF9pXgIiN/XbShdqilVy0LguD5nSkHRIdAGg==@kvack.org X-Gm-Message-State: AOJu0Yzgyo6DE9ODuOPt9JTnAoObLVu+p9V3pPHKcOVsURh1diWoxpF0 MMO/prlwWcVQ30hxphm5eBTLXZhaCI0MGcbN9nmfWXrU6R6uHwETpDbzI+ZFCg== X-Gm-Gg: ASbGncubJ6CFYjNGGYwFfeSGQEHPybLG+pxEBzVo2m/HgUyvbpBW1oXGS3eyLFBytno GHAN5CIAn0GlcxKCpC6hYBPg+d9h4vReJw2pQPknzj4e4aAVEJhZ5vqs3ilh0E5ljzfp9HASM5h tUeBhM0AJ85BVh2NtC1y+ujDs+PwgJWcN8ToKnFjvO30dWKn86krXVEhjZOSTMmWsVif+ihz2iG WcKAzRY/rsCgwVUZ1144LwyTnOsYckmrclr6NvGeU3KkoSh8h4/WECTnI+/IIh96JF8ktHgJE5G /ZYI3qkvnck= X-Google-Smtp-Source: AGHT+IGdatUnUSIEUTb9tfsJTvzGvOhTAc/ctWZ8k/qHbaOUD99i8eITQzUaExZkcdSofAsZ/nXWrQ== X-Received: by 2002:a17:903:1c7:b0:215:772c:fa82 with SMTP id d9443c01a7336-218a4443e7fmr2268785ad.3.1734307268012; Sun, 15 Dec 2024 16:01:08 -0800 (PST) Received: from [2620:0:1008:15:4b67:d338:6a48:b4bf] ([2620:0:1008:15:4b67:d338:6a48:b4bf]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72918b78f2bsm3583744b3a.104.2024.12.15.16.01.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 15 Dec 2024 16:01:07 -0800 (PST) Date: Sun, 15 Dec 2024 16:01:06 -0800 (PST) From: David Rientjes To: Hyeonggon Yoo <42.hyeyoo@gmail.com> cc: Vlastimil Babka , Matthew Wilcox , Andrew Morton , David Hildenbrand , Christoph Lameter , Pekka Enberg , Joonsoo Kim , Roman Gushchin , linux-mm@kvack.org Subject: Re: [PATCH v1 mm-unstable] mm/migrate: Remove slab checks in isolate_movable_page() In-Reply-To: <20241210124807.8584-1-42.hyeyoo@gmail.com> Message-ID: References: <20241210124807.8584-1-42.hyeyoo@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: 6BFFF4000B X-Rspam-User: X-Rspamd-Server: rspam07 X-Stat-Signature: um8biyanyty4zo5y5dgrrzkmuj5rmqqb X-HE-Tag: 1734307239-131215 X-HE-Meta: U2FsdGVkX1+Bnyi7FGJwTLhsH8CQTZ7byHefnV1OC9jpfgyCWlulM3DZCPxi0wZ1a9daNSjotns8/eTVCrqwkETI2DZMq8Ym41h8THRF9r9zmryekbMJFjmE8Kw2vA2orR09kn6b0qoFiFChIg1BwA8bB2ka3qI0GiNkfiLj5L1FulsyYq1VsE5/Ku39Y+cb1hYf6yXEVdwOI12JBq8Zj/brxzAZ9vjP60PJuDJ39TdbSTMjfJijxCS9+SYS083xWtNmApBMX3Jkbb/fzl9YYvtY9k/kB2SIGvwq/DEBcprDiLCbLh3WTZQHdko7Pn3L5A8l0v/M3g8Y6PM8pdzdMgcVf19rn84C3taNMz3wQO+1pOa9j5wB3PTEPyj4xdmWRatmp17ZEzNjx1jdakZkZdW2rHWgMI4piypyiqUUIApYe0KP4GIsTyOUn0n8lE0LjgujMm2CJ9bB0mkyWX6mR+3lVyVwiyDNEAPdNGAzazheOfG7FOu6uBNi/PPc+udhBbqShbIUm4jSkSUUKE+Hoq2LnNUviPzkg/n1WYcN/Q+EOHBdquxa5573KDgc0u3mgUCDBTCG2UjbX7FfTH7+XAmlXoBDIS0pfqfgoi743MikvKabZH8cqApnQey/5Xj8ZAW/Wc1YQ1xiLKkPRxZqUtdDI9itjLKYUMOiT8eYGC7pj/Cv4Pnqo6qRIKgtKmtRAIBX0pxta67pfcW152hWx3WYgDfi2de7N1Bjoyegd2PXMaWvNrfn8E77CYgeZta8jJX4yAC5DR3vSOB/3P1sVd9IskYMBGnfehNlfR3uzEVR8zF2RYcwlo7j9atxt3mAL0UehafuxIqhCRe0G/7VtU9+WqsbktI2PT+JqHOpSG1zeR9uPOOcjTvzomn/w/hduI6SGmbnQY9mUsM0IVaStr3fNcUfgbGUPiK1/a69qQKnHOsa8hZFN3c0HFdierzZekfQQGn94RCuVkLMUR9 elR0tDWT I74LFE5GQ+qKq2NNVvqzFkFs9Q2JjVJB5PO6FugLdRIGeEyhEU53/2G6qfloeAEmxkJ5sDXBcnKZrjoHTgWnqKnkuejecIDD5v1HipUosZsOxj7lC6RqEhZ52vqj5P1zBrresl3stL6MeLUmOyFuee3ACCq/VKAtK2cDvItJ3ESk3rvYUTujPJNgfSGcIhGEkzoppFuwaOOitGEDVe64d9Y6jCzZJCVyBfhGC7pbVHkwDxoPdvM2llseaor48nifNwvPP/Gura/fyYoNZAc8WN+7UV2hdmVY2d2YjCySCEN2U8N0y7BSGiY3e/qDBkOxPmRaWtIe+mcLn5xqD5P6LjCZ26QVbed9mp5arRaIGdDKaPAavVQqfathtkNOooE2Y2Lv3XuM7HN2qXb+slMxFYE5Jz/3YL8oge45hVi6hLkFwcOVRyKwhZoO6dozZwz7uJS76Tg3fzeJy5XAmC5Ni6beaqRDsnUemO50+daF6X+I48x1EZJrFhXuozA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.037111, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 10 Dec 2024, Hyeonggon Yoo wrote: > Commit 8b8817630ae8 ("mm/migrate: make isolate_movable_page() skip slab > pages") introduced slab checks to prevent mis-identification of slab > pages as movable kernel pages. > > However, after Matthew's frozen folio series, these slab checks became > unnecessary as the migration logic fails to increase the reference count > for frozen slab folios. Remove these redundant slab checks and associated > memory barriers. > > Signed-off-by: Hyeonggon Yoo <42.hyeyoo@gmail.com> Acked-by: David Rientjes