From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FC57C28B23 for ; Fri, 7 Mar 2025 14:47:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 405996B0082; Fri, 7 Mar 2025 09:47:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3B4D16B0083; Fri, 7 Mar 2025 09:47:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 27D126B0085; Fri, 7 Mar 2025 09:47:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 0AA046B0082 for ; Fri, 7 Mar 2025 09:47:33 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id B40C780C3E for ; Fri, 7 Mar 2025 14:47:33 +0000 (UTC) X-FDA: 83195033586.25.3CC1C66 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf03.hostedemail.com (Postfix) with ESMTP id 4B29320006 for ; Fri, 7 Mar 2025 14:47:31 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=p89e8Vs2; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=lRACKNHA; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=XGzuTsY6; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=lklopRZF; spf=pass (imf03.hostedemail.com: domain of jack@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741358851; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=V3e0QAGzyMycCbFd6B+5fqZyw6K7Uq5wm7ushJR/f5Y=; b=4xzFDBbH9kMv/GMiiOCBqVo8offDjo9YkQYYKM7wG/Lcluw9h5lbyJu7yUrzOEWDW7/T+k 6dATtYBzlbPBsJxHTicq4mkgIQCRbp86pAuFaSoykmBY8i/L2Rc5LRUQVHPoIzYDWnkdME HY+68G6Ff7LlA6ObLAXhAxdGwEx1yq4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741358851; a=rsa-sha256; cv=none; b=NraHIXAXqFty9aGZELQZwwqMal9QyNYjWAaDazeShqSLn2VibhSetHbz55viQ2YaP1gHUE /9eaTDS6TwBXbWgEF2cCM8e5DcMZmzXsZItZTBkl2aCNZX0XjtXlqbjSSk8pKQbYH7N16N Cr6CBDktKuRW63Fs0Et2PswSiQWGdxE= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=p89e8Vs2; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=lRACKNHA; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=XGzuTsY6; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=lklopRZF; spf=pass (imf03.hostedemail.com: domain of jack@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 9AC941F395; Fri, 7 Mar 2025 14:47:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1741358849; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=V3e0QAGzyMycCbFd6B+5fqZyw6K7Uq5wm7ushJR/f5Y=; b=p89e8Vs2POw8H9ao/jx5slB/pophAmIlhL0naiE+25jguenqZ1HJ7gk3Jm5u35pDoK5w8C gl7VRA1BkBiJrHWBP+GxEq2Dx2ItTY7PbQo86wNzhGwsutkyjixbNImHFODVV8fii+ax9n EyAuQMVPzO4VT3zQxNoCT1a3/dtekgs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1741358849; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=V3e0QAGzyMycCbFd6B+5fqZyw6K7Uq5wm7ushJR/f5Y=; b=lRACKNHAPTpgQRNsvSrf2xEFztkZlnxGBAVAjWT8IvgJRoFRsNEsPaYGl6HktpkdaA6K0V pW7PykZgAieHEKAg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1741358848; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=V3e0QAGzyMycCbFd6B+5fqZyw6K7Uq5wm7ushJR/f5Y=; b=XGzuTsY6IWmI3NXFw1cZKSnsmuzD+QWzn7L+njmbTru81fvRqSF4eWoJxwTPBvYFz8rJhC ISZbq18iXWSsGhweQz6jqL0QoKclmtmlYNDklaqaoFML/nOLDFaHqBcBecffgLZRScfJun ceOrsojuttOxFr+p5OZUqaVL3iAp1Pg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1741358848; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=V3e0QAGzyMycCbFd6B+5fqZyw6K7Uq5wm7ushJR/f5Y=; b=lklopRZFtsxRfgj0e23BtpElXr6wU5nRUP8gVcFqh1+eBoWJWgDm0UjTANTtXRDFOKWJa/ Dl39lJX4UoewqPBg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 8FEAC13939; Fri, 7 Mar 2025 14:47:28 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id /VoGIwAHy2cxMgAAD6G6ig (envelope-from ); Fri, 07 Mar 2025 14:47:28 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id 570B0A089C; Fri, 7 Mar 2025 15:47:28 +0100 (CET) Date: Fri, 7 Mar 2025 15:47:28 +0100 From: Jan Kara To: sunliming@linux.dev Cc: viro@zeniv.linux.org.uk, brauner@kernel.org, jack@suse.cz, kees@kernel.org, ebiederm@xmission.com, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, sunliming@kylinos.cn, kernel test robot Subject: Re: [PATCH] fs: binfmt_elf_efpic: fix variable set but not used warning Message-ID: References: <20250307061128.2999222-1-sunliming@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250307061128.2999222-1-sunliming@linux.dev> X-Stat-Signature: xcbwr34cphbnrgn6dxp1r1s8iaq5n1n5 X-Rspamd-Queue-Id: 4B29320006 X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1741358851-310387 X-HE-Meta: U2FsdGVkX1+Nx84ZF05Zay09F9na6s2TYUH0Rh5F4kV0xUd40eIJkMqKb7dMgInmLhj+OO2eXOWn4W/PUWkbfSTgml0JV5nONk28FrcCmfJ4GPJGWhg4i9m5ZkLWvJ/RGjnCzYwJqhgjLXlrA87kOGuzxtvfGrptIzyrwI9uKDkNQIVjdFpo2F5VSSjzhThOtZ77aGCf0Gp278JIIauoeaZQuJ7LeU8C9jAH9cXhI+9FR+NjT2qhCWuY692gXjg5phvVaYt3pleJWphUEAJkVdqxYp3j5bnZf/hsLiEGwXMVGYiWLe6BGwNagsN5Icn60hQHrAI7y6V+1JyRsQRtqvWfZAplhLRXz6P51sy1tcKicJi8CMzV3Y6Haf0HlV6KXgKzkAR0Q7qhmUJKCeyoUfh4Bb7G9iN2JCgBmwJeRntB28WcySHu5oHSA+matEpzDnslnc5U29NlU1O2QmKCCiBjNytmnfdXwpnh3J2viyZ2EylYTqhzeP7w32fy6fvzV6zhHtx4qRkaOaq+HwhqOKvAjuofG9LBBhdiJUcWeF1NAS2jykkU1lR4Ny8DwKLPP/eyDvnVenMoTSdmAAvsrE1JoR9Cqf6lm18R22ZgruTj7L63UgBzyKM/LmeEzi6WYVYhInVnk9/F0cEBlrPlSehuqDnUX6x+L/8g2Iq/113PiyFjMUBkKTEjdCYYYjhJhzH7uJySYBdA/6OFUskmC9ebGSCS/xcdyj9B1C55H0oEYsSvTNAtm4OXnhbHnYhQyjixhY0vMUEZeKoretuGX15VO20MlJEV2Kr5hJhD6B41ADDvTXPsCjfDGq5lA+cyn6UknH4OweCawolit7SKHGy0WKPk+hRvsjfl/I3v5Yzfti+6wArnjSpYfJfKI465chM+o0OvBM9EFrPhDifbmu9RPrvTO0ayzFLVDTlClQ1mniLM/2hYCcDnArDesLQOV+FUEls0z6HZ7MJCLyJ v7m54jOv wpATAmCUfS5F1qPThR2SM/ujWAY5x7yyRdVgUC60rMhuh/oPnLILsLD18Y1bqnRmjuZnyYD7Naiapeq1lX40SKxomYR3j5mKuzQg2QOykoxFdBLYR02e8e8S9O6ClPj3iydFP4wU6vEJJqLwxtidP9IZDjOq/E5ZEff/6Z4iNgb3Y1Gur+vh7mr/RaoiarV39jKYZCg/DeqhOz/jdPDsMB7gKrh0a4CCI8FvpA0rMVzp9K0mOXn+kUSRdF4EBUzg/eH8vW6CFCu0NBJ/b32zIHT0ROMReTSmjCkLFLJDrAdzDt1Oxqr6w3XBRdK0XrEDMUpzKLFIoNW2yKajfPnFLq221YKoQsVWTyVoKmv9kFM2pGVAgo3FJD+zaiKniDb1arYD4KrzQaeYLkmqk4eek6ImHWJ5+uOU+j/Yo X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri 07-03-25 14:11:28, sunliming@linux.dev wrote: > From: sunliming > > Fix below kernel warning: > fs/binfmt_elf_fdpic.c:1024:52: warning: variable 'excess1' set but not > used [-Wunused-but-set-variable] > > Reported-by: kernel test robot > Signed-off-by: sunliming The extra ifdef is not pretty but I guess it's better. Feel free to add: Reviewed-by: Jan Kara Honza > --- > fs/binfmt_elf_fdpic.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/fs/binfmt_elf_fdpic.c b/fs/binfmt_elf_fdpic.c > index e3cf2801cd64..bed13ee8bfec 100644 > --- a/fs/binfmt_elf_fdpic.c > +++ b/fs/binfmt_elf_fdpic.c > @@ -1024,8 +1024,11 @@ static int elf_fdpic_map_file_by_direct_mmap(struct elf_fdpic_params *params, > /* deal with each load segment separately */ > phdr = params->phdrs; > for (loop = 0; loop < params->hdr.e_phnum; loop++, phdr++) { > - unsigned long maddr, disp, excess, excess1; > + unsigned long maddr, disp, excess; > int prot = 0, flags; > +#ifdef CONFIG_MMU > + unsigned long excess1; > +#endif > > if (phdr->p_type != PT_LOAD) > continue; > @@ -1120,9 +1123,9 @@ static int elf_fdpic_map_file_by_direct_mmap(struct elf_fdpic_params *params, > * extant in the file > */ > excess = phdr->p_memsz - phdr->p_filesz; > - excess1 = PAGE_SIZE - ((maddr + phdr->p_filesz) & ~PAGE_MASK); > > #ifdef CONFIG_MMU > + excess1 = PAGE_SIZE - ((maddr + phdr->p_filesz) & ~PAGE_MASK); > if (excess > excess1) { > unsigned long xaddr = maddr + phdr->p_filesz + excess1; > unsigned long xmaddr; > -- > 2.25.1 > -- Jan Kara SUSE Labs, CR