From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90CDCC2D0CD for ; Thu, 15 May 2025 09:43:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B3CD16B00C6; Thu, 15 May 2025 05:43:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AED106B00C7; Thu, 15 May 2025 05:43:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9B5506B00CD; Thu, 15 May 2025 05:43:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 79E396B00C6 for ; Thu, 15 May 2025 05:43:46 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id AA6B05FA5E for ; Thu, 15 May 2025 09:43:47 +0000 (UTC) X-FDA: 83444655294.07.42A24D0 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf14.hostedemail.com (Postfix) with ESMTP id EC092100012 for ; Thu, 15 May 2025 09:43:45 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf14.hostedemail.com: domain of dev.jain@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=dev.jain@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747302226; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nbzQUOIpcNkcpmUeyLGzVJj8Imo9OtxptD3lQ1KUER4=; b=O45gcK66M7xubl6/YsD1AY8jaJEVlI/M17aw+85GCnJvRi6qm1yryj3qEGuEWJr/q4+yHk uvDd3qYgyAH72h+oiBxS14gc0Ek5N+2TQW1xEnod97zrUacc4m8Rqmp9OuGnfzqM31BolV 7X4kOtRGGUlP/R8ISS8KhmbHl17tCJo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747302226; a=rsa-sha256; cv=none; b=MduAYElaXiQ9tUlU92o9AV42CSZqiztbtDh5BeuuySkAJzS8lFt6H5Tic+etDN81lP5Wcj +t1FrsiFOBLuXgjpKTKM/xaum8kA3cE70T7XNtzLhIFc9MvZzIQt4Q9KxVlcjLTnZAGLPp g0nGsE4c/77RCBxSewf5HM7309EoPyc= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf14.hostedemail.com: domain of dev.jain@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=dev.jain@arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8E21614BF; Thu, 15 May 2025 02:43:33 -0700 (PDT) Received: from [10.162.40.26] (K4MQJ0H1H2.blr.arm.com [10.162.40.26]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 3AD5D3F5A1; Thu, 15 May 2025 02:43:42 -0700 (PDT) Message-ID: Date: Thu, 15 May 2025 15:13:40 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] selftests/mm: Fix test result reporting in gup_longterm To: Mark Brown Cc: Andrew Morton , Shuah Khan , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250515-selftests-mm-gup-longterm-dups-v1-1-05f8f731cf63@kernel.org> <7c2f66f9-a928-4fda-bf3e-4180c7525fef@arm.com> Content-Language: en-US From: Dev Jain In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: 4dygmt9c787b7wynbc3ef3h7zqzhb8nw X-Rspam-User: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: EC092100012 X-HE-Tag: 1747302225-767291 X-HE-Meta: U2FsdGVkX19efCaAbw2PGB56kKJOX/hpKvcok9ObMxRN+FL/X6Pj6bnDU45PEVq0fnigfpG1aHtuaLXYaMVMLVdWkUMaIT7EmzWX9p4t9I+G/QKDjo+6ILKgPT1V0T6esXSbOHDVtREcpEccHcHxl+ac+NmUCgikFeDAKYbAgifYmgDupZcZaEaHlMSc4TXa1N8aBcK2NZsgqmq0umh9UWLlFR2FV05LZssJDP8FT0L0LIZwOM5QQkJ0nenufnUTnk/4IlXaBuKxOUONmpJKdi60qkqgFiCbn35CTSdXqCb2k+gD0+vZr8o8sPvv/Cc0cTNfNL0CcF0i9pYwZq2HAZJQMftIC6LkBY6RP9nIZVnD7mUHmPGDUji11TNWHDG4w5IjCypzxGOSoi4yrck6UWfd70jPtDrTJ4dSKqXtVhDJw1PQG/OVJoR7hq4F5EtddzyMV2EZDjIl6SPP+k8aYg1fIsun5wuCRBQfpvPqmhpzGZdnNWxI8DRPOvNtNQ1Oo1etfOQcIFqO+RFu7BJ0yHio01E1ch9EdcKJKva9JOqmeTwv6EcoWMk7uZqeLVJ2hXOENn2cJYNDAeJRP9jIp1blnunxGFtWGiiIkSjHefLtiELUjgApRZJq/vsk4H+Hoay0m2a6IBPtZJfiwlJMgVtEA2Xkh55JwQAaRAbOXbWi8WQ3+TbrO8icq1CG/kD0EY6N1zORY48sjjZC9LakJF8Hq1XhtSB7V6w7BJfxYDRG4G/HNv1lisQprOzApFFAG4qTyYGZK8Pqb+mZfgHvX3hMURMYrOZ553TJmZAnzXOG5kr0tngVTmAmrHwwznUYfLqY8hjebA/Bq2oYH0cfSAgQ9DqYQK37CrZR1/WVy4fnVa+Mg7SRz8keiBewKj0I72DkoQnzMT8Z9HpNfjPwPSx+OiOlwKL+Zfylo3ELdJuZgKXOfPjgoFuOv+uFB6KqvGB/QTcq+rcQj3kVWN+ JBzPAT3/ yVUGk6Bz3t2yGvuwhf0AjCxIlAWNLUIpPC0KrttKyHgvYuSBgNiNXfIkLcYnpk2/STlN9wIdj0O1l9+PNJNZRvbxp8HYYm7vQrd4gqAWGVQJ0SZe+ipMTJMOzbLFc44fJHdGJ+0jR9LsS9Fmzg7gZY+/5L2XFJpCGIPGoeajUlXutDuLHchvUxAzGcYRc4q4YCE4z X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 15/05/25 3:11 pm, Mark Brown wrote: > On Thu, May 15, 2025 at 03:05:07PM +0530, Dev Jain wrote: >> On 15/05/25 2:27 pm, Mark Brown wrote: > >>> @@ -189,7 +214,10 @@ static void do_test(int fd, size_t size, enum test_type type, bool shared) >>> * some previously unsupported filesystems, we might want to >>> * perform some additional tests for possible data corruptions. >>> */ >>> - ksft_test_result(should_work, "Should have worked\n"); >>> + if (should_work) >>> + result = KSFT_PASS; > >> Missed printing "Should have worked" here. > > I didn't think that output was particularly useful separate to the > overall test result (which is logged on exit from the function), it's > just the test result more than diagnostic information. No hard opinion. > > Please delete unneeded context from mails when replying. Doing this > makes it much easier to find your reply in the message, helping ensure > it won't be missed by people scrolling through the irrelevant quoted > material. You have mentioned that before, sorry my bad! I also hate it :)