Re: [PATCH] selftests/mm: Fix test result reporting in gup_longterm

[Dev Jain <dev.jain@arm.com>]

On 15/05/25 3:11 pm, Mark Brown wrote:
> On Thu, May 15, 2025 at 03:05:07PM +0530, Dev Jain wrote:
>> On 15/05/25 2:27 pm, Mark Brown wrote:
> 
>>> @@ -189,7 +214,10 @@ static void do_test(int fd, size_t size, enum test_type type, bool shared)
>>>    		 * some previously unsupported filesystems, we might want to
>>>    		 * perform some additional tests for possible data corruptions.
>>>    		 */
>>> -		ksft_test_result(should_work, "Should have worked\n");
>>> +		if (should_work)
>>> +			result = KSFT_PASS;
> 
>> Missed printing "Should have worked" here.
> 
> I didn't think that output was particularly useful separate to the
> overall test result (which is logged on exit from the function), it's
> just the test result more than diagnostic information.

No hard opinion.

> 
> Please delete unneeded context from mails when replying.  Doing this
> makes it much easier to find your reply in the message, helping ensure
> it won't be missed by people scrolling through the irrelevant quoted
> material.

You have mentioned that before, sorry my bad! I also hate it :)