From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55D1FCFD354 for ; Fri, 11 Oct 2024 11:33:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C33E06B00A5; Fri, 11 Oct 2024 07:33:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BBC6D6B00B7; Fri, 11 Oct 2024 07:33:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9E7556B00B8; Fri, 11 Oct 2024 07:33:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 7D3596B00A5 for ; Fri, 11 Oct 2024 07:33:21 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id E7484A0D4D for ; Fri, 11 Oct 2024 11:33:12 +0000 (UTC) X-FDA: 82661110518.07.00FEF75 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf30.hostedemail.com (Postfix) with ESMTP id 99AC78000E for ; Fri, 11 Oct 2024 11:33:14 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=DNPAJreG; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728646370; a=rsa-sha256; cv=none; b=03QcjsvRBhj9KhGX0v3NzaHS7Pxgoxm0+no7+s3OTIK2jKg2Gk+3DzNeGmbmQj/ouFdcQr EfALgmUSWfBCyk+jNd/CKykELlbrKKlSUcEFeY39+ka8G/ezUDHpwubSZ2ecHXhf7o3FhA b7A3v3ZQgRvEdVsBg0Bgfvs9TM93CYg= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=DNPAJreG; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728646370; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Aqbzb2c5WWVPDUb5fQ29KQ0F4f+JQrPIhyMo9Cv4DN4=; b=ZU+eeEa4eYcs1YjQeFZPWR9As9oZvuiLj8ckdo7KvdZKTwv4pbHLxDYkJnaMskwZk4yZ/6 1u2WuDYb96lhPfXes4tFKRWZuXPFiDn/fSm4dj5Y0sruFpTrRvkOCupemBrSZu0KnN5Gph Xgczkn3o+YyyfcsIdoCiDPvIPvnj0Y8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1728646398; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Aqbzb2c5WWVPDUb5fQ29KQ0F4f+JQrPIhyMo9Cv4DN4=; b=DNPAJreGLq/unGbGlG8vQF9+r2hZo6YeLbJmpLdt+lUIeGLpVg6RMCc9xZAlSOgejrewgL 3vz8NfeNRd2cw8wZgnOfC7qBtSTLeJJ1r6APeG0IsUOaE1lzWpPn/kaQz28ZLcvLWXpAjH TxS2fRvb42ndTQJ5FaJGvkIkhZaxibE= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-600-6fDf3SLHPOaism8SJMaxBQ-1; Fri, 11 Oct 2024 07:33:15 -0400 X-MC-Unique: 6fDf3SLHPOaism8SJMaxBQ-1 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-37d49887a2cso1075483f8f.0 for ; Fri, 11 Oct 2024 04:33:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728646394; x=1729251194; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=Aqbzb2c5WWVPDUb5fQ29KQ0F4f+JQrPIhyMo9Cv4DN4=; b=DYhpEV+6WW1VlOMBK/iQ1jfQa3u8WZXnifOQXsK9AWccejcXG2dptdCYaJ/Kq8xF5G +i3Ps7AHYGryrchwSKjCupznmNEgrOPrsi+9B609uT38BS/tDmxnHk8hkObCn3aH2F7o viiyDqnhFq6kPpnx+fffBV09Vf73eYOm3atyDNsmXyQMbVpOmRQM2bH/09W74yCWdXPi 15m/BniElO+rvfiYCl6VUre2WNiIzhYyPO09mWC4g/d6UnkAOjFXZszHdWQJ72pUhjgh /HW0cZGl3Xu2ZBdOVMG3ui4pIRJCdMpznqBfJvtSXGoKRYE/W9elHYwu/NFuhmtxL0Ba u/3g== X-Gm-Message-State: AOJu0YzjBcVUsW6A79zIV1hm+KCYbEuToljM6QvW3GNw8RO2+qoukUG/ zFYrXpy/URsTafqnU3zzl994v/6L31gQP3beYpotY/rgcISQdhxGhuXP2CXBlCZbhQ8x14KtGYL CUxzE0OxO/ZvLGRFyyEYa2R7dDB9FVZBn6FPlQ3vHSTmHAZQ0 X-Received: by 2002:a5d:5f4b:0:b0:37d:47b5:ba45 with SMTP id ffacd0b85a97d-37d5519b9b3mr2421146f8f.7.1728646393993; Fri, 11 Oct 2024 04:33:13 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFJ6KFxMKU+6yFmlWe0ER7O25G0tSntOVOggFqoLe0XpO04At6W9SVcPX121/vjZqcKdziMjA== X-Received: by 2002:a5d:5f4b:0:b0:37d:47b5:ba45 with SMTP id ffacd0b85a97d-37d5519b9b3mr2421117f8f.7.1728646393620; Fri, 11 Oct 2024 04:33:13 -0700 (PDT) Received: from ?IPV6:2003:cb:c749:9100:c078:eec6:f2f4:dd3b? (p200300cbc7499100c078eec6f2f4dd3b.dip0.t-ipconnect.de. [2003:cb:c749:9100:c078:eec6:f2f4:dd3b]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-37d4b6cf960sm3706563f8f.63.2024.10.11.04.33.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 11 Oct 2024 04:33:13 -0700 (PDT) Message-ID: Date: Fri, 11 Oct 2024 13:33:12 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 2/2] mm: don't install PMD mappings when THPs are disabled by the hw/process/vma To: Ryan Roberts , linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, kvm@vger.kernel.org, Andrew Morton , Hugh Dickins , Thomas Huth , "Matthew Wilcox (Oracle)" , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , Kefeng Wang , Leo Fu References: <20241011102445.934409-1-david@redhat.com> <20241011102445.934409-3-david@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: hips4uodihbgwfimebqczma4i8y669i1 X-Rspamd-Queue-Id: 99AC78000E X-Rspamd-Server: rspam02 X-HE-Tag: 1728646394-41629 X-HE-Meta: U2FsdGVkX19u2MVjyekzWBWa5ZUoTwgSh4mWI5PcEX+amnrLub6aqrw7WKJz2glHP1qnT1FslUZ4RdAgU/djBthkYyc/2Wu1h/7uD2iyxeG49bc/c2Bv0MgakmI2cTHT/zvta+1Shk3t8hrOkSsdbEyxt9aWuH/tA6I+BxT3sMy1uBP84uFduldZrqCkzleT74tvA/R82YAcMs5A3BEKKIdd5hmNIoswtMMDEBeTTqO2uv7V6wGVwLt9jBH+lKG9cwqYHfGN4tw+yiRRR4qCnz7sN5+2W+dyvwamiivmvPuBLIlK6gtqaPtFUz2onDjzwYFIxmejjvIoXW6vlVP9Kl5P8huaff4l/w3QXD7V7pB4KZBzEPhdlDc0EDQEzDRm/V2FHTqoq9zRF2t/PURyoDBrS1C6MLGeRmJkfpsXyGLHlyQvRfSb/8yHZyFqs34PdNNxw87NDzAdM0nC/MA5FSPI3JM+Es1Ue2SHIRJp8OIR45n8bjp0u3RORA3WheCyUpRfC3+q6krg3oF9TNzlmaWBG4Cou9uW5xVGt27jAJiOp8Z9kzwL+IpLvNGbtwLg0XQt9oKF1LpXNMP2xLaAE/DLfJ+7gRMnIRiWJZbDzXXkhrS1hL5DMumY4iNKfINXaUTwQbIm18NQ34pyEZAuiQSHly7SGyqRMxprNi+hU5nb/PwFoi3cQR+FFd85rCrknG6yNa94HEUiAYMxO75FPl2lUbCLV8CucolcibgCxrneDSKSrYifA8fAVAmp2IvU/QpVRN6JZXYL05gWg5KYHRzBb5H67+3SmqpPmaIeSmppCUM63mguDQ2w3p1HfUMDBeYjyl0sTg4Gcq2JOE1G26r89QmHGl7eNeEAttOo9vleH3dNKmYbR/IrzX67tqbGYHVLLNnGacfCk6dehJxoawGte+w8Iss9Zzv27VqBBSjsmutrxThArCLi/gGhfZaWUgY7WePWrZqGGXF9GnD D9XGczhx 6DlgFTTxCyLCbFisF60y1ta30HsEHfGbWGdx9FNuxX/HnEf/JdJ9Eq89ZAYWSPAJhntZVu5D0yT6TDV763XkbwmJ1lSnj0xZOVjEjr0b/2Ly3ySxwkkQC/CwXFDBQR2SlScR8dvfLx6gsV6NcxitMVbLW3rIZ4tQKVLv7+DgL8DjBOAlptWi2/tT2smYBgX/LbYgWbEzjxV3WDJkKU5Dwk5IqR3tvZjrEazBgVdTBb5y6J/vTJx+jno8+vhHMAwxCBp3/kdOOZEVx6a54CfgWpst0BhJVdYTOBKfKyG4PPoGrovYSDEKikW7xwl/8rECJhgfylUOleqKQAZGJ2jdXbSMxMuMjxX8vBQSBziBGw42f3N0e+jMau0+A/WIdbK3a6X0+oga05ua88rGj3lsqhaKdH72ybM3YGyZpv+oHlaf9pdg2fSGIyLmB2Bzrw+ApbTNRWHh/wqeXWHD/F5KJo1AkE9PZyM3DFVypLep/D8uXmsdq7yDlwUFTy07+B84K17Nlj0EltYbPWp9FZbi0yHaZUC9gpLmeiC6qvwty6VYCSXR8zBv4XV2A6A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 11.10.24 13:29, Ryan Roberts wrote: > On 11/10/2024 11:24, David Hildenbrand wrote: >> We (or rather, readahead logic :) ) might be allocating a THP in the >> pagecache and then try mapping it into a process that explicitly disabled >> THP: we might end up installing PMD mappings. >> >> This is a problem for s390x KVM, which explicitly remaps all PMD-mapped >> THPs to be PTE-mapped in s390_enable_sie()->thp_split_mm(), before >> starting the VM. >> >> For example, starting a VM backed on a file system with large folios >> supported makes the VM crash when the VM tries accessing such a mapping >> using KVM. >> >> Is it also a problem when the HW disabled THP using >> TRANSPARENT_HUGEPAGE_UNSUPPORTED? At least on x86 this would be the case >> without X86_FEATURE_PSE. >> >> In the future, we might be able to do better on s390x and only disallow >> PMD mappings -- what s390x and likely TRANSPARENT_HUGEPAGE_UNSUPPORTED >> really wants. For now, fix it by essentially performing the same check as >> would be done in __thp_vma_allowable_orders() or in shmem code, where this >> works as expected, and disallow PMD mappings, making us fallback to PTE >> mappings. >> >> Reported-by: Leo Fu >> Fixes: 793917d997df ("mm/readahead: Add large folio readahead") > > Will this patch be difficult to backport given it depends on the previous patch > and that doesn't have a Fixes tag? "difficult" -- not really. Andrew might want to tag patch #1 with "Fixes:" as well, but I can also send simple stable backports that avoid patch #1. (Thinking again, I assume we want to Cc:stable) > >> Cc: Thomas Huth >> Cc: Matthew Wilcox (Oracle) >> Cc: Ryan Roberts >> Cc: Christian Borntraeger >> Cc: Janosch Frank >> Cc: Claudio Imbrenda >> Signed-off-by: David Hildenbrand >> --- >> mm/memory.c | 9 +++++++++ >> 1 file changed, 9 insertions(+) >> >> diff --git a/mm/memory.c b/mm/memory.c >> index 2366578015ad..a2e501489517 100644 >> --- a/mm/memory.c >> +++ b/mm/memory.c >> @@ -4925,6 +4925,15 @@ vm_fault_t do_set_pmd(struct vm_fault *vmf, struct page *page) >> pmd_t entry; >> vm_fault_t ret = VM_FAULT_FALLBACK; >> >> + /* >> + * It is too late to allocate a small folio, we already have a large >> + * folio in the pagecache: especially s390 KVM cannot tolerate any >> + * PMD mappings, but PTE-mapped THP are fine. So let's simply refuse any >> + * PMD mappings if THPs are disabled. >> + */ >> + if (thp_disabled_by_hw() || vma_thp_disabled(vma, vma->vm_flags)) >> + return ret; > > Why not just call thp_vma_allowable_orders()? Why call thp_vma_allowable_orders() that does a lot more work that doesn't really apply here? :) I'd say, just like shmem, we handle this separately here. -- Cheers, David / dhildenb