From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3AF23E7718B for ; Sun, 29 Dec 2024 14:57:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 86CB36B007B; Sun, 29 Dec 2024 09:57:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7F5D16B0083; Sun, 29 Dec 2024 09:57:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 696116B0085; Sun, 29 Dec 2024 09:57:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 49E0D6B007B for ; Sun, 29 Dec 2024 09:57:55 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id DA8721A1596 for ; Sun, 29 Dec 2024 14:57:54 +0000 (UTC) X-FDA: 82948300764.02.BB38443 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf20.hostedemail.com (Postfix) with ESMTP id 64F871C0003 for ; Sun, 29 Dec 2024 14:57:05 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=IZgFsQki; spf=pass (imf20.hostedemail.com: domain of donettom@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=donettom@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1735484252; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mggIH5c11tMsZWj/+1hXr3rjU1yhEB+HE7S6unz5wKs=; b=HoKZP05xJhSx2JzoeisTTFcg7FOqTHWIi4RJEYSg8nY+geatPuKcvy7pNy+H2jZKSPF/7S ElqqGdYUnGi3b3Xq8t2LvzUF7vn8iQ713k+gvwVZ5P72eNmpNqEYvm4zN7yYaGl2VtD31A D4RZODOH/QVaehnGOcpaAyk130g6IJQ= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=IZgFsQki; spf=pass (imf20.hostedemail.com: domain of donettom@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=donettom@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1735484252; a=rsa-sha256; cv=none; b=UOS+58gQtnayZLmdSVxT14ZpK2JCOuiACNQe2grwS/mLv6NZBqUaKXPpdEHbT8tlvWtoAL iiEict7o2GxWI7zMDmZ9AvFTiALGeDExZ0vvF5BqtdKyfXl0kL9VRui1daKxlYHfoYKFzH k6V865ImO0svRTA6v+uF9vrLnaGk0qk= Received: from pps.filterd (m0360083.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4BTDlmRe019905; Sun, 29 Dec 2024 14:57:49 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=mggIH5 c11tMsZWj/+1hXr3rjU1yhEB+HE7S6unz5wKs=; b=IZgFsQki9R1ll/Rszx30Fz Ex75mqr+0VjbHJLPQGcx8S9euoqBIsqyXFVZZNfDs0OunFh/+R+VHLDq3bPRVs/6 53BUjM0oRCrY68QK5enN6F/ydB5jQebc7jWYM5lNFt8yK7Z5GePIG5oJ8FRWSGTk B6ceDXjQczcFFaZS/Tjtm50i9/NMLltoo2da2uZ6tZ+7qvmzU/haTex+09OUStEa aqLV4uZp571G6U04Xd6PAk1SnJiGYqN3OfBxFF9HtuFOBnTlvF9WBxQ7XTIgkxJC zewHP4WtJ6FP96XmcMTEuSoAt4tVdaZhcmyd+DorBDC8ZB3cAKV3npISabNrtSqA == Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 43txwb9aey-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 29 Dec 2024 14:57:49 +0000 (GMT) Received: from m0360083.ppops.net (m0360083.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 4BTEvmD9019978; Sun, 29 Dec 2024 14:57:48 GMT Received: from ppma11.dal12v.mail.ibm.com (db.9e.1632.ip4.static.sl-reverse.com [50.22.158.219]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 43txwb9aew-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 29 Dec 2024 14:57:48 +0000 (GMT) Received: from pps.filterd (ppma11.dal12v.mail.ibm.com [127.0.0.1]) by ppma11.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 4BT9Wrli027055; Sun, 29 Dec 2024 14:57:47 GMT Received: from smtprelay05.wdc07v.mail.ibm.com ([172.16.1.72]) by ppma11.dal12v.mail.ibm.com (PPS) with ESMTPS id 43txc1hnmx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 29 Dec 2024 14:57:47 +0000 Received: from smtpav06.wdc07v.mail.ibm.com (smtpav06.wdc07v.mail.ibm.com [10.39.53.233]) by smtprelay05.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 4BTEvlr724445572 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 29 Dec 2024 14:57:47 GMT Received: from smtpav06.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 159DD5804E; Sun, 29 Dec 2024 14:57:47 +0000 (GMT) Received: from smtpav06.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 241E65803F; Sun, 29 Dec 2024 14:57:41 +0000 (GMT) Received: from [9.171.1.162] (unknown [9.171.1.162]) by smtpav06.wdc07v.mail.ibm.com (Postfix) with ESMTP; Sun, 29 Dec 2024 14:57:40 +0000 (GMT) Message-ID: Date: Sun, 29 Dec 2024 20:27:39 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC v2 PATCH 4/5] vmstat: add page-cache numa hints To: Gregory Price Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, nehagholkar@meta.com, abhishekd@meta.com, kernel-team@meta.com, david@redhat.com, nphamcs@gmail.com, akpm@linux-foundation.org, hannes@cmpxchg.org, kbusch@meta.com, ying.huang@linux.alibaba.com References: <20241210213744.2968-1-gourry@gourry.net> <20241210213744.2968-5-gourry@gourry.net> <4504da8d-a5e7-45a1-9feb-167f94210200@linux.ibm.com> Content-Language: en-US From: Donet Tom In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: XC89uqIGNvmo7YzPS1jIm6b0-nKNt1AV X-Proofpoint-ORIG-GUID: tpscf6y3E1nTufbGLAkvXSqzZp-FXeBA X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1051,Hydra:6.0.680,FMLib:17.12.62.30 definitions=2024-10-15_01,2024-10-11_01,2024-09-30_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 mlxlogscore=552 clxscore=1015 malwarescore=0 priorityscore=1501 adultscore=0 mlxscore=0 suspectscore=0 lowpriorityscore=0 spamscore=0 bulkscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2412290129 X-Rspamd-Queue-Id: 64F871C0003 X-Stat-Signature: xrszksu3wr4zhnptgsspdq1jmfa7rdas X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1735484225-697896 X-HE-Meta: U2FsdGVkX1+JsJUMd1Q5OzoKHlyWaCin40xKaOoqDqVgsmyVw+dhiKz3AYqhxVFyT17NOJo9ElqD5iuL3ZbUXedpVHq+L5toBNeueZrRICoR7xCdf8A28tx9Q8bQwjbJsxK080DGuyFXNUBmMZc4HoRBT3oZ3GvZM4mInHiVjPCPIArNn39qRKIcbBZKt7as5xhrsdSTp6xvMpNw1/3yp3iMCEUCPk1CH4EEn66jxTdLUgtkszrqxxtfASP79LDpQrF/gU04gQagOG+yqZInmcW3Cs7416s1kMrpTs+jpmHhh3XbKTAzX4O/wHZlQ6ShWgS4c0RnSKabBDhBXJnj5omGW0K8ByC6Xth6BWzbkSSeiFgG4+Hxj1gSYeC8TqsYH9sW3AbnyKBXKS9xTXl2IlQ3DhHz8KdcLtFjhCBcqx+j8c9ELWR6vcozcEPPpMotVhLwyfwEiBTqjB8i9aO1qe2DQpIuKwvLf/RFLAsFBq1AUkWkdi4mg6UWs6MhoxTIZ0/yq+mpQ7KVvHRkPPMUsVTzghThLAyxlRewJrpYeIf4FvP7kzoGanOdcBAx7bVZWvLBg3xrym2FlaDXSsNPMB6K1/Xb6cvcOwS6EbDXX8Han6FpsjXL7b1H2ngHp2EzgphyLHjlQ0ja/bH1VgoeYd3PkZ2fBzdyPuxc+6F4x98q+8m0kTI83Fc51+/38xEgL0ypImORS384iL0KAhvLcFTGfTP84wYf2mpjQdKNocvf7c1JrgeukxxVz9eQMGO0eolhkQjO+/IBWaspaNfndw0HTjkk1CYq3OwnU+MlLmqoanGE3U3H4nyq1FQfEgqcIjnFs50C6Gvk2a8ohLmmLELIfy0N81GwnnNQX4oZ/K1j9rzDd1ldJywDJjhot7kSMQTuPHvN8DqppCR+fL+hoVCF7AKFF+VHkuTFLo74f2VwzMjb8OBhg+BEZcI7AvKzPvvtFfBnt3D4O2Oigsp voS87L6H i3hZpm9oYkYpQV44Po0d/s6AZAC2x9ZKdgBd4s6bDLK792ERbK/mtuOn3kjd3llIfs6Uk5dXVDtth0lVQ5vl9dxoezIHjpUdw8PCcFD1W8qWYH74Fk11RCQi7cc2KT2184dO3mdFo5FPTLdmsaCP7yiuxorTpBoXYC5JWYyv/61l7ChQi9l1CLJqvmKHZzHGfGcZ9LCnBlIzD797pM46QIrk5Xp/OmY4xKk+4ytFAm5dqTLTBN8CkNojDrQiUuxe8hLt4fnIVyaS1O+krYTM4zZmq9z1IhsKJcXsz0G5VnrIdSOaO6ZdWUGwJqCv8/FOUIKRx X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 12/27/24 21:19, Gregory Price wrote: > On Fri, Dec 27, 2024 at 04:18:24PM +0530, Donet Tom wrote: >> On 12/11/24 03:07, Gregory Price wrote: > ... snip ... >>> + NUMA_HINT_PAGE_CACHE, >>> + NUMA_HINT_PAGE_CACHE_LOCAL, >>> NUMA_PAGE_MIGRATE, > ... snip ... >>> if (folio_nid(folio) == numa_node_id()) { >>> - count_vm_numa_event(NUMA_HINT_FAULTS_LOCAL); >>> + count_vm_numa_event(NUMA_HINT_TYPE_LOCAL(vmf)); >> I have tested this patch series on my system with my test program. I am able >> to see unmapped page cache pages are getting promoted. >> numa_hint_faults2269numa_hint_faults_local2245numa_hint_page_cache1244numa_hint_page_cache_local0numa_pages_migrated4501 >> >> In my test result numa_hint_page_cache_local is 0. I am seeing >> numa_hint_page_cache_local will only be incremented if the folio's >> node and the process's running node are the same. This condition >> does not occur in the current implementation, correct? >> > I did not want to assume we'd never use this interface where such a > scenario could occur - so i wanted to: > > a) make such a scenario visible > b) make the code consistent with existing fault counts Understood, thank you for clarifying! > > I'm fine removing it. It's hard to know if this interface ever gets > called with that scenario occurringwithout capturing the data. > > ~Gregory >