From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFAB7C4320E for ; Thu, 12 Aug 2021 07:12:59 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4CBE86103E for ; Thu, 12 Aug 2021 07:12:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4CBE86103E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id B4CE76B006C; Thu, 12 Aug 2021 03:12:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AFCC56B0071; Thu, 12 Aug 2021 03:12:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9C4A98D0001; Thu, 12 Aug 2021 03:12:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0154.hostedemail.com [216.40.44.154]) by kanga.kvack.org (Postfix) with ESMTP id 7E30B6B006C for ; Thu, 12 Aug 2021 03:12:58 -0400 (EDT) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 1B921183C7639 for ; Thu, 12 Aug 2021 07:12:58 +0000 (UTC) X-FDA: 78465561636.26.ACFDFF5 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf04.hostedemail.com (Postfix) with ESMTP id BA8AF5001049 for ; Thu, 12 Aug 2021 07:12:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1628752377; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=r1z8oCJ5otLeJGBN/vU9nWn4UXFrvOTRJOJmiwu3d0Y=; b=ipTCpo3BCM2RXa/8XEyKvoKpyZUUv+AcYw3gSv6h8jIT8a0fYPVl//fUWAAOJASiMQ7EYY WpEd3sKqjZAqJY2VTL42iAwYSeAf8qVndaLKKjL6/TWus6+Ci2RrGAsyYd2DsknoWfNj8Q zR+tMQwngXtD/mcTFnlZdmwoZo5lA38= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-6-yK3jwZIkOyqqMat1aa3Zrg-1; Thu, 12 Aug 2021 03:12:56 -0400 X-MC-Unique: yK3jwZIkOyqqMat1aa3Zrg-1 Received: by mail-wr1-f72.google.com with SMTP id p2-20020a5d48c20000b0290150e4a5e7e0so1490099wrs.13 for ; Thu, 12 Aug 2021 00:12:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=r1z8oCJ5otLeJGBN/vU9nWn4UXFrvOTRJOJmiwu3d0Y=; b=Wy9Bg4tpyXDPRGWS1dLmjnQpH0NM+zWeGxl68CSKiz4oiGOVriDyPLeDbXaVIQsaZR X0oub7PdeVGsK4/zjyHpDRpMmljKkkiPgK5iq+qF0H5w/JQTUZVBbVZJdoOnyjCvRkJS VrS5j7x6v3Vqr5d5moYiXyGxLvZcfEkJDBFgT46OzC5MN5mTUaX+jWBhQ245JVWwcj6X Cin1QxDWfmmA4DA5Bf53ICvLxm0oILVrzNsiEAC1C25xMci0WvqovJtNPkN+NB5hwehV 7hZgnaYIUX1BHz+zg/3BWN5zVcgPo/dHiQjs3o/rrI/6jsPsjn6ilUkAEF6NqzKrECAR 1oSw== X-Gm-Message-State: AOAM533YX4hiobrxD9h5oCMR/la4iQjnhBl9H+m9q8Ofrj5aFDqsZ9k2 jKrOJPv7Tpkb9/wIFmYXB1oVeudatf/cOfbJWCSNv8K1aGYwtuSYDx+BHiCehA0URtFOlUVKnJi Jab8tFqEs7lQ= X-Received: by 2002:a05:600c:2159:: with SMTP id v25mr14011561wml.187.1628752374746; Thu, 12 Aug 2021 00:12:54 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwN8jmtH/cqMqGBW6lyfCsmyqhk628hKW3fRFyYAuqGvYPYW2AgLBL/d4G6Tz1Np7sZb4928g== X-Received: by 2002:a05:600c:2159:: with SMTP id v25mr14011529wml.187.1628752374538; Thu, 12 Aug 2021 00:12:54 -0700 (PDT) Received: from [192.168.3.132] (p4ff23d8b.dip0.t-ipconnect.de. [79.242.61.139]) by smtp.gmail.com with ESMTPSA id m39sm7731910wms.28.2021.08.12.00.12.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 Aug 2021 00:12:54 -0700 (PDT) Subject: Re: mmap denywrite mess (Was: [GIT PULL] overlayfs fixes for 5.14-rc6) To: Linus Torvalds Cc: Miklos Szeredi , =?UTF-8?Q?Christian_K=c3=b6nig?= , Matthew Wilcox , linux-mm , Linux Kernel Mailing List , linux-fsdevel , linux-unionfs@vger.kernel.org References: From: David Hildenbrand Organization: Red Hat Message-ID: Date: Thu, 12 Aug 2021 09:12:53 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ipTCpo3B; spf=none (imf04.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: BA8AF5001049 X-Stat-Signature: iy4ye77817zgec645ztu6xh3qd41g7wj X-HE-Tag: 1628752377-486820 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 11.08.21 18:20, Linus Torvalds wrote: > On Wed, Aug 11, 2021 at 4:45 AM David Hildenbrand wrote: >> >> I proposed a while ago to get rid of VM_DENYWRITE completely: >> >> https://lkml.kernel.org/r/20210423131640.20080-1-david@redhat.com >> >> I haven't looked how much it still applies to current upstream, but >> maybe that might help cleaning up that code. > > I like it. > > I agree that we could - and probably should - just do it this way. > > We don't expose MAP_DENYWRITE to user space any more - and the old > legacy library loading code certainly isn't worth it - and so > effectively the only way to set it is with execve(). > > And yes, it gets rid of all the silly games with the per-mapping flags. I'll rebase, retest and resend, putting you on cc. Then we can discuss if/how/when we might want to go that path. -- Thanks, David / dhildenb