From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01EF9C6FD1F for ; Fri, 29 Mar 2024 06:59:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 852E96B0092; Fri, 29 Mar 2024 02:59:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8030A6B0093; Fri, 29 Mar 2024 02:59:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6F1A66B0095; Fri, 29 Mar 2024 02:59:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 587206B0092 for ; Fri, 29 Mar 2024 02:59:48 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 22029411A1 for ; Fri, 29 Mar 2024 06:59:48 +0000 (UTC) X-FDA: 81949176456.14.601FA84 Received: from out30-99.freemail.mail.aliyun.com (out30-99.freemail.mail.aliyun.com [115.124.30.99]) by imf17.hostedemail.com (Postfix) with ESMTP id 191CE40010 for ; Fri, 29 Mar 2024 06:59:45 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=fTOUGTCQ; dmarc=pass (policy=none) header.from=linux.alibaba.com; spf=pass (imf17.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.99 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711695586; a=rsa-sha256; cv=none; b=JsmRM7AYHUNxQtbG5ELyvtah/YKERntNX6MKLJPsYRnTOiDtuRWD7k6YAIdFnJdSV+Fsvd Bx0kBlZt5uxGv7qQOqf480ADJoPtKaZhBjAak3sj+TaMzAcRi6Xc/6WxRlMQkgeIQTaRod IUYo5ifPpYrKpA4vjK60uVncsisXfJA= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=fTOUGTCQ; dmarc=pass (policy=none) header.from=linux.alibaba.com; spf=pass (imf17.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.99 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711695586; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=+X5dDvewMP3Tm1C12o/ZlZF+7bV0b6t6gUSDEC10khs=; b=LPF+YaNYL4HHwLaV6IgD3Q3DcrUKIE61qMw7AoQVXGOU/py9vmY9GK/2644ojQFq/oMlE1 Stg30Yz/9k9PP9gSBStVSwpVoEIZvZ/UMC9vWapY/mBENsrOhiF4z2gv/mngSYDpD/eO2A ifECf0LnSPiqq5QJx4/Z9ZWBd890gF8= DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1711695583; h=From:To:Subject:Date:Message-Id:MIME-Version; bh=+X5dDvewMP3Tm1C12o/ZlZF+7bV0b6t6gUSDEC10khs=; b=fTOUGTCQE3bN2OB3zN8m2guHWxFqAN6EHQJulzemav+T4I5/vtEnHISWBOylp7KYYBBuclBpmZxTl4KUnMq4fCsAxdJEcg4hkH26JJSHB/+3LeI1OzRXGP57CShIQ6F0pJBePplyfvoVEg2Hsr/LYLkpodaYVGS279GyjL0NQ3E= X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R111e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046050;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=4;SR=0;TI=SMTPD_---0W3Vft4F_1711695582; Received: from localhost(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0W3Vft4F_1711695582) by smtp.aliyun-inc.com; Fri, 29 Mar 2024 14:59:42 +0800 From: Baolin Wang To: akpm@linux-foundation.org Cc: baolin.wang@linux.alibaba.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH] mm: huge_memory: add the missing folio_test_pmd_mappable() for THP split statistics Date: Fri, 29 Mar 2024 14:59:33 +0800 Message-Id: X-Mailer: git-send-email 2.39.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 191CE40010 X-Stat-Signature: 3ojy5anz4mwj9517p4bch9mrtc8qd1uu X-HE-Tag: 1711695585-8527 X-HE-Meta: U2FsdGVkX18PsMEMQPWjXuQRP4gs54EGNAf4sVDJ8RAA1HmC65nQVrkc/+zepErAEXmF790C/TDAt4qaDBTuiOIuLvj8DnXYRl9fmWaqcgyVkJ90etUbGP5uj9F7Ckd83LEzZMKKyv+vk/U7+ES1mkWaW7HjWmVt0T2Y+D8ycEL4LG6uWKT3KPRwRozsVL978P5z2kDHeBWj31suyZaI7ShMA+0dmmeaLRT6/zpyqZIPmmODRpj4mQ/pDR4YCY5n00dLvHkVMY2irrQhLzFGKU8ZHJUYBvDKs7O/F0Np3154xQDQqflWDVN7Fa9DZaQx2DBQnfCxv39BMGfIT77YLmEeZ/ZH1mBHM1bjOteF84M52+aDK2OJyxV2QG7WAEqPC/cDc7/m1YLh5jNeMVsZ0zygxT8kpsdZIJbuIS1ltBjvGuHduCx87MvOotGw7Ibg9yRkvOPmy46B7lqKGgVvNXP+5TH6i5jZz2AgqABXgYj3fHvPsHlKkVsfGcBwHTCitKyc1TBEUfuqOgx0j6F7etSaFK11NMVt+zS+A0E6rN/yyjEDCnpKhVIsYjU0uX8xtqPHf9VSXiwZSjuFcUKj4WRRE0YFs6MINEY8LYkzIa4ShKR3POX1Rl3RwlAFNg93kAHT0UNC7U04nNdx9Q6DpMCan6LrHBTkIuLrfyIISyb76yLyMk5FqJ0TwUTlJKczZ4vMLjDFTo0+zNwLiJGDJFH9EkfLHPhVT8Aus9T69DhgFh/NtxTIXI5xwymXpt8CIx5+4XYl72W4KdNbRXMWdc6xv4OMzyi9J9OpUwnFRcmQOmdfi5aUU19b9LHRtm+id4kKZe9f2Ms9E8C9pJBo8UTVfvqEMotu0Axe0Mwxoa4RNI9KUiRjNnGBWfsYWS9iV3FGoIWfHReNoS8P2zZVn1YJKnfinFXtWr/9XmPQ8KQzscJtUuXj9Extoj2mEefdeuNlEU+5BrowFSupupS wtN9FDi/ NqwsEXD4IvPg+aIq2Cp2b8Wba7dP82qBrmsuv5lyScwhdjkUNA6TvRXjbF/SWkwLSmup5O6bcaRSkc5wX8FzInCuQaLUci3uTk1LbgGcVejxLXpprBYHdI3dH/4yG4+WvLpR9MgY2Yso6BEOGvkKjcX87jjFQ0IJ/VE0JM5zA8oUjJ3LehHaXBT0db5Kh98tWB5tdscJ8ZI3URB7SlnQ3vDl2qICnqrh6DAhxbIuW04jQ+c8ePAsVntVY6NMLXy8GTI2XYeJaqO8jcgocDwdK7t1XAYmhxnbJu5g9 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Now the mTHP can also be split or added into the deferred list, so add folio_test_pmd_mappable() validation for PMD mapped THP, to avoid confusion with PMD mapped THP related statistics. Signed-off-by: Baolin Wang --- mm/huge_memory.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/mm/huge_memory.c b/mm/huge_memory.c index 1683de78c313..3ca9282a0dc9 100644 --- a/mm/huge_memory.c +++ b/mm/huge_memory.c @@ -3109,7 +3109,8 @@ int split_huge_page_to_list_to_order(struct page *page, struct list_head *list, i_mmap_unlock_read(mapping); out: xas_destroy(&xas); - count_vm_event(!ret ? THP_SPLIT_PAGE : THP_SPLIT_PAGE_FAILED); + if (folio_test_pmd_mappable(folio)) + count_vm_event(!ret ? THP_SPLIT_PAGE : THP_SPLIT_PAGE_FAILED); return ret; } @@ -3171,7 +3172,8 @@ void deferred_split_folio(struct folio *folio) spin_lock_irqsave(&ds_queue->split_queue_lock, flags); if (list_empty(&folio->_deferred_list)) { - count_vm_event(THP_DEFERRED_SPLIT_PAGE); + if (folio_test_pmd_mappable(folio)) + count_vm_event(THP_DEFERRED_SPLIT_PAGE); list_add_tail(&folio->_deferred_list, &ds_queue->split_queue); ds_queue->split_queue_len++; #ifdef CONFIG_MEMCG -- 2.39.3