From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0568AC48BEF for ; Thu, 15 Feb 2024 10:43:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 951BE8D001B; Thu, 15 Feb 2024 05:43:22 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 901D58D000E; Thu, 15 Feb 2024 05:43:22 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7C9AC8D001B; Thu, 15 Feb 2024 05:43:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 6C4B78D000E for ; Thu, 15 Feb 2024 05:43:22 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 4DAB6A275E for ; Thu, 15 Feb 2024 10:43:22 +0000 (UTC) X-FDA: 81793701444.26.F30045E Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf14.hostedemail.com (Postfix) with ESMTP id C0BD110001D for ; Thu, 15 Feb 2024 10:43:18 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=KI35Qn12; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=KQCiYYIe; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=KI35Qn12; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=KQCiYYIe; dmarc=none; spf=pass (imf14.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707993799; a=rsa-sha256; cv=none; b=qDNjwCiBAeaTOULik/4dFzQEx+OHqenLXFyk0zeLu7hgjrBqGFnjTYY990KYIY0e94hmBY v9wX0u3kB4uAQEBnX9OXhij5JUf2r9TpcsPa9Ta/3omBvnxCYMHhyp04p5LFQ6UDgWWKfy r0hL4RNCY3ABJGsUEwcfHp052JXAlCY= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=KI35Qn12; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=KQCiYYIe; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=KI35Qn12; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=KQCiYYIe; dmarc=none; spf=pass (imf14.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707993799; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=288n+FGoThYvjHnUnq89Nh/a/z6Cws0UYcrsQ/yco4Q=; b=pTAQMC3QzqFuzhg6pMab9TqpGxrwaFKgeXHTYCEHiWiCwGc65IzRwJqCUS7dEg2kQxaQkE QLvV9QSdMF1w8rx4LaNqxkU2bhvydSxKZ1bL2oGuGp2ixY8l9MYdZkn6AnpOUiOD5onRl6 bk8ffyRNyCWzPt6ZQvHjQNQfeHwIevQ= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 84EE51F88B; Thu, 15 Feb 2024 10:43:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1707993796; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=288n+FGoThYvjHnUnq89Nh/a/z6Cws0UYcrsQ/yco4Q=; b=KI35Qn12481Ln2ZZewWVpteK+lENtR7HPTOvfza89bRj6j53RQX9gYenYbtICoge+38xZL hK4VHT0LebTZFw+9i9B9HBaSg8DwPyUCWdNsx+2gftIp1Li0Ol3HbANb1LJSvOE8TyBQpq HnE8KTLqXTc2Y9PNmtouYP1b1/nWU3s= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1707993796; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=288n+FGoThYvjHnUnq89Nh/a/z6Cws0UYcrsQ/yco4Q=; b=KQCiYYIeIn7g+piswyKNBgJa6zCseAbyyqGnxoPfw+mpeWbD0So/Ul19mqgWiS49p37Sgc c4C3CUhLOUXCt7Cw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1707993796; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=288n+FGoThYvjHnUnq89Nh/a/z6Cws0UYcrsQ/yco4Q=; b=KI35Qn12481Ln2ZZewWVpteK+lENtR7HPTOvfza89bRj6j53RQX9gYenYbtICoge+38xZL hK4VHT0LebTZFw+9i9B9HBaSg8DwPyUCWdNsx+2gftIp1Li0Ol3HbANb1LJSvOE8TyBQpq HnE8KTLqXTc2Y9PNmtouYP1b1/nWU3s= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1707993796; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=288n+FGoThYvjHnUnq89Nh/a/z6Cws0UYcrsQ/yco4Q=; b=KQCiYYIeIn7g+piswyKNBgJa6zCseAbyyqGnxoPfw+mpeWbD0So/Ul19mqgWiS49p37Sgc c4C3CUhLOUXCt7Cw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 6D0D713A53; Thu, 15 Feb 2024 10:43:16 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id xmfcGcTqzWW9LQAAD6G6ig (envelope-from ); Thu, 15 Feb 2024 10:43:16 +0000 Message-ID: Date: Thu, 15 Feb 2024 11:43:16 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v9 2/7] lib/stackdepot: Move stack_record struct definition into the header Content-Language: en-US To: Marco Elver Cc: Oscar Salvador , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Michal Hocko , Andrey Konovalov , Alexander Potapenko References: <20240214170157.17530-1-osalvador@suse.de> <20240214170157.17530-3-osalvador@suse.de> From: Vlastimil Babka In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: C0BD110001D X-Stat-Signature: hdj19mp9e14bd99sc7zb1dns5mx8bfwg X-HE-Tag: 1707993798-367822 X-HE-Meta: U2FsdGVkX19s6T9/iH6KlwjsjgR+cATqykvkuh6TNeFqUmCbdD8t6Mb7KBcPkH6H4+9auK7UU3++oqyJubYdFhiItyXgItEtZ2Oe+bfgr+ONEf0nG7k7sIVePFH1/A+0wb2Dn5DSLp+s7FG96QMaRIKaiAjRljYFhOmfWLlXo8fYnBBI4vt2PAYiYI2jc5QoUvi5zim3l5jIEoH5RTK0+WM8qywJyAFqLm8sYXZLGVxgCczA8KCHQS1vhHcGeR1XqgFPjF8+ewSEejIwvYi29PCCvwYYjzb76uY4GIlUR9NwSvU3SS0pORnMki9CNZ8157g2t6C/xIqlAu1omlImtE1xBLU2sxWCxlboLNyKFuahLLl5FZthSZVx6eI9UCynlwZLXZlu1P7hKAygoEzEIbBhnTZKHPG6XCretcXwz6fkYvDD85zALSGv9tQx1KjiDuCdqGwO0/fpNM3J+XfrF/xx49ic1tvmd4NFESaz56OI2MmZIPaerStvPseLXiJlns2rPaTCMg5gYsPH8SekBkul2yjnyRLwB8UZuuYGmmKqxiOClnXRNzA4nEWZaK3kYrhi01EFtPNpx1r1DxoN9llXFplCIRy7H+HvVXgYdG4N7GZRkSagbXDIGs/q2Lx53VG/pIFNbkGpTOQuk5sYbwxxr9kgCL/QZUn0DeadMvLyT4e7xAu8rPN64oQwVxH7dVLrXLkW6b9jXCReec65QwLNiI4yOySEcAvinQWdVqBoluVgpIVazJKDSDtUamY9dj3FA1LdwXV4Xt8Xc7bKLG/LFlZiQHxFG3eHk/IrZ/mbWu79HWrzuim1mIwnJIaRSX5ZIVRZ/mWdAgCxuHMVb9QjdY5OFJwzk/6Kpfb6R/oSyafeUEApLR3qSvqtwA+s8ET+J6aU5JMxBKzd8nrNJ5dCEMEqZWJIMonBUinX1w49GPgExLn6BUsWUrys9HsCxf3zAfh20eJXQv6lM9O wrz75h++ bTPY2QMNmMI7CgqTBUrCkAc40PKijswNtDzQmH2ENJb8DVKu6Zjbhm1pYwscMGA9izoj+aRpu7ANqmrQP3NjkcZ6ON2deEwXrOnCF6Gsr8h1UpNNLdynq1D7gMXLg+ULZi4VAd4LYLc+xzb2uDhoUGBF/MnUVBdfTDtp9uvtmivCqw4pQlkpUOoGWnzGr1A8YSH3fr6rjkiQ7bTulEF6EVDOdh+sh7vIUhj3usqXaJJvKCo2iX76PKtbwA8ysZgvlD2tqHincOSaJno4RxfDLcSPN2Y+soT9rBNlmr/PVpYM0NQ+kL++pfr8TbEcuWQ9KVC1nh3HqKSoCV3Czf3BrIjatSbaDW9HTcZnug5wPr/ousWUdA9J1EYMJxA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2/15/24 10:33, Marco Elver wrote: > On Thu, 15 Feb 2024 at 10:30, Vlastimil Babka wrote: >> >> On 2/15/24 09:16, Marco Elver wrote: >> > On Wed, 14 Feb 2024 at 18:00, Oscar Salvador wrote: >> >> >> >> In order to move the heavy lifting into page_owner code, this one >> >> needs to have access to the stack_record structure, which right now >> >> sits in lib/stackdepot.c. >> >> Move it to the stackdepot.h header so page_owner can access >> >> stack_record's struct fields. >> >> >> >> Signed-off-by: Oscar Salvador >> >> Reviewed-by: Marco Elver >> >> Reviewed-by: Vlastimil Babka >> >> --- >> >> >> #define DEPOT_POOLS_CAP 8192 >> >> -/* The pool_index is offset by 1 so the first record does not have a 0 handle. */ >> >> +/* The pool_index is offset by 1 so the first record does not have a 0 handle */ >> > >> > Why this comment change? We lost the '.' -- for future reference, it'd >> > be good to ensure unnecessary changes don't creep into the diff. This >> > is just nitpicking, >> >> Agree with this part. >> >> > and I've already reviewed this change, so no need >> > to send a v+1. >> >> But confused by this remark. There is a number of nontrivial changes in the >> series from v8, and IIRC v8 was dropped from mm/ meanwhile, so a v+1 of the >> whole series is expected and not fixups. Which means including patches that >> were already reviewed. That's the usual process. > > This is already v9. Of course, still need to look at rest of v9 and if > there are major changes needed then a v10 is needed. Ah sorry I misunderstood you completely. What you meant v10 isn't needed for the missing "." and I thought you were saying v9 already wasn't needed (for this particular patch).