From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE03DCF9C6F for ; Tue, 24 Sep 2024 14:16:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 66B3B6B009E; Tue, 24 Sep 2024 10:16:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5CC626B00A0; Tue, 24 Sep 2024 10:16:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3F97E6B00A6; Tue, 24 Sep 2024 10:16:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 1CC2E6B009E for ; Tue, 24 Sep 2024 10:16:29 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 8ABF8121A42 for ; Tue, 24 Sep 2024 14:16:28 +0000 (UTC) X-FDA: 82599832056.01.26FC577 Received: from mail-pg1-f181.google.com (mail-pg1-f181.google.com [209.85.215.181]) by imf03.hostedemail.com (Postfix) with ESMTP id 5CC8E2002B for ; Tue, 24 Sep 2024 14:16:26 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=coUItqkW; spf=pass (imf03.hostedemail.com: domain of groeck7@gmail.com designates 209.85.215.181 as permitted sender) smtp.mailfrom=groeck7@gmail.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727187351; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1GgB+hTZpTml0qKRANWfPlHVjU+0Wqbyo4s8XQzdZho=; b=YDwnO1E3hfur3ev6CFzNEijS87BXbhWiz4gRhC5bBs+/w+MBcD3ACGRg28x0s6o6opN5Or g0gDXIJRjdG4FUesiK6Q8PT32bAMEXtEfo3itdX5L0bU3mlGBLxAY2gb9e6KSQq+uLKB0X 7uXPc8jtSHloClukqCqKLie1+RR9sb8= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=coUItqkW; spf=pass (imf03.hostedemail.com: domain of groeck7@gmail.com designates 209.85.215.181 as permitted sender) smtp.mailfrom=groeck7@gmail.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727187351; a=rsa-sha256; cv=none; b=cU1HJJcrtyRlKsN7ShXDsZhUyyVKtztD85Es4QlXIHL5aNh/aU3lxE2/u2FKxlwv1zh20T MXt/peRvgrz79kPocj97dJ3aO5WP/vs40HjEiJB4jvt+sCkUXbX2e23tesYkaqpSllPS/n zKp74sYCZ/QTsXktyqh8wSgYjBtakBE= Received: by mail-pg1-f181.google.com with SMTP id 41be03b00d2f7-7d666fb3fb9so2726313a12.0 for ; Tue, 24 Sep 2024 07:16:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727187385; x=1727792185; darn=kvack.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:from:to:cc:subject:date:message-id:reply-to; bh=1GgB+hTZpTml0qKRANWfPlHVjU+0Wqbyo4s8XQzdZho=; b=coUItqkWg+ZXk1OFdFpZy9kA783mms9DA1KyumJHZ9VwmvNag0Sz8S3gCKCGyaQ6WV PKTkCu9ynylNeeQ7XplUL/un4hCahQAmTAUtX49gf+dI+qxEkx7WeE4GHfv4qk6DBuQg tdoDYM3g67OpuQDHJt5BOhdJkVuja5TMRRE3Nwm8DfcngtJouwbg+u7bFgj7dETF1Eq7 ZgxvcfvR+1VvyaE9xOYxRzmKXSq7OENBUxhPJlP6H4riOne2VQM6BRoMi4NphF8H406C zrMtNzfaNgZ48/H2HggrKYPFatKF7wx/BoRFTtskBlFRtaQBTu3EMsutGCmD1+Os333u FKIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727187385; x=1727792185; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=1GgB+hTZpTml0qKRANWfPlHVjU+0Wqbyo4s8XQzdZho=; b=ZpG6CKBq1sHpAq2wj7MRNUdEiMhYOXM14yN+fz1rKnonoxPz0+DwX0eR+8+SWFokKF AMAvo6PnzvQ6KC7C8PNC2HnqK5qJ6MEpEwU0QOnswa9vzDc8qyZEFe62HxQ/Viu9fhSq kk3wpiK52hAHNTpvWQ9pLuPKgyHutVhEyCDz3CZzBYD5iraad5OcGHjAXgTuAvXKVT89 kETtsJqJUSJ6h2AiSzPJythuwKtVay69ESNxP4ggcDSxSs/KcVq8DLQjnzUPVCr0g2zP q32zFGifI4dg6Iqf/v9z2hMRXX7ZaaXZKzgHIfu7n8IfYgV0XmLfoNy/MrjYCO3d9/L0 z9kg== X-Forwarded-Encrypted: i=1; AJvYcCVXYy5ptDDaH9A95cRmm/bxngSuqYH7buwKMc2hrghkeYyTYcVMdi83h48zr83ZKFOek4nQJmgesg==@kvack.org X-Gm-Message-State: AOJu0YxRjEzaH+6xJC9qRYThFavmq4e/uZ/b/8QM+MpHsXKZCAhnV7/l 9NeIegumGjny33aLUA1yMB72ugu66RQ86CowEvz9I9f8g7cFNcgw X-Google-Smtp-Source: AGHT+IGq1CKWT/TJzAVM3mHN2JVIpOfn5RlMWqMypCAOXz7pPMKpwFQ5Hpr7sz8VVE1ZSn5aa2aKpw== X-Received: by 2002:a05:6300:668b:b0:1d2:e793:cc0 with SMTP id adf61e73a8af0-1d343c19cbdmr5082360637.7.1727187384932; Tue, 24 Sep 2024 07:16:24 -0700 (PDT) Received: from ?IPV6:2600:1700:e321:62f0:329c:23ff:fee3:9d7c? ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71afc835402sm1251416b3a.44.2024.09.24.07.16.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 Sep 2024 07:16:24 -0700 (PDT) Message-ID: Date: Tue, 24 Sep 2024 07:16:22 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: Make SPLIT_PTE_PTLOCKS depend on the existence of NR_CPUS To: Geert Uytterhoeven Cc: David Hildenbrand , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Masahiro Yamada , linux-kbuild References: <20240923142533.1197982-1-linux@roeck-us.net> <4c2cdf84-9794-4722-8417-cf924f890797@roeck-us.net> <203f0d01-d25e-4436-b769-b89edb1b57d9@roeck-us.net> Content-Language: en-US From: Guenter Roeck Autocrypt: addr=linux@roeck-us.net; keydata= xsFNBE6H1WcBEACu6jIcw5kZ5dGeJ7E7B2uweQR/4FGxH10/H1O1+ApmcQ9i87XdZQiB9cpN RYHA7RCEK2dh6dDccykQk3bC90xXMPg+O3R+C/SkwcnUak1UZaeK/SwQbq/t0tkMzYDRxfJ7 nyFiKxUehbNF3r9qlJgPqONwX5vJy4/GvDHdddSCxV41P/ejsZ8PykxyJs98UWhF54tGRWFl 7i1xvaDB9lN5WTLRKSO7wICuLiSz5WZHXMkyF4d+/O5ll7yz/o/JxK5vO/sduYDIlFTvBZDh gzaEtNf5tQjsjG4io8E0Yq0ViobLkS2RTNZT8ICq/Jmvl0SpbHRvYwa2DhNsK0YjHFQBB0FX IdhdUEzNefcNcYvqigJpdICoP2e4yJSyflHFO4dr0OrdnGLe1Zi/8Xo/2+M1dSSEt196rXaC kwu2KgIgmkRBb3cp2vIBBIIowU8W3qC1+w+RdMUrZxKGWJ3juwcgveJlzMpMZNyM1jobSXZ0 VHGMNJ3MwXlrEFPXaYJgibcg6brM6wGfX/LBvc/haWw4yO24lT5eitm4UBdIy9pKkKmHHh7s jfZJkB5fWKVdoCv/omy6UyH6ykLOPFugl+hVL2Prf8xrXuZe1CMS7ID9Lc8FaL1ROIN/W8Vk BIsJMaWOhks//7d92Uf3EArDlDShwR2+D+AMon8NULuLBHiEUQARAQABzTJHdWVudGVyIFJv ZWNrIChMaW51eCBhY2NvdW50KSA8bGludXhAcm9lY2stdXMubmV0PsLBgQQTAQIAKwIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4ACGQEFAlVcphcFCRmg06EACgkQyx8mb86fmYFg0RAA nzXJzuPkLJaOmSIzPAqqnutACchT/meCOgMEpS5oLf6xn5ySZkl23OxuhpMZTVX+49c9pvBx hpvl5bCWFu5qC1jC2eWRYU+aZZE4sxMaAGeWenQJsiG9lP8wkfCJP3ockNu0ZXXAXwIbY1O1 c+l11zQkZw89zNgWgKobKzrDMBFOYtAh0pAInZ9TSn7oA4Ctejouo5wUugmk8MrDtUVXmEA9 7f9fgKYSwl/H7dfKKsS1bDOpyJlqhEAH94BHJdK/b1tzwJCFAXFhMlmlbYEk8kWjcxQgDWMu GAthQzSuAyhqyZwFcOlMCNbAcTSQawSo3B9yM9mHJne5RrAbVz4TWLnEaX8gA5xK3uCNCeyI sqYuzA4OzcMwnnTASvzsGZoYHTFP3DQwf2nzxD6yBGCfwNGIYfS0i8YN8XcBgEcDFMWpOQhT Pu3HeztMnF3HXrc0t7e5rDW9zCh3k2PA6D2NV4fews9KDFhLlTfCVzf0PS1dRVVWM+4jVl6l HRIAgWp+2/f8dx5vPc4Ycp4IsZN0l1h9uT7qm1KTwz+sSl1zOqKD/BpfGNZfLRRxrXthvvY8 BltcuZ4+PGFTcRkMytUbMDFMF9Cjd2W9dXD35PEtvj8wnEyzIos8bbgtLrGTv/SYhmPpahJA l8hPhYvmAvpOmusUUyB30StsHIU2LLccUPPOwU0ETofVZwEQALlLbQeBDTDbwQYrj0gbx3bq 7kpKABxN2MqeuqGr02DpS9883d/t7ontxasXoEz2GTioevvRmllJlPQERVxM8gQoNg22twF7 pB/zsrIjxkE9heE4wYfN1AyzT+AxgYN6f8hVQ7Nrc9XgZZe+8IkuW/Nf64KzNJXnSH4u6nJM J2+Dt274YoFcXR1nG76Q259mKwzbCukKbd6piL+VsT/qBrLhZe9Ivbjq5WMdkQKnP7gYKCAi pNVJC4enWfivZsYupMd9qn7Uv/oCZDYoBTdMSBUblaLMwlcjnPpOYK5rfHvC4opxl+P/Vzyz 6WC2TLkPtKvYvXmdsI6rnEI4Uucg0Au/Ulg7aqqKhzGPIbVaL+U0Wk82nz6hz+WP2ggTrY1w ZlPlRt8WM9w6WfLf2j+PuGklj37m+KvaOEfLsF1v464dSpy1tQVHhhp8LFTxh/6RWkRIR2uF I4v3Xu/k5D0LhaZHpQ4C+xKsQxpTGuYh2tnRaRL14YMW1dlI3HfeB2gj7Yc8XdHh9vkpPyuT nY/ZsFbnvBtiw7GchKKri2gDhRb2QNNDyBnQn5mRFw7CyuFclAksOdV/sdpQnYlYcRQWOUGY HhQ5eqTRZjm9z+qQe/T0HQpmiPTqQcIaG/edgKVTUjITfA7AJMKLQHgp04Vylb+G6jocnQQX JqvvP09whbqrABEBAAHCwWUEGAECAA8CGwwFAlVcpi8FCRmg08MACgkQyx8mb86fmYHNRQ/+ J0OZsBYP4leJvQF8lx9zif+v4ZY/6C9tTcUv/KNAE5leyrD4IKbnV4PnbrVhjq861it/zRQW cFpWQszZyWRwNPWUUz7ejmm9lAwPbr8xWT4qMSA43VKQ7ZCeTQJ4TC8kjqtcbw41SjkjrcTG wF52zFO4bOWyovVAPncvV9eGA/vtnd3xEZXQiSt91kBSqK28yjxAqK/c3G6i7IX2rg6pzgqh hiH3/1qM2M/LSuqAv0Rwrt/k+pZXE+B4Ud42hwmMr0TfhNxG+X7YKvjKC+SjPjqp0CaztQ0H nsDLSLElVROxCd9m8CAUuHplgmR3seYCOrT4jriMFBtKNPtj2EE4DNV4s7k0Zy+6iRQ8G8ng QjsSqYJx8iAR8JRB7Gm2rQOMv8lSRdjva++GT0VLXtHULdlzg8VjDnFZ3lfz5PWEOeIMk7Rj trjv82EZtrhLuLjHRCaG50OOm0hwPSk1J64R8O3HjSLdertmw7eyAYOo4RuWJguYMg5DRnBk WkRwrSuCn7UG+qVWZeKEsFKFOkynOs3pVbcbq1pxbhk3TRWCGRU5JolI4ohy/7JV1TVbjiDI HP/aVnm6NC8of26P40Pg8EdAhajZnHHjA7FrJXsy3cyIGqvg9os4rNkUWmrCfLLsZDHD8FnU mDW4+i+XlNFUPUYMrIKi9joBhu18ssf5i5Q= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Stat-Signature: 8comd4uam6kezeexbd8bwn53kj9mt16j X-Rspamd-Queue-Id: 5CC8E2002B X-Rspamd-Server: rspam11 X-HE-Tag: 1727187386-847965 X-HE-Meta: U2FsdGVkX19JTvbN8vJdTswwCpVYGJmPX1AGoTl9q07YHKfbvLF1BHJwNOqJnCKyz5OMPHy7CBmEKnbja944OrVuYdFsyplx9GPt+FPK44PzH2yvoG6h+dkc8J3fBxbKoLXj97613btrCaXyeGr2f9vK3m8/67sMi96zoRPCYlS+E1w6tV0S1CvRhQujavJ355ZT09Jxq+cBRPKSDtZVlE5u52Z/CPpGObgeuRaZQKKjmS1KXLpYrZV2S0gmsVEsZy5U7r+AYoOxCAgz8zPKdzYPfP/gZ/v+gqYq4de5h9wFkEAkfOyGDL0mhu2Ilq1nBXBKFQQ5nPxV8zPpUecPhFHkqdHUZOqbVCRkLouehwIeDrJK6wqs5H/6K83L7JL7Nz8h39uc+v5yjPOOW0L3Md2iryAzigTUsVfShFkky9O94Nc+6R9s3WyQ+7VbqYOv3Pr5WFabjtlVgOLSrdtJP3f4Jeq1fW/coueMUMfLCuLHnjU646Jc7lDQB8/LKTGKSvql5nfXhrxVYo3MbOrzZMuF/ZCQq25M7eENL+C8CibtccsW2qgTlzOdpEvZ17zyMabQu3vA3usxdKb19V8vAW/l77LBEBupqpHV0fjVcQ+gN9x/6cj0EVWZq0odIUNu155cYZ+NJIMKSQ5nu/XBlEqWhBs9MR2afDntMgrhxDmAcbldDW40243J0SNIrOUV0bYFiKIOOYy54eF2kEXWA66XcwTxfDqB09JW1GVPdZx17e5bkQ99orSijnqwZx1W7CQJ3eshMIGU8Z6AT49TzESkp/NmOV/ziWFz7zbT7HTwai6oZr7YGUuSR6EdSbtg8kU5Kl04VnNWO1IySV5kd4WXXACsqWy2yYpaU+O9Fnm5Jz+kniu1i+eWSvgXbwYnBDmgWrA4Eq4kHzx8mKzFzMCfWG+wXm7VbBaWVqG+aEyRS1PHve+X7X11LBKaKIn5Cj7TFItkepWSNqaS/Sx VNmHxjNV PTZzoA6+tBVIBar0UVtv+UqpxRbCDRGp0vSZONvnhasu279UBn9Fr+hJoKSN5oFZ8A6JMzobydiXr+4czuZUPhqvYBBRSv2LaZKbXxQsmwv4j/0ZhnHmXvXK5mkdlKLukGLMT/ANXNZ5yOylUHgn68Y6Hees/v95jWeGsCC1/rosvUjeX2TRTZqFRl5SGZj7fv0Tx34zT+f5+TTb6X0F1Kp4Jmm+kJMBCQQKrbYbFA/xMmRZBXkwjJPnS0jzAkx+QKOa3BAvo3jceBzyRVx75e+ndirS5TDjxU6PgMpGs3ThnhIGZtA2M4NVqYXL2uxpiQWYN7iUaU6/7VdZfWQugqMEthmyB7n0RE6cwNRQa9vSqbruwLEHoCDc3cetH/0QUC+2xu1uruILjjcbWZYOJVJfLFkQrsZklR7Pu4Vs1ZqI5I7V2fqgj5zSdYw8PoAHvA5MIUjs/Q7CZXgpk9ApyvlCXlH8CFFr2dtXGJJxlreYrmWHlkWWYtnskIKOTjkeBIisJuWywXu8ZE5t0RBB7oThyRVipZBJJ2C9raadDoWtaiKE5KDhzmdUC/EarB8kL0ztQ6Vc0HzQKvJH8yod1aP837mAVT4fHzgJvuKEYM1himl0mwvkGQjRiqg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 9/24/24 00:45, Geert Uytterhoeven wrote: > Hi Günter, > > CC kbuild > > I have two comments... > > On Tue, Sep 24, 2024 at 1:52 AM Guenter Roeck wrote: >> On 9/23/24 15:08, Guenter Roeck wrote: >>> On 9/23/24 08:23, David Hildenbrand wrote: >>>> On 23.09.24 16:25, Guenter Roeck wrote: >>>>> SPLIT_PTE_PTLOCKS already depends on "NR_CPUS >= 4", but that evaluates >>>>> to true if there is no NR_CPUS configuration option (such as for m68k). >>>>> This results in CONFIG_SPLIT_PTE_PTLOCKS=y for mac_defconfig. >>>>> This in turn causes the m68k "q800" machine to crash in qemu. > > Should this be fixed in Kconfig (too)? > I don't know. I thought that was intentional, though I don't understand the logic. I didn't find a documentation that would explain how boolean dependencies of integer objects are supposed to be handled. My expectation that it would be similar to C was obviously wrong. >>>> Oh, that's why my compile tests still worked ... I even removed the additional NR_CPUS check, assuming it's not required ... >>>> >>>> Thanks for debugging and fixing! >>>> >>>> Acked-by: David Hildenbrand >>>> >>> >>> Apparently it wasn't that simple :-(. 0-day reports a build failure >>> with s390 builds. >>> >>> arch/s390/mm/gmap.c:357:16: error: implicit declaration of function 'pmd_pgtable_page'. >>> >>> Turns out that >>> depends on NR_CPUS && NR_CPUS >= 4 >>> >>> doesn't work and disables SPLIT_PTE_PTLOCKS even if NR_CPUS _is_ defined. >>> I have no idea how to declare the dependency correctly. >>> Sorry, I did not expect that. >> >> The only solution I found was to define NR_CPUS for m68k. That seems to be >> the only architecture not defining it, so hopefully that is an acceptable >> solution. I'll send v2 of the patch shortly. > > My first thought was to agree, as m68k is indeed the only architecture > that does not define NR_CPUS. Upon closer look, most architectures > have NR_CPUS depend on SMP, hence I assume the issue could happen for > those too (although I didn't manage to create such a config on anything > but m68k)? So the simple solution would be to add a dependency on > SMP to SPLIT_PTE_PTLOCKS. > Makes sense. I'll send v3. Guenter