From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7FEFC2BA1A for ; Tue, 18 Jun 2024 07:51:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1C72B8D001C; Tue, 18 Jun 2024 03:51:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 177648D0001; Tue, 18 Jun 2024 03:51:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 017528D001C; Tue, 18 Jun 2024 03:51:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id D775D8D0001 for ; Tue, 18 Jun 2024 03:51:45 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 5D3E540533 for ; Tue, 18 Jun 2024 07:51:45 +0000 (UTC) X-FDA: 82243240170.16.B890EC7 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf30.hostedemail.com (Postfix) with ESMTP id 2C79080016 for ; Tue, 18 Jun 2024 07:51:42 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=jPwUmpqr; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718697097; a=rsa-sha256; cv=none; b=auibTnDNSPZdhc1gGXZDDHQG1DT60ndnMoQRA5WAd8pRIqz5w6p4S7yG5sNa47WeAd6rVu IJYkftSrJn91P4iXj/cjXmrKMjGZeOkyozPm0h52UDsm9Vkm0HIhz5ta2e7wekzbC3CMgo 7U0KV4DSXjdhLi+3BRvMiBtKGNeWTvQ= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=jPwUmpqr; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718697097; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=s/nVv3dDmlRKY68OpAEs2dmM8DyIrPbKN2V9YXyzoWE=; b=jOSi5rbZg/h5hxZ5rfuTn4k+AVo+mmBaNe2kWTRXvdizNs97HbwOTYUpmoYAqwEeindMWe rjnOfvksrd3mQ56uTTE1jp/ibBIjyVg/QQiZHhQHWJASs1t6c2HDjVE0VLbk/Wkhsnl0Yt 6PyEp/AtLbr/U2AoxA8f8Ou7idRy5WY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1718697102; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=s/nVv3dDmlRKY68OpAEs2dmM8DyIrPbKN2V9YXyzoWE=; b=jPwUmpqrZVxcMCod9jq2/uIlB4F4Ec82fJkshYqzBwLFbReWL92DL8vZPJ9QrL5OrCiKdO HdiKQYMTWn8hKlZVnHXqzxxhdVtskk2/AQoI52AeCHMgPUcZi2Mufz1MR94h4dHdEH7YDn OX2Dv159+kYaOIFi1oyzBGAs0IjL7w4= Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-27-3xg2RcUGM4OQk1Xoow71bA-1; Tue, 18 Jun 2024 03:51:40 -0400 X-MC-Unique: 3xg2RcUGM4OQk1Xoow71bA-1 Received: by mail-lf1-f71.google.com with SMTP id 2adb3069b0e04-52bbd8ac2c1so3711429e87.3 for ; Tue, 18 Jun 2024 00:51:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718697099; x=1719301899; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=s/nVv3dDmlRKY68OpAEs2dmM8DyIrPbKN2V9YXyzoWE=; b=srOrpK9XjTueJeevvDLuy5mGN/Si4FGdqWyPDnS5+n5CTP1N7rjys1TtZVO+PALtM3 6KUtYCxK1tDBR0ckuLr5PdJ5B8uGMR1a5bMgyQgzSZLFj0IV/ebKRxSOLZ28ewzxit/1 zvoMKpLmTTcw/JT2KRgicfrjtKBCeuGYkCSv5bYBEclEL1/+LbIzhqp0qVOe2TzI7Gs8 zs0ylbMNQ/rjMBf/bR3s/zDcTE5zKGcYNWsKBK6ud4L6nv8/4L9pULbAdbAgMFZn9wIo lN5L7Eej99t/7LZFGttx7iQ1vSftyye79eLFh6nypmDgUo3GJ38tDoIdHHhJqm8dQQyk yrfg== X-Gm-Message-State: AOJu0YxGdgASqWIW/C3+6WEkdgRhFZydS9Z3fcu3i07LUpPFbylAG7Er LYL38Un9Lfp3X7dpWMY5pB1lGPtsaCURgSNNE60XwobWEdA2LSKrzfZyK50YI13maUb6L7hrWhF f06sF2MR8AM/t2O74SEsqQPV8A5zXF6p2D8k8dwnzIRNB2NUq X-Received: by 2002:a19:9141:0:b0:52c:81d5:cf96 with SMTP id 2adb3069b0e04-52ca6e659demr6314057e87.28.1718697099218; Tue, 18 Jun 2024 00:51:39 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEZsI3yL/RFW3dIzElj3g9Ju14EP/3lK6XgI0180cJFXdva3eYpvhA3tBmMjfh18A+a6MlGPA== X-Received: by 2002:a19:9141:0:b0:52c:81d5:cf96 with SMTP id 2adb3069b0e04-52ca6e659demr6314029e87.28.1718697097768; Tue, 18 Jun 2024 00:51:37 -0700 (PDT) Received: from ?IPV6:2003:cb:c705:1400:78ba:c2d2:22a1:8858? (p200300cbc705140078bac2d222a18858.dip0.t-ipconnect.de. [2003:cb:c705:1400:78ba:c2d2:22a1:8858]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3607509c8c2sm13515431f8f.31.2024.06.18.00.51.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Jun 2024 00:51:37 -0700 (PDT) Message-ID: Date: Tue, 18 Jun 2024 09:51:36 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: ksm: drop KSM_KMEM_CACHE() To: Kefeng Wang , Andrew Morton Cc: linux-mm@kvack.org References: <20240618081201.134985-1-wangkefeng.wang@huawei.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240618081201.134985-1-wangkefeng.wang@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 2C79080016 X-Stat-Signature: m14rew1zza9ws19dj595me6gsoud4o58 X-Rspam-User: X-HE-Tag: 1718697102-592974 X-HE-Meta: U2FsdGVkX1+VULUvybPaq1RbNWuPN4yr2MYfyNQwEDQ0F4G+Gg4eaaAIVam9+jjcvYebI/CGw5YWgHX1IBgRf2U4eJHBxOO8YOrYHMkqo/DpAD7G5H4yG4f38StCsN/PPsnB59hUyoZmEksO/JFbS4m+iu+ew8vnw1S9KF35IpUHkmqp+mfr1/VoD3vnXLKMl6cPedyWmyNgtxTvkCEtC4ec5JY1C+4pkhQ4MgXlQkUlysv4/JNcOrqRPmM6CbVZMSoBPSONMxHXByQkwEmTc1fZG7QZpDi1i9Q68SFc/uli9bQdA3og57NTroAQ9LEAAZeEfCZ8EpgavU1pD2b/S/7pkIzlkSRSL+tr5Y+pIpMPE/VognYTzz+DygEVwLjbTjBMRtsxpe2OvjDhUSSXkF295w9Rwg/PwrbhUVanxbZ2QVuDnR+su6PC6wp7tKGqGhrxARzRgiLPz0A3QZo3+7f1wxypHAuahR+/0C38UXnyJSj0rwlmn1h6cZbiyZ2KNEiP4RuZrFxNfd66WWp9WrkSII2lAm5wfYbKk8vWX9EqZ/mA6+6JO2apxBGd/dYkq3XkYa8KP0qBQiRkO245okdoe/VDm52JpVn0l0hi++OzjqBhZIHXpBfKoNZxAvAPgrj2YGu1mL11VyHhqR+7UmYiVHuPuoj/lm4WDkjad7ilPnQ1H2APNuV3ca7Ohr18f4fqxPLS/IshDyKhlmjlXlsnaD3na4VO4gfzGMZdtfEpuMOuwhI8wAh/qEkq4yFlb1N3Q6IHP1TtJ0pMoHY/7ok8RURExQFcQAnwL3+DqeXsHpnq2PVDwyYSDl4b9TwwvB4sR5595U1XLnffCY86joC0vLMZlON86fzYTAVjNgNHmiqxS84oBEYl/e84DAVM/k05czYfoERUfe9GWfiLmFJNJvr461X8bYUA2lBlZLFJ2gctCvwmObnERkgfMXmvYqtwnfODiSq9caKG2jv U6pB9ps6 m2VOqcOpK/GQCi7Ygx/taLRdcRfGhz/gyrwyEiBvi3oBlZ89MMDKepJsi36+JO8J7uUdpEUmJo8w301kMKuD12TYW+nzykrbTxmtIBqJQ4ufrtK9zEmthVqObHycyCFNzgxbsiGhDsKoNjpyq8XHm9XfsGU5X9KCxR69nZunBQG9Knk9V72XeIvCj1HzSnHELJdQhpvTrHUTvGvCF7BFWG32HHRaqXuKez3NAYnMKeiIkpbmWnm/1pBZzH77lLJtbZZetH2FqfpAZwIGGwhv7qdhRU18EEQKcpOw+hpdU7ExztJ99ZAjj3ee6D9nTCZUQcOtRtIjW+EKnkURfUhPKhGv0zORD+++oxSgzbqWDhPkwBPw/Y/AYpf5XPVA65lQnjcfmlEdVL+foKOqoFaax/JkjH+Mb4Tael2QlfTS5SDFmRFM32kvfK0Sw4dit4lp9pEyCohVEPKSerXL2XRpes4+CWA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 18.06.24 10:12, Kefeng Wang wrote: > After commit 21fbd59136e0 ("ksm: add the ksm prefix to the names of > the ksm private structures"), we could directly use KMEM_CACHE(). > > Signed-off-by: Kefeng Wang > --- > mm/ksm.c | 10 +++------- > 1 file changed, 3 insertions(+), 7 deletions(-) > > diff --git a/mm/ksm.c b/mm/ksm.c > index d2641bc2efc9..1f62797c9809 100644 > --- a/mm/ksm.c > +++ b/mm/ksm.c > @@ -488,21 +488,17 @@ static DECLARE_WAIT_QUEUE_HEAD(ksm_iter_wait); > static DEFINE_MUTEX(ksm_thread_mutex); > static DEFINE_SPINLOCK(ksm_mmlist_lock); > > -#define KSM_KMEM_CACHE(__struct, __flags) kmem_cache_create(#__struct,\ > - sizeof(struct __struct), __alignof__(struct __struct),\ > - (__flags), NULL) > - > static int __init ksm_slab_init(void) > { > - rmap_item_cache = KSM_KMEM_CACHE(ksm_rmap_item, 0); > + rmap_item_cache = KMEM_CACHE(ksm_rmap_item, 0); > if (!rmap_item_cache) > goto out; > > - stable_node_cache = KSM_KMEM_CACHE(ksm_stable_node, 0); > + stable_node_cache = KMEM_CACHE(ksm_stable_node, 0); > if (!stable_node_cache) > goto out_free1; > > - mm_slot_cache = KSM_KMEM_CACHE(ksm_mm_slot, 0); > + mm_slot_cache = KMEM_CACHE(ksm_mm_slot, 0); > if (!mm_slot_cache) > goto out_free2; > Acked-by: David Hildenbrand -- Cheers, David / dhildenb