Re: [PATCH] mm: ksm: drop KSM_KMEM_CACHE()

Re: [PATCH] mm: ksm: drop KSM_KMEM_CACHE()

[David Hildenbrand]

On 18.06.24 10:12, Kefeng Wang wrote:
> After commit 21fbd59136e0 ("ksm: add the ksm prefix to the names of
> the ksm private structures"), we could directly use KMEM_CACHE().
> 
> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
> ---
>   mm/ksm.c | 10 +++-------
>   1 file changed, 3 insertions(+), 7 deletions(-)
> 
> diff --git a/mm/ksm.c b/mm/ksm.c
> index d2641bc2efc9..1f62797c9809 100644
> --- a/mm/ksm.c
> +++ b/mm/ksm.c
> @@ -488,21 +488,17 @@ static DECLARE_WAIT_QUEUE_HEAD(ksm_iter_wait);
>   static DEFINE_MUTEX(ksm_thread_mutex);
>   static DEFINE_SPINLOCK(ksm_mmlist_lock);
>   
> -#define KSM_KMEM_CACHE(__struct, __flags) kmem_cache_create(#__struct,\
> -		sizeof(struct __struct), __alignof__(struct __struct),\
> -		(__flags), NULL)
> -
>   static int __init ksm_slab_init(void)
>   {
> -	rmap_item_cache = KSM_KMEM_CACHE(ksm_rmap_item, 0);
> +	rmap_item_cache = KMEM_CACHE(ksm_rmap_item, 0);
>   	if (!rmap_item_cache)
>   		goto out;
>   
> -	stable_node_cache = KSM_KMEM_CACHE(ksm_stable_node, 0);
> +	stable_node_cache = KMEM_CACHE(ksm_stable_node, 0);
>   	if (!stable_node_cache)
>   		goto out_free1;
>   
> -	mm_slot_cache = KSM_KMEM_CACHE(ksm_mm_slot, 0);
> +	mm_slot_cache = KMEM_CACHE(ksm_mm_slot, 0);
>   	if (!mm_slot_cache)
>   		goto out_free2;
>   

Acked-by: David Hildenbrand <david@redhat.com>

-- 
Cheers,

David / dhildenb

[PATCH] mm: ksm: drop KSM_KMEM_CACHE()

[Kefeng Wang]

After commit 21fbd59136e0 ("ksm: add the ksm prefix to the names of
the ksm private structures"), we could directly use KMEM_CACHE().

Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
---
 mm/ksm.c | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

diff --git a/mm/ksm.c b/mm/ksm.c
index d2641bc2efc9..1f62797c9809 100644
--- a/mm/ksm.c
+++ b/mm/ksm.c
@@ -488,21 +488,17 @@ static DECLARE_WAIT_QUEUE_HEAD(ksm_iter_wait);
 static DEFINE_MUTEX(ksm_thread_mutex);
 static DEFINE_SPINLOCK(ksm_mmlist_lock);
 
-#define KSM_KMEM_CACHE(__struct, __flags) kmem_cache_create(#__struct,\
-		sizeof(struct __struct), __alignof__(struct __struct),\
-		(__flags), NULL)
-
 static int __init ksm_slab_init(void)
 {
-	rmap_item_cache = KSM_KMEM_CACHE(ksm_rmap_item, 0);
+	rmap_item_cache = KMEM_CACHE(ksm_rmap_item, 0);
 	if (!rmap_item_cache)
 		goto out;
 
-	stable_node_cache = KSM_KMEM_CACHE(ksm_stable_node, 0);
+	stable_node_cache = KMEM_CACHE(ksm_stable_node, 0);
 	if (!stable_node_cache)
 		goto out_free1;
 
-	mm_slot_cache = KSM_KMEM_CACHE(ksm_mm_slot, 0);
+	mm_slot_cache = KMEM_CACHE(ksm_mm_slot, 0);
 	if (!mm_slot_cache)
 		goto out_free2;
 
-- 
2.41.0