From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB3C8C36010 for ; Tue, 1 Apr 2025 14:37:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0AB93280006; Tue, 1 Apr 2025 10:37:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 05CB2280001; Tue, 1 Apr 2025 10:37:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E1930280006; Tue, 1 Apr 2025 10:37:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id C4757280001 for ; Tue, 1 Apr 2025 10:37:58 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id B26BE160178 for ; Tue, 1 Apr 2025 14:37:58 +0000 (UTC) X-FDA: 83285729436.22.E759C5A Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf29.hostedemail.com (Postfix) with ESMTP id 3D1D512000B for ; Tue, 1 Apr 2025 14:37:56 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=M1CbpyvS; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf29.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743518276; a=rsa-sha256; cv=none; b=xbp6uW5hw+aFywVKsSh/1mqsdrnQtOLnVLcCvsdqvM7CLfHqRiMsZtLgXEUMACzpJFQP7M 737xNBxHA0J3MRh57NvEWK6MU3k2+8tBuYadRLpPdPwuswgEvepzdmy0a6I3Mdw2qTyQ1q 43tTE32dg4p9GHLCNIHAKI9vF5jS0+M= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=M1CbpyvS; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf29.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743518276; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jtaMmTkvpTGuQMzCtvIStTbYkVLoTBzhP3WCAooIZak=; b=Lurz6q3Noz2w/u9o+83aSPpZX5OorSIREoec2vfgE4p2nWeOcr66c/FUwVtYEYZ+JaF2Br KFFtH7ggXdCmuUA/3qjA3Pip+eztdpU7q/RiEKMe+K5VV76PhTz0wqMkKn8BxaTOfefXeU ES63E5FVTdvCLYRFaT3YvyxuDriNeHU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1743518275; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=jtaMmTkvpTGuQMzCtvIStTbYkVLoTBzhP3WCAooIZak=; b=M1CbpyvS2S9CLT8GlOf9KzDC9M36OYiWZEnlfijzZVp24K2G/4UTC62K99c2z1+1vDUsrz Wxrmd7NDrRvcpIKX1O2StGIij0qHYTSG6OkjR+RjcJDnASN3plYyqtg2ffcQ/ohUQe9Ebc S3aElejg8DOXCeHT2q7hTvik7rkX/38= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-294-lV7G4ZbSMoe0ZYCSppjDqw-1; Tue, 01 Apr 2025 10:37:54 -0400 X-MC-Unique: lV7G4ZbSMoe0ZYCSppjDqw-1 X-Mimecast-MFC-AGG-ID: lV7G4ZbSMoe0ZYCSppjDqw_1743518273 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-3978ef9a284so2639257f8f.3 for ; Tue, 01 Apr 2025 07:37:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743518273; x=1744123073; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=jtaMmTkvpTGuQMzCtvIStTbYkVLoTBzhP3WCAooIZak=; b=XTJPR3fpwS15ukUYMEVzttgl/gkrfqLq0IwHlrA0Dqvwy3Y/p/QMuH7kqKQY9paXmU GKtr1BUHlWKYvn9C42KfM/NzoHkp8Pv5EpSyLU3DHI+QbCWrVSJ4752f+/X82ATDiken HxfNgEFtDrfMLmDqf8JFVAg+ryPishe96X9tLy/Yb8ftTb017wG39Ldi1lTaFijDjB3j jfJcuQ/4rbmpCnVUT1wh1bywnmn7ej62o34sUMUXDYWNZTNhYG89VPzGocvLOqFhAKk0 KqUsJOCXe83v5MKtN0lMu3+pJ+HvQSPoYLisQXs2n3TxKLMdHYc+GSjiu9aRhM6/06BN JuEg== X-Forwarded-Encrypted: i=1; AJvYcCV4l5dIMOE1IZrQasrBkSQMF5i5VrjsmX4c1vW/tOlcRVj/sXyClyp/+E1DYA4tZ2KrkDQ+0+oQwQ==@kvack.org X-Gm-Message-State: AOJu0Yy1CIR4LUpQT7qU642qqqYziYiuB8xKa+jmtDaIvH9akBx+pg+f ooGAHx5oYqwGJ0VCjwELkfdwSV/kD5KWuGH7/+ZYecvAWsILHaGFygz5g+Zq8NWcz84BW9YF78D Feu3Gk2siBI+l5c6wbrHfmmwuP6GC0wZC45nQMxsqs14tcWPXWnSFVA8h9FE= X-Gm-Gg: ASbGncsOLOR2l3f+RFGJXx0LDmwdQA6y2PF1JtP3aXIenIIniUHyeWLx9Ok3JjCBQEc b7DmiOKbn/FtwphSYfZQS7uV9FUGq8ZxHB3+0x0L7MJMgqgWKIZl91Nr144bzCEz3piq6B046vg VHzpxPCiI1+mthFIMn4R1iqS/AkTp54a7cuSIpGttxGNjDRqmzPjvQLjxnvUNAAlAUXHKHGM2bt 030YTtyvT9HwkcWSLW1zTxg3x+ZQMrFI9UEQutJu2koxxNyDInL761raoUo6LnVI6M6Ymf906EB /Z8hgYmrMplAUqMn7qa8YUfgvhj7Xz4P2uBuQlXMhKX3YxM2QpZuldoCCbCaPpIB4lR8STRs9N9 oO3cJOw1IvEou69fTKWHtCWAVnVi9OraT6jU4dXDZ X-Received: by 2002:a05:6000:1862:b0:391:40bd:6222 with SMTP id ffacd0b85a97d-39c120ded7bmr10720893f8f.22.1743518273197; Tue, 01 Apr 2025 07:37:53 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGshwDbH2bn4T7SNV37LjEYiabfQQ4zstWoxVA0YKWzvmgKUjvqmtPtmUN4Lcc11Xrjnp8mWQ== X-Received: by 2002:a05:6000:1862:b0:391:40bd:6222 with SMTP id ffacd0b85a97d-39c120ded7bmr10720883f8f.22.1743518272849; Tue, 01 Apr 2025 07:37:52 -0700 (PDT) Received: from ?IPV6:2003:cb:c707:4d00:6ac5:30d:1611:918f? (p200300cbc7074d006ac5030d1611918f.dip0.t-ipconnect.de. [2003:cb:c707:4d00:6ac5:30d:1611:918f]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39c0b66a8c9sm14117975f8f.47.2025.04.01.07.37.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Apr 2025 07:37:52 -0700 (PDT) Message-ID: Date: Tue, 1 Apr 2025 16:37:51 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/7] mm/gup: check if both GUP_GET and GUP_PIN are set in __get_user_pages() earlier To: Baoquan He Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, yanjun.zhu@linux.dev References: <20250331081327.256412-1-bhe@redhat.com> <20250331081327.256412-3-bhe@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: fpivFNPGGBJeAi66Q7nRGxU6o4PaAEAlUGEfBAYp1tM_1743518273 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 3D1D512000B X-Stat-Signature: 5rauwyy6ajntieipf3gxf4awkyss4jkh X-Rspam-User: X-Rspamd-Server: rspam06 X-HE-Tag: 1743518276-385268 X-HE-Meta: U2FsdGVkX19isawrPEVLeUQ+ycp/lvjS0x9S1Tcsdd46eo+t4Db9cElTc4Zo4ICsJ7iOC7E5tE+0pr+hMYHmUhHQqfSs/+lAN6fnUSxFUPrt1lzNHHyunW76U6Fvs5fIjNRDD/AbSTepZw0eDnTq195amwkO2jsvvKvKmOwrYn0DQJsYgCTmDsINiEePkpdrQo1FnDhKdsIXUHMizhVyYZu9a37bnxOuf76QtPPtr2HinBo6vw8rS4kvDDCxA9lGMs5XZ9vWzQoU7vjaRazgJ94BsSht8JAvoypHN/fLUpGNE7E/W8fjbwbQ7vFxOnshGPHD/I2cGzmk/ivpr0bWtbPQbRVROtGUu2iqn2eY8Ed+h2zcv6aEbBy3rX672ta34IlR/n7M7OR/iu+ZJyF8IXaftWrHDlaFcs6QXL1OJPJi/TmlanXjQ/hxdosvdlVsUQTy68xnrY6DQVPBDh7Cvf7XofqxXi0T+FG1qorsOhRW/EjzvMqJamahOo0uffcWwOOsXeq3kfwCqoBDRWeny7+yaCJnqAD/UzcOq5B/5oIeZaCunOzQJLT4c4Uk1LFX91LSqKhTsmA7p/RxXJPm6T6mjmmfjBrkp2iuIwoGIkRc7q0bNkn6C/o0/EE5QIk0LagSIeRwP7t8jysNb5Nc+uX3d/8JnOzqDAUjw81BDswS5kGQr2Ils6FuGXe6xLwYaiCr7W/LI6oAXV38qN8+Be0MEGU9Xc0U/4ypMgque6bsQvUksYTCPthbNEE3bdEbzWKi7S+oDZBgGhq/+PoTN9N0LzXPTWo0WkgJfKpMVEBiWWwYjgMPtmv65Rrz+YffgwBFjzN9Tv3QIXj+0VwGx8UJXnzVb2myp3UtNZxKM5Iv3VpUk8KBu7UY5gDoI2u79J0vqTY4bp6zmpyidhvetgwFStyvs29YEVnbBceXmYlNXgODB2BN4oAjs9v6hQrRcpVc/di3fgF4Zp+EpGP IZhUQqBA 6dcNSKGRUL+yoTbcwrDuJwMCCtcho6/txoql9WkyNy5ZipT0Eqad70R8JcGZdFKFwhugRu6IB+8JgSh93F9LB0u1vCIiRd4XVWZXahO1eUPnH1933shP2i88ML5VN1ZKN9t+gI0vpagyZi9k1TdW3rRsb4aDCSZBCfit8kM8xW/2Sa6wsOrQGEoYpU2RCxpNb3He5vBUHOvnhrLzvuSPbqmGInuEdooNaixHNO25vDY44gXNZo13PYwREubBSg1zEKOXe2KZujZgWHTbzLoCNlMppUvdsMdDUEtSKslFymhM3vwVR/UzmFkyufScEbm9gLX+J/HdhyQCx0i7wC7bR7O3jzBDjQ5mn2fDcDSx8iMgOgIArFIvdDIrG6m5RxGloopGIE9kwnTScj8vb0xU2dAR4fKZjFQubZf+n3P7RECmaxoWx5Cp/caHFnpYrUFiqeYGbtdxRjDrIv4sF7wmqxJFx2g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 01.04.25 16:34, Baoquan He wrote: > On 04/01/25 at 10:02am, David Hildenbrand wrote: >> On 31.03.25 10:13, Baoquan He wrote: >>> In __get_user_pages(), it will traverse page table and take a reference >>> to the page the given user address corresponds to if GUP_GET or GUP_PIN >>> is et. However, it's not supported both GUP_GET and GUP_PIN are set. >>> This check should be done earlier, but not doing it till entering into >>> follow_page_pte() and failed. >>> >>> Here move the checking to the beginning of __get_user_pages(). >>> >>> Signed-off-by: Baoquan He >>> --- >>> v1->v2: >>> - Fix code bug caused by copy-and-paste error, this is reported by >>> lkp test robot. >>> >>> mm/gup.c | 10 +++++----- >>> 1 file changed, 5 insertions(+), 5 deletions(-) >>> >>> diff --git a/mm/gup.c b/mm/gup.c >>> index 73777b1de679..f9bce14ed3cd 100644 >>> --- a/mm/gup.c >>> +++ b/mm/gup.c >>> @@ -847,11 +847,6 @@ static struct page *follow_page_pte(struct vm_area_struct *vma, >>> pte_t *ptep, pte; >>> int ret; >>> - /* FOLL_GET and FOLL_PIN are mutually exclusive. */ >>> - if (WARN_ON_ONCE((flags & (FOLL_PIN | FOLL_GET)) == >>> - (FOLL_PIN | FOLL_GET))) >>> - return ERR_PTR(-EINVAL); >>> - >>> ptep = pte_offset_map_lock(mm, pmd, address, &ptl); >>> if (!ptep) >>> return no_page_table(vma, flags, address); >>> @@ -1434,6 +1429,11 @@ static long __get_user_pages(struct mm_struct *mm, >>> VM_BUG_ON(!!pages != !!(gup_flags & (FOLL_GET | FOLL_PIN))); >>> + /* FOLL_GET and FOLL_PIN are mutually exclusive. */ >>> + if (WARN_ON_ONCE((gup_flags & (FOLL_PIN | FOLL_GET)) == >>> + (FOLL_PIN | FOLL_GET))) >>> + return -EINVAL; >>> + >> >> We already have that check in is_valid_gup_args(), that catches all external >> users that could possibly mess this up. > > Right. > >> >> So we can just convert that into a VM_WARN_ON_ONCE(), and while doing that, >> we should convert the VM_BUG_ON() above to a VM_WARN_ON_ONCE() as well. > > Sounds great to me, will put below change into this patch of v3 as suggested. > Thanks. > > diff --git a/mm/gup.c b/mm/gup.c > index 9e4ed09c578b..d551da9549b1 100644 > --- a/mm/gup.c > +++ b/mm/gup.c > @@ -1427,10 +1427,10 @@ static long __get_user_pages(struct mm_struct *mm, > > start = untagged_addr_remote(mm, start); > > - VM_BUG_ON(!!pages != !!(gup_flags & (FOLL_GET | FOLL_PIN))); > + VM_WARN_ON_ONCE(!!pages != !!(gup_flags & (FOLL_GET | FOLL_PIN))); > > /* FOLL_GET and FOLL_PIN are mutually exclusive. */ > - if (WARN_ON_ONCE((gup_flags & (FOLL_PIN | FOLL_GET)) == > + if (VM_WARN_ON_ONCE((gup_flags & (FOLL_PIN | FOLL_GET)) == > (FOLL_PIN | FOLL_GET))) That won't work (or shouldn't work :) ). Just drop the handling, it's a sanity check we don't expect to ever trigger, just like the old VM_BUG_ON above. -- Cheers, David / dhildenb