From: Randy Dunlap <rdunlap@infradead.org>
To: Usama Arif <usamaarif642@gmail.com>,
Yafang Shao <laoar.shao@gmail.com>,
akpm@linux-foundation.org, david@redhat.com, ziy@nvidia.com,
baolin.wang@linux.alibaba.com, lorenzo.stoakes@oracle.com,
Liam.Howlett@oracle.com, npache@redhat.com, ryan.roberts@arm.com,
dev.jain@arm.com, hannes@cmpxchg.org,
gutierrez.asier@huawei-partners.com, willy@infradead.org,
ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org,
ameryhung@gmail.com, rientjes@google.com, corbet@lwn.net,
21cnbao@gmail.com, shakeel.butt@linux.dev, tj@kernel.org,
lance.yang@linux.dev
Cc: bpf@vger.kernel.org, linux-mm@kvack.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v8 mm-new 04/12] mm: thp: add support for BPF based THP order selection
Date: Fri, 26 Sep 2025 12:17:45 -0700 [thread overview]
Message-ID: <a5015724-a799-4151-bcc4-000c2c5c7178@infradead.org> (raw)
In-Reply-To: <073d5246-6da7-4abb-93d6-38d814daedcc@gmail.com>
On 9/26/25 8:13 AM, Usama Arif wrote:
>> +config BPF_THP_GET_ORDER_EXPERIMENTAL
>> + bool "BPF-based THP order selection (EXPERIMENTAL)"
>> + depends on TRANSPARENT_HUGEPAGE && BPF_SYSCALL
>> +
>> + help
>> + Enable dynamic THP order selection using BPF programs. This
>> + experimental feature allows custom BPF logic to determine optimal
>> + transparent hugepage allocation sizes at runtime.
>> +
>> + WARNING: This feature is unstable and may change in future kernel
>> + versions.
>> +
> I am assuming this series opens up the possibility of additional hooks being added in
> the future. Instead of naming this BPF_THP_GET_ORDER_EXPERIMENTAL, should we
> name it BPF_THP? Otherwise we will end up with 1 Kconfig option per hook, which
> is quite bad.
>
> Also It would be really nice if we dont put "EXPERIMENTAL" in the name of the defconfig.
> If its decided that its not experimental anymore without any change to the code needed,
> renaming the defconfig will break it for everyone.
s/defconfig/Kconfig symbol/
Otherwise agreed.
Thanks.
--
~Randy
next prev parent reply other threads:[~2025-09-26 19:18 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-26 9:33 [PATCH v8 mm-new 00/12] mm, bpf: " Yafang Shao
2025-09-26 9:33 ` [PATCH v8 mm-new 01/12] mm: thp: remove disabled task from khugepaged_mm_slot Yafang Shao
2025-09-26 14:11 ` Usama Arif
2025-09-28 2:21 ` Yafang Shao
2025-09-26 9:33 ` [PATCH v8 mm-new 02/12] mm: thp: remove vm_flags parameter from khugepaged_enter_vma() Yafang Shao
2025-09-26 14:49 ` Usama Arif
2025-09-28 2:35 ` Yafang Shao
2025-09-26 9:33 ` [PATCH v8 mm-new 03/12] mm: thp: remove vm_flags parameter from thp_vma_allowable_order() Yafang Shao
2025-09-26 14:54 ` Usama Arif
2025-09-26 9:33 ` [PATCH v8 mm-new 04/12] mm: thp: add support for BPF based THP order selection Yafang Shao
2025-09-26 15:13 ` Usama Arif
2025-09-26 19:17 ` Randy Dunlap [this message]
2025-09-28 2:13 ` Yafang Shao
2025-09-26 9:33 ` [PATCH v8 mm-new 05/12] mm: thp: decouple THP allocation between swap and page fault paths Yafang Shao
2025-09-26 15:19 ` Usama Arif
2025-09-26 9:33 ` [PATCH v8 mm-new 06/12] mm: thp: enable THP allocation exclusively through khugepaged Yafang Shao
2025-09-26 15:27 ` Usama Arif
2025-09-28 2:58 ` Yafang Shao
2025-09-26 9:33 ` [PATCH v8 mm-new 07/12] bpf: mark mm->owner as __safe_rcu_or_null Yafang Shao
2025-09-26 9:33 ` [PATCH v8 mm-new 08/12] bpf: mark vma->vm_mm as __safe_trusted_or_null Yafang Shao
2025-09-26 9:33 ` [PATCH v8 mm-new 09/12] selftests/bpf: add a simple BPF based THP policy Yafang Shao
2025-09-26 9:33 ` [PATCH v8 mm-new 10/12] selftests/bpf: add test case to update " Yafang Shao
2025-09-26 9:33 ` [PATCH v8 mm-new 11/12] selftests/bpf: add test cases for invalid thp_adjust usage Yafang Shao
2025-09-26 9:33 ` [PATCH v8 mm-new 12/12] Documentation: add BPF-based THP policy management Yafang Shao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a5015724-a799-4151-bcc4-000c2c5c7178@infradead.org \
--to=rdunlap@infradead.org \
--cc=21cnbao@gmail.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=ameryhung@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=bpf@vger.kernel.org \
--cc=corbet@lwn.net \
--cc=daniel@iogearbox.net \
--cc=david@redhat.com \
--cc=dev.jain@arm.com \
--cc=gutierrez.asier@huawei-partners.com \
--cc=hannes@cmpxchg.org \
--cc=lance.yang@linux.dev \
--cc=laoar.shao@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=npache@redhat.com \
--cc=rientjes@google.com \
--cc=ryan.roberts@arm.com \
--cc=shakeel.butt@linux.dev \
--cc=tj@kernel.org \
--cc=usamaarif642@gmail.com \
--cc=willy@infradead.org \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox