From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48F6CEE49A3 for ; Tue, 22 Aug 2023 13:01:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 971B894001A; Tue, 22 Aug 2023 09:01:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9226090000D; Tue, 22 Aug 2023 09:01:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7EACD94001A; Tue, 22 Aug 2023 09:01:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 7063090000D for ; Tue, 22 Aug 2023 09:01:02 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 4098680323 for ; Tue, 22 Aug 2023 13:01:02 +0000 (UTC) X-FDA: 81151750764.18.429571B Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf13.hostedemail.com (Postfix) with ESMTP id 45F2220046 for ; Tue, 22 Aug 2023 13:01:00 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=cvqkpboF; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf13.hostedemail.com: domain of mkoutny@suse.com designates 195.135.220.28 as permitted sender) smtp.mailfrom=mkoutny@suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692709260; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OAbqRGEAHu7Ri1BEFwHTiMJqbULQ9AggcksOng91Am0=; b=eSHy5DqOcMeBP/b0iQI6D0tKiE/AZX+yt1auY66AGUa0BO1UwBKa8X/gVVExx8v219TP+A 8OGa71N7ZGbxOcZualDDJw9Y64LCCAi0alqkAvhPdnYeCfbFFMDRd34Eetn1L/ewOjmAZ3 lCqdFlZYXzeQ9b9gNDf8iwou+l3CVu8= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=cvqkpboF; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf13.hostedemail.com: domain of mkoutny@suse.com designates 195.135.220.28 as permitted sender) smtp.mailfrom=mkoutny@suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692709260; a=rsa-sha256; cv=none; b=zmNaRFZiqgmpk+leGJTa2QDUeG9AoEqXzKk8+VsuQigfMVFyX9SlXMot8RmVX5jhdG5Hbq 2iD9OWmWPGeDMxpnmSTjEvtQ4NM0uvNM5xky5OKwd2u3fdTwcf+S5Ns0cLdSxu5IoHwgbG 61+OFHtk4Q274JRKzhh+DRKS0Gv/8m0= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 7B2D422C00; Tue, 22 Aug 2023 13:00:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1692709257; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=OAbqRGEAHu7Ri1BEFwHTiMJqbULQ9AggcksOng91Am0=; b=cvqkpboFbqEuoqpJwUDKKnH2hSxO9sIKRD0OoHN68lpKaWPMvn6sYj3+y0FrVNkubvdd7y fhRZvkxdGrVB+2klXgVvUwuoxPBUH8NGm3GOyNzDLkZAbcqa6o+Bcu80dpJ1LGXUdWbeAr YktZZL9KkXW/Gqnkv6S94Mwwu6RQorc= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 273A7132B9; Tue, 22 Aug 2023 13:00:57 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id kVQQCImx5GQadQAAMHmgww (envelope-from ); Tue, 22 Aug 2023 13:00:57 +0000 Date: Tue, 22 Aug 2023 15:00:55 +0200 From: Michal =?utf-8?Q?Koutn=C3=BD?= To: Yosry Ahmed Cc: Andrew Morton , Johannes Weiner , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , Ivan Babrou , Tejun Heo , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/3] memcg: non-unified flushing for userspace stats Message-ID: References: <20230821205458.1764662-1-yosryahmed@google.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="rsgiuzyi263iyyyh" Content-Disposition: inline In-Reply-To: <20230821205458.1764662-1-yosryahmed@google.com> X-Rspam-User: X-Stat-Signature: i5egmnwkcuu643aejdnt4pg6aj7rrxjz X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 45F2220046 X-HE-Tag: 1692709260-117526 X-HE-Meta: U2FsdGVkX19r3HxLJMP4eUxRfCYZ1YxVH7+KQPonWa37ixYlEpcrAGCltwDZ+uxuY965KyBWOESCvI9iuUr+JBRkz2LXwpHGZ4hApUrqkrdXgb14ISG9klvthE6+tHd6/hCbBtkyECo86M9kkqRVSUh+wPgyTlwcwcQkNb8d/Ji+0InQ13S+OPsfb2vXgv+ORL0d/Pr71wGwE/bklUNdWu/SH1i/LKCC+RM22tTywYWWBruObNkJWiJj7Weum6IGffZYW3WXoVir3GMBHyPwmz144xfEoDPgQBLu6UVTbo89EW88RzCjonMG3wTFWQW3QL4m3JHSeDZeNqVo6ssr6juXPc6+p/LXGPrR0T9mDF6FF+Pwez/el0zUxobsQ6UJTePneWjLO7gPzJHN6vYBHef3Dv+nV7b1rpHh3pmhWFrwYkbl4QO3YEKZgsRDYlVyJotlC7GCkrgaaxmE3ewjObD8BaOeQKXzxDOVz12HXWMi36oS6TbtlkZlDU1/xwrau7j9QmEHkfeI5GZyGP8X0HPQ+iOASs0bPDScn+n8EKIhbpV4P2jIB3A9+XqIVTlHJEqYX715eia77OxwW5NSZEaA7XuH5RvbfFT1XY/udLod+/0JOQaOK/Z0COAGyzTVjSl1oEitQAjUPcTvzFxXw8Q7WMadvNmGnY8TjFWkoSQ9p1uRQNotv0D650JDhxnagycbaGw0cgbaciWKl/CIvCYJlH65jSAeCJfFLRXk9yWuBiqbgAhUy8HaLMVuUzG33A8hVPf8cDXxvLpL49SEvhz3wTE/gCG+pVHK78SHyuonEkW9ZIRFBG/F+nfeT1m260Ld1E6/K3r+kTyH7+P2YCnpEKNQouO8OJRdEFj/qFDw6qD/xTrFu1nOwnhq4mkRYrbX3Rx7fAUQJB4JcKGtpQExcoJLP5t0qSJMxQ48H0obRn2oFEG8RchlEY0H/RTqOq4qyt0VBxePwUYFLyY Moj2o5Jq yYp2QmG5vbzu38qaKBgqOoMmOalO7ULI48djsXPMsfxwGNz76KiMIXsGZuXZrgvwMGzOsP+FsUgOWffAtbCymdsUkHiAlRslRIJfr+6fVC2gvR4sPSWJ4gw9YEA0F/ASPYDh6iZPQsjtMUJpSQBUNgMwGWFEm5O+zqcguQ5hdaar/aHtLDBWg7RD/cJ4suf2qwTBeGiRs1lq+IY+WLa+r0So/M1illrHqeffvOjEMHmhb871Jym/yEIoRejpO35nMdLkigbKtXGx0mvhW4//vKg2dE3HRJeU+syIJ7ad26raafTHnfnA13uY58ehfZsHEdVGpYTeBI+kN2zVmC64VO3i6Vg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --rsgiuzyi263iyyyh Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hello. On Mon, Aug 21, 2023 at 08:54:55PM +0000, Yosry Ahmed wrote: > For userspace reads, unified flushing leads to non-deterministic stats > staleness and reading cost. I only skimed previous threads but I don't remember if it was resolved: a) periodic flushing was too much spaced for user space readers (i.e. 2s delay is too much [1]), b) periodic flushing didn't catch up (i.e. full tree flush can occassionaly take more than 2s) leading to extra staleness? [1] Assuming that nr_cpus*MEMCG_CHARGE_BATCH error bound is also too much for userspace readers, correct? > The cost of userspace reads are now determinstic, and depend on the > size of the subtree being read. This should fix both the *sometimes* > expensive reads (due to flushing the entire tree) and occasional > staless (due to skipping flushing). This is nice, thanks to the atomic removal in the commit 0a2dc6ac3329 ("cgroup: remove cgroup_rstat_flush_atomic()"). I think the smaller chunks with yielding could be universally better (last words :-). Thanks, Michal --rsgiuzyi263iyyyh Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQQpEWyjXuwGT2dDBqAGvrMr/1gcjgUCZOSxhQAKCRAGvrMr/1gc jql9AP416SvKn+uj/hrokt/s6nOdeQdWlzpvkkf2UKZg17whHgD/SdSKRx0jIIbq nqT/QXyO3EYKtOWfLu6jR/PVNXm4+A8= =/E7c -----END PGP SIGNATURE----- --rsgiuzyi263iyyyh--