From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 650C5CA0ED3 for ; Mon, 2 Sep 2024 07:34:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E80028D009B; Mon, 2 Sep 2024 03:34:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E2FA88D0098; Mon, 2 Sep 2024 03:34:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CD0468D009B; Mon, 2 Sep 2024 03:34:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id A9E368D0098 for ; Mon, 2 Sep 2024 03:34:55 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 32B6FA8374 for ; Mon, 2 Sep 2024 07:34:55 +0000 (UTC) X-FDA: 82518986550.11.FF82CFE Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf01.hostedemail.com (Postfix) with ESMTP id EC68D40011 for ; Mon, 2 Sep 2024 07:34:51 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=eDh6He24; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725262388; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0bIolMxRndqsyO/guw3WDJdhsYGZA5z9MoL0tLTnhIo=; b=iCaSFjFtXsBNKnmFwK73c2VMZLWT1hFCGs9S2f+/SXcVGJkdRUsyFEPG2RoNC9KX7IMKHt s9Wes0jVWt/4QW9pQdc5+Dpc9HI6t4dsNBEcM1QliEbH/N4EZR8ySazo8kGjBwRmpkeGGy VwcBiQNBE4IvUtENmOyxBIA522yboXQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725262388; a=rsa-sha256; cv=none; b=OlVYBvDLV3pZpuhtxbWrJ8aTceY/gXxih7jPCpBj99P7asgVWnvOrX+SSKocJmfHgMVctC cmYtXsmQ2SFEZ7Q7tAHOvNDgDL/a2ElQ7S31PlVwf3ObZ6ygUKUd0EHgnsMyhHP4P5vHFx rkMXBU8tvYscRCHZiBG46wGA4vJKJzc= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=eDh6He24; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1725262491; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=0bIolMxRndqsyO/guw3WDJdhsYGZA5z9MoL0tLTnhIo=; b=eDh6He24nO75CQ/RsZ9rxXgsYTDDknsZuAPb5CSyH9gkocwRzhZ+SE+zxS9T/GE/j0aExe 5oZdIMaSllqI0yoskEZKxDRtw+UIhZIzjs/1Ij3tyEO9AHEkwduNbncPqI4ZxtUsW5NQNT 3BCBhO6uZX2AVOPPqmJndnkEOrlZUqA= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-439-ov9YCxoYN-S8nCJ7ZO0kzg-1; Mon, 02 Sep 2024 03:34:50 -0400 X-MC-Unique: ov9YCxoYN-S8nCJ7ZO0kzg-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-42bb68e16b0so44895735e9.1 for ; Mon, 02 Sep 2024 00:34:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725262489; x=1725867289; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=0bIolMxRndqsyO/guw3WDJdhsYGZA5z9MoL0tLTnhIo=; b=m0rlekJJ5vlJFmt3ZHiGbDqwLgunakeHZ6uElHWYPcF74Nr2o8/r6RKllhZ1Mjx6MG bORptVPNmmule0QkjF0LGFuAWy08IvrPoKtRcz9IWCqzVXjdiZepWas1PdiwNnT6FjmO pt1+hhaAUFh1g09IS9Tg8W9O0BroESdgxt6svE9HJ+iywqDrQ9abYMj+Gp76Qt0NM8Th +LShgdxS18EXeES0cEa/wQBRmX3o9hWxnsQZJkkefonGMBYEoK8X7IN3W5Q+14JUpj4b TKes2LxiVRJ9Ivx1mhcHBtzGoaQmssQH8EXT7cr1kdnGittknN/eOOndbOnm+Tdk9+Lw 9a8A== X-Forwarded-Encrypted: i=1; AJvYcCVuCIeR5fzb+sEAmoeYuG/QF4U9EuHkXz1a9K6/uMGcVSngFPqPB0VOypudjfHadWjj4//n1RuEJw==@kvack.org X-Gm-Message-State: AOJu0Yy5/5JO9KXIIm/tWvyOwtxna1W3c+7Ydo5Et1MBqQeKivyAECER 3u7wA7QGvFiaVKf0CkgJxZwAHlilY2vzcnajOlijgNRgJ9mrADy1bywT2XitQTKUk2NcA68Tmzc sY7yQge8UfFdwpRBXzUHaXkou1s//42F3E5scD0AqML35uKOj X-Received: by 2002:adf:f892:0:b0:374:c64d:536a with SMTP id ffacd0b85a97d-374c64d543emr2664762f8f.27.1725262488915; Mon, 02 Sep 2024 00:34:48 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH3cIKk6MeL/umQ01MQpGLwfX7XhCjaXfQf7ZwqKYRZQgE3Tttjqj0GuxbMVZPg5oas7Ww5fQ== X-Received: by 2002:adf:f892:0:b0:374:c64d:536a with SMTP id ffacd0b85a97d-374c64d543emr2664720f8f.27.1725262488027; Mon, 02 Sep 2024 00:34:48 -0700 (PDT) Received: from ?IPV6:2a09:80c0:192:0:5dac:bf3d:c41:c3e7? ([2a09:80c0:192:0:5dac:bf3d:c41:c3e7]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a8989221c2fsm523185966b.197.2024.09.02.00.34.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 Sep 2024 00:34:47 -0700 (PDT) Message-ID: Date: Mon, 2 Sep 2024 09:34:46 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 2/3] mm: document __GFP_NOFAIL must be blockable To: Barry Song <21cnbao@gmail.com>, akpm@linux-foundation.org, linux-mm@kvack.org, virtualization@lists.linux.dev Cc: 42.hyeyoo@gmail.com, cl@linux.com, hailong.liu@oppo.com, hch@infradead.org, iamjoonsoo.kim@lge.com, mhocko@suse.com, penberg@kernel.org, rientjes@google.com, roman.gushchin@linux.dev, torvalds@linux-foundation.org, urezki@gmail.com, v-songbaohua@oppo.com, vbabka@suse.cz, laoar.shao@gmail.com, Christoph Hellwig , Davidlohr Bueso , =?UTF-8?Q?Eugenio_P=C3=A9rez?= , Jason Wang , Kees Cook , Lorenzo Stoakes , Maxime Coquelin , "Michael S. Tsirkin" , Xuan Zhuo References: <20240830202823.21478-1-21cnbao@gmail.com> <20240830202823.21478-3-21cnbao@gmail.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240830202823.21478-3-21cnbao@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: EC68D40011 X-Stat-Signature: icpm9exsn586xkhtpfpogqp79xy8ue1m X-Rspam-User: X-HE-Tag: 1725262491-853846 X-HE-Meta: U2FsdGVkX1/VUa3WeZH8vbRJfj3QLcqz1OGafZL7vzanbF1LQDGWgw2rUSyT289uEiQYSzmkoJzL4f9+a/huev3qbVN0UTOqJU+ax0jmMOOKl7GzZL1gR0OopL+Y2Qx/Dtn3cxpdvviriVXXSLdlYli0qN/2kNbsMQeSsRe/bC6S3tk0kYKMGJj23r42XHoIr8O2P3lL+P8XG5BhxygfCpdp4EeVapHcTBynHR/U9E3+DvWcmKpzFOtS+qoTyTSvGOCFwkSgajJj/bMIyAs5py2Cr0ph7GeSxaO2KlY0E0BkAoGjC1RmPnhTFFbfqytAC8EAnGb3FIcFDuRFAHPa6NVO4RiRBFTaeqsl77hA5RJn2lmtIk38cT5Kll5bdeVWQk9vA2zLxcOdZH4AuRDZ66AwA//eH3xbEkPL54n3lNE1cBVMzBHIHm+foORTZY81zch1puCokmiLGfP9+/oo6CDS/NKwOsNqy/cui/aj3FurLp7QnSoIu2XvEFPzd3lj4KUCx0FgMQJaPLx1oIYS/ts3Tc1LjawA8EXQuZ9AsHb9VaO+h62D0eGdhrLJnximWYSpTzgooXeNuOvbvORSm4N1lia0qwrM62IJ38UIg+50bZ6nkbJIqHN2JyLO7XRl6v2/GHLlbP1LXvmTivAipN4i3n6QJUWfDtdnFXWmRsuaP5tJBL/EyX1Eg0Zl9oOvuC29dGGbMpF1wIjrREe8VRcGYjV1p+ubOWALxl04yG+qqsXlXQoQr3Qi6oToc6CWu5UpIYay6XpSnrOcAS46kyTU2LYv9k4dgAcOyLaDn3fxkm11zgPBIYTiHazgS3OwZBGPJk+CFqTESrX8lMEaa/gyWRnHMsUic7WK93ZZGatM9RxLSnVJj/PcVT7AzYJvMOTNl3S2DVUMeuLkH2zxwvx043PqK/DHHzbkgsEjL9cSCKTkHcvQ6s9xlltGMw/uYyhmDA1mSkvLhyaor2S TjoV+NAw km3AxjHtru4mbhDvAh2tAJ8GSuLsG7G2IoQckP0fbgDTJOoq7hArOcBeeXzQBwjJb9M4cjY069Lki7rHOjmgLyKHjUJu63Xp06NY8y6XqYQHMkbhd7yDOCUrBrHumLBByvD8DN2iuDjDfB7D8X/OSr/rvxeUI/ePrT3OZJkJbyr5KMqhfRBpTmPbLA8L3QH7UrG+1UGNTZhH8ZgsGlC09tPZfP3UnJAYDG3vswbC+8+gS/J5/Tn/ZV4Zrqlo+qOa+v0LzRwUi86mdCrJZwE/RTstf1Jxxc55YlHQDvGtpshQTZ8GTLBwAxc3dVhTpayoi3o096o5Pw2p2wXVzUJDp5zE58+9HEkIUAMmo8sM6kjhft8w6K8jy0uHM63lUk05uNFtWNsBogLBAa606N1mk8/ny6FmdOuFDdtHF1iM4k0D1oxsyHeWvDg8eQg+azPz1FO98qD86m/pJgKiA5JnKJHcYzxat7y7gk6f2v0uZndNddn3pau8J5W+iERAI4Goez4NuW6/ubuBPuvSGfGlcYYWB9LFG+S48WVglHeVnVAGkoo+ss84l2QUxXdA/g4mAXlc/AeZDDCUU7UQCV8nKHD80uicj3k6s1U4bqxwQlzCqnFfwTHyOo4zw/6C3pCuHPreD4WalhoP2xnnE1Hsoatrh9Z3k6KS9b3e+ogjh4uid3R907hX2qszyntjH6X9uaRlLh02dPntMB9BYmyOLOiHI397gptYw/xIZoiwKI+FOn617AEDG3DhICGaByRCCzV7ENALp+uWAY8gi9Ksz+rsT4AKFC6krFzfaItEC1H51IYMTcHq5UxEv1mwbmF3raaDY0NA8q8xrhUATRD0JuAMRu14cUXgeB0lBDQzQUdT0IPjxJzFtxWQVDjnVXBIwk/Qele2kCxlSbqcYmo9w9bpo0LsPhNF/mGZXEgwTrWctwdGSn3CzpJwXJ2HuKiUyANXKWMtQbJ92mSqhm0Hsl5EQLGSt 7P2SOOyR Q2YluEDEeAQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 30.08.24 22:28, Barry Song wrote: > From: Barry Song > > Non-blocking allocation with __GFP_NOFAIL is not supported and may still > result in NULL pointers (if we don't return NULL, we result in busy-loop > within non-sleepable contexts): > > static inline struct page * > __alloc_pages_slowpath(gfp_t gfp_mask, unsigned int order, > struct alloc_context *ac) > { > ... > /* > * Make sure that __GFP_NOFAIL request doesn't leak out and make sure > * we always retry > */ > if (gfp_mask & __GFP_NOFAIL) { > /* > * All existing users of the __GFP_NOFAIL are blockable, so warn > * of any new users that actually require GFP_NOWAIT > */ > if (WARN_ON_ONCE_GFP(!can_direct_reclaim, gfp_mask)) > goto fail; > ... > } > ... > fail: > warn_alloc(gfp_mask, ac->nodemask, > "page allocation failure: order:%u", order); > got_pg: > return page; > } > > Highlight this in the documentation of __GFP_NOFAIL so that non-mm > subsystems can reject any illegal usage of __GFP_NOFAIL with GFP_ATOMIC, > GFP_NOWAIT, etc. > > Signed-off-by: Barry Song > Acked-by: Michal Hocko > Reviewed-by: Christoph Hellwig > Acked-by: Vlastimil Babka > Acked-by: Davidlohr Bueso > Cc: Christoph Lameter > Cc: David Rientjes > Cc: "Eugenio Pérez" > Cc: Hailong.Liu > Cc: Hyeonggon Yoo <42.hyeyoo@gmail.com> > Cc: Jason Wang > Cc: Joonsoo Kim > Cc: Kees Cook > Cc: Linus Torvalds > Cc: Lorenzo Stoakes > Cc: Maxime Coquelin > Cc: "Michael S. Tsirkin" > Cc: Pekka Enberg > Cc: Roman Gushchin > Cc: Uladzislau Rezki (Sony) > Cc: Xuan Zhuo > --- Acked-by: David Hildenbrand -- Cheers, David / dhildenb