linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: "Yin, Fengwei" <fengwei.yin@intel.com>
To: Baolin Wang <baolin.wang@linux.alibaba.com>,
	Barry Song <21cnbao@gmail.com>
Cc: <catalin.marinas@arm.com>, <will@kernel.org>,
	<akpm@linux-foundation.org>, <v-songbaohua@oppo.com>,
	<yuzhao@google.com>, <linux-mm@kvack.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] arm64: mm: drop tlb flush operation when clearing the access bit
Date: Wed, 25 Oct 2023 11:08:51 +0800	[thread overview]
Message-ID: <a4ae7473-636b-4ff3-9f66-f47dbe934593@intel.com> (raw)
In-Reply-To: <f3047412-a53c-f8ba-f8aa-4f46e04c5a31@linux.alibaba.com>



On 10/25/2023 11:03 AM, Baolin Wang wrote:
>>
>> My understanding is that arm64 doesn't do invalidate the TLB during > context switch. The flush_tlb_page_nosync() here + DSB during context
> 
> Yes, we only perform a TLB flush when the ASID is exhausted during context switch, and I think this is same with x86 IIUC.
If we remove flush_tlb_page_nosync(), can we still claim TLB is flushed during
context switch for ARM64?

> 
>> switch make sure the TLB is invalidated during context switch.
>> So we can't remove flush_tlb_page_nosync() here? Or something was changed
>> for arm64 (I have zero knowledge to TLB on arm64. So some obvious thing
>> may be missed)? Thanks.
> 
> IMHO, the tlb can be easily evicted or flushed if the system is under memory pressure, so like Barry said, the chance of reclaiming hot page is relatively low, at least on X86, we did not see any heavy refault issue.
> 
> For MGLRU, it uses ptep_test_and_clear_young() instead of ptep_clear_flush_young_notify(), and we did not find any problems until now since deploying to ARM servers.


  reply	other threads:[~2023-10-25  3:09 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-24 12:56 Baolin Wang
2023-10-24 13:48 ` Kefeng Wang
2023-10-25  1:44   ` Baolin Wang
2023-10-24 22:32 ` Yu Zhao
2023-10-24 23:16 ` Barry Song
2023-10-24 23:31   ` Barry Song
2023-10-25  1:07     ` Alistair Popple
2023-10-25  1:44       ` Barry Song
2023-10-25  1:58         ` Alistair Popple
2023-10-25  2:43           ` Baolin Wang
2023-10-25  3:09             ` Alistair Popple
2023-10-25  6:17               ` Yu Zhao
2023-10-25  6:27                 ` Barry Song
2023-10-25 10:12                   ` Alistair Popple
2023-10-25 18:22                     ` Yu Zhao
2023-10-25 23:32                       ` Alistair Popple
2023-10-26 23:48                     ` Barry Song
2023-10-25  2:02     ` Baolin Wang
2023-10-25  1:39   ` Yin, Fengwei
2023-10-25  3:03     ` Baolin Wang
2023-10-25  3:08       ` Yin, Fengwei [this message]
2023-10-25  3:15         ` Baolin Wang
2023-10-25  4:34         ` Barry Song
2023-11-07 10:12     ` Will Deacon
2023-11-07 20:50       ` Barry Song
2023-10-26  4:55 ` Anshuman Khandual
2023-10-26  5:54   ` Barry Song
2023-10-26  6:01     ` Anshuman Khandual
2023-10-26 12:30       ` Robin Murphy
2023-10-26 12:32       ` Baolin Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a4ae7473-636b-4ff3-9f66-f47dbe934593@intel.com \
    --to=fengwei.yin@intel.com \
    --cc=21cnbao@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=baolin.wang@linux.alibaba.com \
    --cc=catalin.marinas@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=v-songbaohua@oppo.com \
    --cc=will@kernel.org \
    --cc=yuzhao@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox