From: "Verma, Vishal L" <vishal.l.verma@intel.com>
To: "linux-mm@kvack.org" <linux-mm@kvack.org>,
"david@redhat.com" <david@redhat.com>
Cc: "Williams, Dan J" <dan.j.williams@intel.com>,
"linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>,
"mhocko@kernel.org" <mhocko@kernel.org>,
"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>
Subject: Re: [PATCH v4] mm/memory_hotplug: refrain from adding memory into an impossible node
Date: Thu, 16 Apr 2020 22:47:56 +0000 [thread overview]
Message-ID: <a4a28e70d9fe25e514932099a8fd5a41eef51409.camel@intel.com> (raw)
In-Reply-To: <6af5471c-8c41-e642-b20e-9c9d156cc754@redhat.com>
On Thu, 2020-04-16 at 19:53 +0200, David Hildenbrand wrote:
> > > >
> > > Hm, I'm happy to make the changes, but EINVAL to me suggests there is a
> > > problem in the way this was called by the user. And in this case there
> > > really might not be much the user can change in case fo buggy firmware.
> >
> > Yeah, but introducing new return codes callers might not expected might
> > create IMHO other issues.
> >
> > > Same thing with the WARN - make the potential firmware bug much more
> > > obvious and visible.
> > >
> >
> > Yeah, but I doubt this is really necessary. No strong feelings.
> >
>
> Forgot to
>
> Acked-by: David Hildenbrand <david@redhat.com>
>
Thanks for the review David. I'll change the return code, and keep the
WARN, and send a new version.
prev parent reply other threads:[~2020-04-16 22:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-16 17:10 Vishal Verma
2020-04-16 17:12 ` David Hildenbrand
2020-04-16 17:23 ` Verma, Vishal L
2020-04-16 17:25 ` David Hildenbrand
2020-04-16 17:53 ` David Hildenbrand
2020-04-16 22:47 ` Verma, Vishal L [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a4a28e70d9fe25e514932099a8fd5a41eef51409.camel@intel.com \
--to=vishal.l.verma@intel.com \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=david@redhat.com \
--cc=linux-mm@kvack.org \
--cc=linux-nvdimm@lists.01.org \
--cc=mhocko@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox