From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC447C4332F for ; Sat, 17 Dec 2022 02:02:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3BE878E0002; Fri, 16 Dec 2022 21:02:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 36ECF8E0001; Fri, 16 Dec 2022 21:02:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2103C8E0002; Fri, 16 Dec 2022 21:02:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 0D6198E0001 for ; Fri, 16 Dec 2022 21:02:01 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id CD271C0352 for ; Sat, 17 Dec 2022 02:02:00 +0000 (UTC) X-FDA: 80250147600.10.D432BDF Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by imf24.hostedemail.com (Postfix) with ESMTP id BC9C3180003 for ; Sat, 17 Dec 2022 02:01:58 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf24.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1671242519; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GqQrGCv9ZGZYLUy295N8kKBfOFhUC+YW3dTkvMUSVYM=; b=gkNRfWllR0lHdODgEvnIPghLmB/5enp/yQ6mbrNw/BoDdbjQIa2KkemjcL6T/BFCsCvXQf IQA275ceLk3Hc5616mTsiPg4F4fmtrEeiy17gPD1Ed2MZFkNQOfiyvgsRB6lkQDyLTcrrc hTz2+gaQW2y6rEehpaKtDJvp4tRO86Y= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf24.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1671242519; a=rsa-sha256; cv=none; b=B9guOyoGUFgGlOjTzwNvRzn0xgPmLesbGgSpPI7kOS9Vk+tlWY7ujN+LB3l4tteGuaOBTk Q8aaQEzdMzWsaCNSoiy5o/g+Sr+4w8UccBb2RqiqoOAd4AtDHiRNurO9o6rHCKd5RXKIpT FAwuAwdlo2HyS7H/QIIcqjP6mWGxcC8= Received: from canpemm500002.china.huawei.com (unknown [172.30.72.57]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4NYq1t1sJszRpvc; Sat, 17 Dec 2022 10:00:50 +0800 (CST) Received: from [10.174.151.185] (10.174.151.185) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Sat, 17 Dec 2022 10:01:54 +0800 Subject: Re: [PATCH 2/2] hugetlb: update vma flag check for hugetlb vma lock To: Mike Kravetz , , CC: Muchun Song , David Hildenbrand , Peter Xu , Naoya Horiguchi , "Aneesh Kumar K . V" , James Houghton , Mina Almasry , Andrew Morton References: <20221212235042.178355-1-mike.kravetz@oracle.com> <20221212235042.178355-2-mike.kravetz@oracle.com> From: Miaohe Lin Message-ID: Date: Sat, 17 Dec 2022 10:01:54 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20221212235042.178355-2-mike.kravetz@oracle.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.151.185] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: BC9C3180003 X-Stat-Signature: xaxq65gkm6ujn5dco5f1b564sdhecgw1 X-HE-Tag: 1671242518-550878 X-HE-Meta: U2FsdGVkX1/0poQzfER1Eemftk3FwVeD4d0YQsXa6I47UKoa2NV+IqXR+SbdTqJD3sA0fe6gIBynO6+TpXBWlyJUrUT8zarpPEn8KmiKTeJLcYE/c7ZWhvPNMtxCYTGIWLhQjULFoF2m85CYUWp/nwFhrJSF/0V5CxHcUm6NCfDl5w6hzggf4OtC1cLQ/putSdnMd65TADgHAazXmdkGCgXBCMUILpokf0E+C9QhU1hlxRPpJjRoeTL9lsTsW4qstFdyCbEHFBkgJxXNeAISu0lOuTZ28kw3ODN34fpABW5htmCd27ZrGLLd/OZ2Q3Xn36Qpm8FCXTMEOc8duSVNStqRC7fN1dUYtGZtBRsF60rNcI8K47zcut5L5Qk5otXx+wIJGS0Xijusri1GWQzbqirWtfDdUpCHJM0Xhyr5O/laBEjAUcUD14NDooQBIzg2AAcLrNXK1kXMi5pR1rnqASTgwrB+WJ2uwid+ZKqTTtt8WRQ/BrdQF91cHjZkSieE5fv8J3EE9z0wGeaYNLT7vGXDkwUtZBCAFJM48xDCl5KRFbuqkoWH2deuTjA/lqBF4WQ3MqfRfYVWtEMHpgDp1C3F7cTDnflyy0m1q2h8JoIePiI5snypx2qzgwbp/zqGWyfO75pHl6VBtvtWUInUJo5StnsUhcVG4BuijooUJGF3+s+hB4rDNhjF5ePUAAPYfuU1VNPUQ/6UyoUpoLOFnBuZlGHDTRXz3XAYgI9q8L0ebC/G68vpQRWMNLiFExhV6Rd5nWCvfstFxMRhHZjvbjHl9chRrRWjdj1qOR+JxhedhGsBMBjs4jy1dhxIA4dTnNzBmVeCCD0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/12/13 7:50, Mike Kravetz wrote: > The check for whether a hugetlb vma lock exists partially depends on > the vma's flags. Currently, it checks for either VM_MAYSHARE or > VM_SHARED. The reason both flags are used is because VM_MAYSHARE was > previously cleared in hugetlb vmas as they are tore down. This is no > longer the case, and only the VM_MAYSHARE check is required. > > Signed-off-by: Mike Kravetz Nice cleanup. This is also what I planed to do. ;) Reviewed-by: Miaohe Lin Thanks, Miaohe Lin