From: Miaohe Lin <linmiaohe@huawei.com>
To: Mike Kravetz <mike.kravetz@oracle.com>, <linux-mm@kvack.org>,
<linux-kernel@vger.kernel.org>
Cc: Muchun Song <songmuchun@bytedance.com>,
David Hildenbrand <david@redhat.com>,
Peter Xu <peterx@redhat.com>,
Naoya Horiguchi <naoya.horiguchi@linux.dev>,
"Aneesh Kumar K . V" <aneesh.kumar@linux.vnet.ibm.com>,
James Houghton <jthoughton@google.com>,
Mina Almasry <almasrymina@google.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 2/2] hugetlb: update vma flag check for hugetlb vma lock
Date: Sat, 17 Dec 2022 10:01:54 +0800 [thread overview]
Message-ID: <a494ecba-2fab-f39f-6d6d-9ab43d080988@huawei.com> (raw)
In-Reply-To: <20221212235042.178355-2-mike.kravetz@oracle.com>
On 2022/12/13 7:50, Mike Kravetz wrote:
> The check for whether a hugetlb vma lock exists partially depends on
> the vma's flags. Currently, it checks for either VM_MAYSHARE or
> VM_SHARED. The reason both flags are used is because VM_MAYSHARE was
> previously cleared in hugetlb vmas as they are tore down. This is no
> longer the case, and only the VM_MAYSHARE check is required.
>
> Signed-off-by: Mike Kravetz <mike.kravetz@oracle.com>
Nice cleanup. This is also what I planed to do. ;)
Reviewed-by: Miaohe Lin <linmiaohe@huawei.com>
Thanks,
Miaohe Lin
next prev parent reply other threads:[~2022-12-17 2:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-12 23:50 [PATCH 1/2] hugetlb: really allocate vma lock for all sharable vmas Mike Kravetz
2022-12-12 23:50 ` [PATCH 2/2] hugetlb: update vma flag check for hugetlb vma lock Mike Kravetz
2022-12-17 2:01 ` Miaohe Lin [this message]
2022-12-15 22:37 ` [PATCH 1/2] hugetlb: really allocate vma lock for all sharable vmas Andrew Morton
2022-12-15 22:50 ` Mike Kravetz
2022-12-17 1:59 ` Miaohe Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a494ecba-2fab-f39f-6d6d-9ab43d080988@huawei.com \
--to=linmiaohe@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=almasrymina@google.com \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=david@redhat.com \
--cc=jthoughton@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
--cc=naoya.horiguchi@linux.dev \
--cc=peterx@redhat.com \
--cc=songmuchun@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox