From: Dave Hansen <dave.hansen@intel.com>
To: Nadav Amit <namit@vmware.com>
Cc: David Hildenbrand <david@redhat.com>,
LKML <linux-kernel@vger.kernel.org>,
Hugh Dickins <hughd@google.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
X86 ML <x86@kernel.org>, Linux MM <linux-mm@kvack.org>,
Dave Hansen <dave.hansen@linux.intel.com>,
Peter Zijlstra <peterz@infradead.org>,
Andy Lutomirski <luto@kernel.org>
Subject: Re: [PATCH] x86/mm/tlb: ignore f->new_tlb_gen when zero
Date: Fri, 8 Jul 2022 10:01:37 -0700 [thread overview]
Message-ID: <a486ad3f-8fb6-c37b-9e7e-c6ba1a841b57@intel.com> (raw)
In-Reply-To: <A604C6DA-5E5D-43F1-B63F-EF9D145CACCE@vmware.com>
On 7/8/22 09:54, Nadav Amit wrote:
> Since the bug was not during MADV_DONTNEED there is no reason for the
> results to be any different.
>
> Famous last words?
Considering that your patch broke the kernel a way that surprised us
all, I think caution is warranted. Re-running a microbenchmark that
takes five minutes and stresses things a bit is the least you can do, I
think.
next prev parent reply other threads:[~2022-07-08 17:01 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-08 0:30 Nadav Amit
2022-07-08 11:40 ` David Hildenbrand
2022-07-08 15:13 ` Dave Hansen
2022-07-08 16:54 ` Nadav Amit
2022-07-08 17:01 ` Dave Hansen [this message]
2022-07-08 17:09 ` Nadav Amit
2022-07-08 18:03 ` Nadav Amit
2022-07-08 14:49 ` Dave Hansen
2022-07-08 17:04 ` Nadav Amit
2022-07-08 18:54 ` Dave Hansen
2022-07-11 5:19 ` Nadav Amit
2022-07-08 19:21 ` Hugh Dickins
2022-07-08 20:02 ` Nadav Amit
2022-07-08 20:48 ` Hugh Dickins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a486ad3f-8fb6-c37b-9e7e-c6ba1a841b57@intel.com \
--to=dave.hansen@intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=david@redhat.com \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=namit@vmware.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox