From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6D32C4167B for ; Mon, 4 Dec 2023 09:05:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 271A96B0249; Mon, 4 Dec 2023 04:05:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 221256B024D; Mon, 4 Dec 2023 04:05:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 09C196B0274; Mon, 4 Dec 2023 04:05:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id EDC836B0249 for ; Mon, 4 Dec 2023 04:05:54 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id BE1AB40138 for ; Mon, 4 Dec 2023 09:05:54 +0000 (UTC) X-FDA: 81528553428.21.AD53BD5 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf05.hostedemail.com (Postfix) with ESMTP id 7B993100006 for ; Mon, 4 Dec 2023 09:05:52 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="b9MO7/al"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf05.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701680752; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=54yj0/Ej7pqackj9Q5yMm8Vqxd8rRbXrGNCkl/ms7ok=; b=z3PAJZX9TZSwrY3lNqQ+8YA+XX7SEf6DDa5fl95FsdnXlSftajquFRuWzPXKzgqcnma+jP NfAVN4mS+gNUV+uhM/rsoFI05IWb669bgmEYxdvBJ5GvHLH5A2u6FE1G53z6RyuRsmbEql lWuuEyBL3HZ7IGzZ97EUGgnnkFd855k= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="b9MO7/al"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf05.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701680752; a=rsa-sha256; cv=none; b=6E38mfeCL08CWgKzro09O3z3E/Y5moNXyzThVAR6XpUhEJPYx2eH6O1z3wucDZJNle07Y3 E9DAk5nE++Wkrcihm85dpB9XUDS+bzluvoAmF6R9go0YorxbE6NUEck8t026JoGg9Dv+ld W/2vbxi77u+Bmnvbi19be+U758+yuJI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1701680751; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=54yj0/Ej7pqackj9Q5yMm8Vqxd8rRbXrGNCkl/ms7ok=; b=b9MO7/alOO0WwBfMaYJ1ciZPsl2NnDLj8XoKiuVx97mD2Dh8qXyHrstntvbdu/eoKDY2Ed osiohaPQCrcIM0PQ4uev8MBTq0IeoE8PS0/Bvbx05bSDAy6UCaM6T+Olua9AWcJ/C79WFi gRac+7anR7r7g6mhEeVUcw/VzFsLtbM= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-214-fV-5BrrXOrSJWY8bim5lkA-1; Mon, 04 Dec 2023 04:05:50 -0500 X-MC-Unique: fV-5BrrXOrSJWY8bim5lkA-1 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-3333c009305so1587224f8f.1 for ; Mon, 04 Dec 2023 01:05:50 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701680749; x=1702285549; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=54yj0/Ej7pqackj9Q5yMm8Vqxd8rRbXrGNCkl/ms7ok=; b=CTT8/TK0ZDSDxT/L0oupzoYdw0ppaQcTk/U27H8NpHi9bZmM6RBH8Mo+OfW0837qNy PtvcUL+AEhIj4vu5K9Nww92dCrHVblnQRBH3fD4lZjBomdSDX37vLaytAm/wacAEDmHw c/DBsQzajbROsEfg38zs2tl9akACVZwJbFcxcXgeagnPVHHnmnI+qvZSDSMhs+fpgNwG KOwv2Cz+pFN+1FKrkGwDqihhxUK4XnMnmRJnK1JafGvcwzP02R2m0L+Xc3dgZfHkNo02 okp3rSkZux04kuhLjfFz1AgoE+td68ou06O6QajExmQDvIjMpCQXetwquA+15NSi31hH GkKw== X-Gm-Message-State: AOJu0YxQoElc4wQ/qRxjSA8qsfqgS6Qp0hZDxR7iO/qSpUbiVaK86wWl dXx6HRk2hP7jAk8ivgobzW/8K1/6zR21tVniq2CL12R2u16R9iCFp5lVxRBMyfe9e5sRYfvs0n5 XPg1b41aK/MM= X-Received: by 2002:a5d:6648:0:b0:333:2fd2:51f5 with SMTP id f8-20020a5d6648000000b003332fd251f5mr3372464wrw.110.1701680749443; Mon, 04 Dec 2023 01:05:49 -0800 (PST) X-Google-Smtp-Source: AGHT+IFqEx0v/CwBWVoaKyxmmKjNkGZ8fWec1MHBaeDTfzCZaNupLsUv6SxtQte2jJM/O3ZCG+h6xQ== X-Received: by 2002:a5d:6648:0:b0:333:2fd2:51f5 with SMTP id f8-20020a5d6648000000b003332fd251f5mr3372452wrw.110.1701680749030; Mon, 04 Dec 2023 01:05:49 -0800 (PST) Received: from ?IPV6:2003:cb:c722:3700:6501:8925:6f9:fcdc? (p200300cbc72237006501892506f9fcdc.dip0.t-ipconnect.de. [2003:cb:c722:3700:6501:8925:6f9:fcdc]) by smtp.gmail.com with ESMTPSA id v15-20020a5d4a4f000000b0033328f47c83sm10296440wrs.2.2023.12.04.01.05.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 04 Dec 2023 01:05:48 -0800 (PST) Message-ID: Date: Mon, 4 Dec 2023 10:05:47 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 3/5] mm/gup: Introduce pin_user_pages_fd() for pinning shmem/hugetlbfs file pages (v5) To: Christoph Hellwig , "Kasireddy, Vivek" Cc: "dri-devel@lists.freedesktop.org" , "linux-mm@kvack.org" , Daniel Vetter , Mike Kravetz , Hugh Dickins , Peter Xu , Gerd Hoffmann , "Kim, Dongwon" , "Chang, Junxiao" , Jason Gunthorpe References: <20231123064443.1035709-1-vivek.kasireddy@intel.com> <20231123064443.1035709-4-vivek.kasireddy@intel.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 7B993100006 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: 4mti8ghzahzxd1x5ttxseouwysya6759 X-HE-Tag: 1701680752-977510 X-HE-Meta: U2FsdGVkX18nDNaWzmaEILG0QQ1rYlpsMIaniSHSeven5YLisUEPMlx8HCa2F9gVhgBBBNXfkefsOHehOJkkrJ9x2J2gtcmEGCTKWrvcXnCL/GAisqJqUPr6R4ZMcqtCNqYs5UkgD/AEcDLaCondJEkyeibn311Kgx5dYLpEW5rWuA2smHIT6igb9+9bqUnSZyxlyfshq/xmJTyneIIPxCqvsbsHWiurXN8CFAqqwnnoQhwVgvJVLI23mHgPuJ5rSOf+F2kEjZYFrnSgDUmPVqkLUAy4uWdi+Gq59OlYADVv5U2ikO4N6pCH1RHkcNfGlqT4UR0BR47QyWZHpKfhL5er0StpV8FNvy9hKqSs2J+C6tNYoSsKIl/PIEZ81XincyjspvU3LbvP0RREBrnczKQwx4c3XckpIXSKZDbpiYVfHZCUpo919Dr5MicxZmZmGi2tjuK4Pvc1QBPg8fPTsk1097yjCv9gnxd2ock4A52vCn9/0bRFXdee7+720IqZHPOX+1yPrIRO3xWTw1JQ24z3IX57Jr1oI3/4RQEpUjbiCOTZKOcP6W5oMyZ4Wlz5qhoEd9YVtOOXEQOSLcT0CKNGWTkObBlEBrt2p6vTfSKw8z1FGBTkLA8Tq3ONNqRtxhcuK0R3V42C5aRiugFoSVaO/U2nz5WRiRMGhhXdYaYdR27yTtusgwoLv3h1TmQskakxzgwuWBAwuAXb4yRz8HC9kvsXjEOgf+z9QzQaHWB98zf9/skb2Dc5wgvceJclXQqcL7NkjsZvYNBeAJbh3YtMnThpEajgkT6YJIFHh9bBgZBkRH8LP6N+Nvr1KRiyEWLrvAkh5xaI/BAiN+7qelaHLkZiyeI4oSTQJrp86F7978LSjBBYsss71pc8PTXpX3Kc93TTt342CTCVjZ5oxlgIDjEUvbg9ENyaT7ErsO9JeMfilCcrd9iXqRqE7e1qN1Zaj1lvvvAVgXfaDhi 6UZJTNhh aK/dnXEvmA1NClc74Z3872RdPfUw5DOBVC+Gp1XOeuvDrQttehhJi3I33MoL7/J6JmlKehmjUdUyV+0MFlC8SoAfqM7RNQ2yhwvEuUQX9xRB15NfDrZrXFFk61nFCT0F51wt1amyr7pRRMYS2LJnFlh7S63iWxMddOdLthp0AvtJtiRyOmPW6Q9/VjtnoWtoSWHOsNuVKSvF+J9kOiIDq6/DrjoREEVUhk2PlOHD1HHQA62a3YPUaZ2DNN0R3zRdef7jLt1Zdq/rBTzeHfDpaX32U0Eqjs0gh3/ElD23G0hPVZYoexdhuW4R9gRFlmtuOPBBCam8NM1GDkMVEseLsY/TyngkC5LbbT5GWtuAONSAQJUfIs7xPGxt4uqdBth+uDL1JMo3NxFILjq0mM/uuUx7SRDRR0bZf1gAEP2kzDCnt/9Q0QjyGNkGr98rjA/LILpydRr41x3qZeLjqPwoKNdU+jABaC0C8GAq+aDNlsboT8hpiYUhfaM9F6dsKwPnhsDOP X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 04.12.23 09:16, Christoph Hellwig wrote: > On Thu, Nov 30, 2023 at 06:41:11AM +0000, Kasireddy, Vivek wrote: >> I see your concern. The word "file" does make it look like this API works >> with all kinds of files although it is meant to specifically work with >> files that >> belong to shmemfs or hugetlbfs. Since it is intended to work with memfds >> in particular, I'll rename this helper alloc_memfd_page(). I think it also >> makes sense to do s/file/memfd in this whole patch. Does this sound ok? > > That sounds much better, yes. And please also rename the new api > to memfd_pin_user_pages。 > >> >>> asserts that this is true). gup.c also seems like a very odd place >>> for such a helper. >> I only created this helper to cleanly separate lookup and creation and to >> reduce the level of indentation in pin_user_pages_fd(). Anyway, would >> mm/memfd.c be a more appropriate location? > > I think so, but I'll defer to the MM maintainers. > >> As mentioned above, this API is mainly intended for memfds and FWICS, >> memfds are backed by files from either shmemfs or hugetlbfs. > > Ok. Witht better naming this should be more obvious. > > All sounds reasonable to me! -- Cheers, David / dhildenb