From: Vegard Nossum <vegard.nossum@oracle.com>
To: Dennis Zhou <dennis@kernel.org>, Mateusz Guzik <mjguzik@gmail.com>
Cc: linux-kernel@vger.kernel.org, tj@kernel.org, cl@linux.com,
akpm@linux-foundation.org, shakeelb@google.com,
linux-mm@kvack.org
Subject: Re: [PATCH v3 1/2] pcpcntr: add group allocation/free
Date: Thu, 24 Aug 2023 12:01:44 +0200 [thread overview]
Message-ID: <a482222a-8ade-1b31-09bd-1977171aae08@oracle.com> (raw)
In-Reply-To: <ZOb4Mwv5eFv2n7R8@snowbird>
On 8/24/23 08:26, Dennis Zhou wrote:
> On Wed, Aug 23, 2023 at 07:06:08AM +0200, Mateusz Guzik wrote:
>> Allocations and frees are globally serialized on the pcpu lock (and the
>> CPU hotplug lock if enabled, which is the case on Debian).
>>
>> At least one frequent consumer allocates 4 back-to-back counters (and
>> frees them in the same manner), exacerbating the problem.
>>
>> While this does not fully remedy scalability issues, it is a step
>> towards that goal and provides immediate relief.
>>
>> Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
>
> I'm happy with this. There are a few minor reflow of lines that I'd like
> to do but other than that nice.
>
> If there are no other comments and it's okay with Andrew I'll pick this
> up tomorrow for-6.6 and the corresponding changes to fork.c.
>
> Reviewed-by: Dennis Zhou <dennis@kernel.org>
FWIW, the new version also looks correct to me.
Reviewed-by: Vegard Nossum <vegard.nossum@oracle.com>
Vegard
next prev parent reply other threads:[~2023-08-24 10:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-23 5:06 [PATCH v3 0/2] execve scalability issues, part 1 Mateusz Guzik
2023-08-23 5:06 ` [PATCH v3 1/2] pcpcntr: add group allocation/free Mateusz Guzik
2023-08-24 6:26 ` Dennis Zhou
2023-08-24 10:01 ` Vegard Nossum [this message]
2023-08-23 5:06 ` [PATCH v3 2/2] kernel/fork: group allocation/free of per-cpu counters for mm struct Mateusz Guzik
2023-08-24 6:28 ` Dennis Zhou
2023-09-06 8:25 ` kernel test robot
2023-08-25 15:14 ` [PATCH v3 0/2] execve scalability issues, part 1 Dennis Zhou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a482222a-8ade-1b31-09bd-1977171aae08@oracle.com \
--to=vegard.nossum@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=dennis@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mjguzik@gmail.com \
--cc=shakeelb@google.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox