From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3AF17ECE58D for ; Tue, 10 Sep 2024 13:29:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 09EC38D006A; Tue, 10 Sep 2024 09:29:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 052138D0002; Tue, 10 Sep 2024 09:29:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C8A7B8D006C; Tue, 10 Sep 2024 09:29:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 8FC248D006A for ; Tue, 10 Sep 2024 09:29:26 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 00BD2803E2 for ; Tue, 10 Sep 2024 13:29:25 +0000 (UTC) X-FDA: 82548910332.12.CABEBC7 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf25.hostedemail.com (Postfix) with ESMTP id 8B9F7A0019 for ; Tue, 10 Sep 2024 13:29:23 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=vZRg2DFJ; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=HMIm890K; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="L/HvcHR9"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=snrQm5Ay; spf=pass (imf25.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725974862; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mOYVq6F7Ob2XxqE+z2md4uwqaGeL3XgktjUkUkC12Ak=; b=aJqmKPRE+oRwGu6884EBW400C/c2N0ysF2AFgI2TFHYy59yVu8ipFkh3zyed0iUzelLmKb 1/337n1A7z/LzXsVgDTs3cNGMdQ2Dweg0shDo800bjbsTg0U5XdeD0h/XFe5PSSidbBsYx qUyeWTBXI3wCCkm/8YVouGUtAbNnwJY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725974862; a=rsa-sha256; cv=none; b=tES0iwzy+dopvnxTX2hzj1kphfnI8d6P3rS1tpfLvzED0ibWl+RQDaujIUvRDZZ1AhfpZ4 oxMajGCRjiKUTzC0Eo1mf7wWGlqITM7qYbC8NeZvmbkEBT1G/ogE+avNeVLsvX2hyL17i8 fHD2xVpHpN4q1jlYqTot60GupvsIDXA= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=vZRg2DFJ; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=HMIm890K; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="L/HvcHR9"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=snrQm5Ay; spf=pass (imf25.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id CD9AD21227; Tue, 10 Sep 2024 13:29:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1725974962; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=mOYVq6F7Ob2XxqE+z2md4uwqaGeL3XgktjUkUkC12Ak=; b=vZRg2DFJSoZNByty4lOn+iwTq1ziQYlWhkUEqSyuRtgbCr1BIBq1gqrRKXEKF5v+hvQTLi qWTD6tO0uO6bKo44Z4YUOyxhOzf5BtiFqFOJnV97klBoGd8rS+5cuvljXGLcnsjVpIunxp t84zAe+PDuiGEr9/5kWWz+MFiuCH0H8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1725974962; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=mOYVq6F7Ob2XxqE+z2md4uwqaGeL3XgktjUkUkC12Ak=; b=HMIm890Kr2Q8KMzPi42t1z4hDueXmnhdAliJ6Lv8U/yb0r/y57rUv9di1vyA4/y6glxXxu ZCxBWch0CJPO0LAw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1725974961; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=mOYVq6F7Ob2XxqE+z2md4uwqaGeL3XgktjUkUkC12Ak=; b=L/HvcHR9f2AQgXiYJlljMzVDaOG0bHY8DPL81hlaQIVr2TWaBmHKqoIjVgfupQnaoJCszy crRlOOHTNlfB7e7HPlwh6S2d1zKf6pV9ctrBtfGGybk5dfweZGi6vBDxYLhboiFKkNmqRe kT4jqYnxU5Xj4gaDFeS94RTz9qT+MTo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1725974961; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=mOYVq6F7Ob2XxqE+z2md4uwqaGeL3XgktjUkUkC12Ak=; b=snrQm5AyPTq5KGehkd+P5kroleD3JyAL+qdpGlafEVuXbVhQm4inqhIzo7Y/MMLmFRmKpO HfSQznM31huX47DQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 9D82113A3A; Tue, 10 Sep 2024 13:29:21 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id dkq+JbFJ4GY+HgAAD6G6ig (envelope-from ); Tue, 10 Sep 2024 13:29:21 +0000 Message-ID: Date: Tue, 10 Sep 2024 15:29:21 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 5/5] mm/slub, kunit: Add testcase for krealloc redzone and zeroing Content-Language: en-US To: Feng Tang , Andrew Morton , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Andrey Konovalov , Marco Elver , Shuah Khan , David Gow , Danilo Krummrich Cc: linux-mm@kvack.org, kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org References: <20240909012958.913438-1-feng.tang@intel.com> <20240909012958.913438-6-feng.tang@intel.com> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: <20240909012958.913438-6-feng.tang@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 8B9F7A0019 X-Stat-Signature: 9x8gdcn3whuxmnoh1d5yb5uogzyuq89n X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1725974963-45261 X-HE-Meta: U2FsdGVkX18NZ5cNViJJ28/xqn8v3IEAB97W3nnINY1Q9wknOg/jHr/7C7aqF6XvHkdufYp1Lsn6eNpXV++YeyqFaL5Wi6uKtfmuexvHvyY4PKD/AVdYfhbZYrtIcmeDrGp1h1ELtdS95FbmvBz7vs7Zfp+MAa4Hw17JDWrrGCHL7th2nZL6XEKp9nn1UP09RtGIt+K1vpMMK4QaZ0GoQhCfvjfR5JknQrA/uptNTFCuOAg0jKPlQRu2g0F1JzVYeb2Rd9gOG0nAOFHRU8KLXmHjMJf0TUsMr3CoxofA3ZGNEtwrpt1TpQ80m0A2YAnwGdIgf1kVhhfw+WoVFc3S29EvvAABvcS8x1qpRMjOonZhiGSIhaiTGtwXnn8Wm6dFmgN0PvS5VWSy+hIGs7W20l46MhYGX0SjnfGcs2Bq6wSNwCETJF+YA70jJ+lJK6PAqStu2PzIAIMkD9inB1QI2CD6b1W9dJ/y2p1GRluNlHRgbCFhyRF9TOattY7CI56bgGSPMM7CTu1AsZTeRnU35/CNCHJxFSbGx4gkHXq7y0ghT2t7QVdJrvtxBn1Brm0GWTpplxALLlzIW8EOqt0iB535vRgZM6huQhIDOP+zhxda55KR4913oajXhIJhVetrKPoRN3GXUJmHQTXBEp8ZDARH3ztJwRlVH5LJjrYDwypnYXWlFc7z97v+8tZtnP9yQEKMOvUSJWI+nXtb6IoVfx8retnU5bKK1AVQ59ObQkwoMjk/8MLwH3VviAg5x76cJIS51eP/vkPxm4wHLkWv/K823Km0iwCiIU222MlM742VGnQM68MN/WgFa6Vwt7+s0hOCQjdcQVSGbJWOYFUSs0iE5pIT0dRZjJVTlkh1SwLGWfMk22QFutia4VYq9CmlqE78S6aafiSg+hTjx+zXMePp0DUiuYIrx+gXKcsjOjAXDqFQBEPYhspQ1306QwKpRKBYYWYijbhsygmIJs0 muSHV2Jt bslRBJfgBuOkhObvBO285qZhz1JZY2SffYRFMBf0Yz1Qqa0b4c8yyj5VL0ITY99ORckUw9QQAABaUfy9NWsnXJchP9nCweC/k0QwsAF+aH0kFyYY1DF1JJIHGi66PrnxZk/BHgNV2SNsO9U7UYaw5TlTSxx4qwWzDRjD7m7soohKZfj4TOUBoDif5UKSQ2ybiZijusU4VOOLqhAdlCeGJBn2AgTGOYAXZRlvBuEEX/f1BgwyXzpLqkWqqorQjJcowQXVmpAJqbmCsFpg1BnW3GvS8TMZuYeWONEk2+fVbk/0P/fH/NzTuTnWlDOX1NHQrInf1gNHJGx4Mr30io/luXt/KmIHEHd9JnwHE69GIWo+9xngDW2F3JLkipQ650hO13ilVR5eqbfuNUKf/p6VNcmFp+k3+neHT+DTW X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 9/9/24 03:29, Feng Tang wrote: > Danilo Krummrich raised issue about krealloc+GFP_ZERO [1], and Vlastimil > suggested to add some test case which can sanity test the kmalloc-redzone > and zeroing by utilizing the kmalloc's 'orig_size' debug feature. > > It covers the grow and shrink case of krealloc() re-using current kmalloc > object, and the case of re-allocating a new bigger object. > > User can add "slub_debug" kernel cmdline parameter to test it. > > [1]. https://lore.kernel.org/lkml/20240812223707.32049-1-dakr@kernel.org/ > > Suggested-by: Vlastimil Babka > Signed-off-by: Feng Tang > --- > lib/slub_kunit.c | 46 ++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 46 insertions(+) > > diff --git a/lib/slub_kunit.c b/lib/slub_kunit.c > index 6e3a1e5a7142..03e0089149ad 100644 > --- a/lib/slub_kunit.c > +++ b/lib/slub_kunit.c > @@ -186,6 +186,51 @@ static void test_leak_destroy(struct kunit *test) > KUNIT_EXPECT_EQ(test, 1, slab_errors); > } > > +static void test_krealloc_redzone_zeroing(struct kunit *test) > +{ > + char *p; > + int i; > + > + KUNIT_TEST_REQUIRES(test, __slub_debug_enabled()); AFAICS this is insufficient, because the static key may be enabled due to debugging enabled for different caches than kmalloc, or it might not include both red zone and object tracking. But it should be possible to instead create a fake kmalloc cache of size 64 and use __kmalloc_cache_noprof() like test_kmalloc_redzone_access()? > + > + /* Allocate a 64B kmalloc object */ > + p = kzalloc(48, GFP_KERNEL); > + if (unlikely(is_kfence_address(p))) { > + kfree(p); > + return; > + } > + memset(p, 0xff, 48); > + > + kasan_disable_current(); > + OPTIMIZER_HIDE_VAR(p); > + > + /* Test shrink */ > + p = krealloc(p, 40, GFP_KERNEL | __GFP_ZERO); > + for (i = 40; i < 64; i++) > + KUNIT_EXPECT_EQ(test, p[i], SLUB_RED_ACTIVE); > + > + /* Test grow within the same 64B kmalloc object */ > + p = krealloc(p, 56, GFP_KERNEL | __GFP_ZERO); > + for (i = 40; i < 56; i++) > + KUNIT_EXPECT_EQ(test, p[i], 0); > + for (i = 56; i < 64; i++) > + KUNIT_EXPECT_EQ(test, p[i], SLUB_RED_ACTIVE); > + > + /* Test grow with allocating a bigger 128B object */ > + p = krealloc(p, 112, GFP_KERNEL | __GFP_ZERO); The only downside is that krealloc() here might use kmalloc-128 cache that's not doing red zoning and object tracking.... > + if (unlikely(is_kfence_address(p))) > + goto exit; > + > + for (i = 56; i < 112; i++) > + KUNIT_EXPECT_EQ(test, p[i], 0); ... but this test is still valid and necessary > + for (i = 112; i < 128; i++) > + KUNIT_EXPECT_EQ(test, p[i], SLUB_RED_ACTIVE); ... we might skip this test as the red zoning is not done by __do_krealloc() anyway in the alloc_new case. > + > +exit: > + kfree(p); Ideally we'd also validate the fake kmalloc cache we created and expect zero slab_errors. Hopefully this approach works and I'm not missing something... > + kasan_enable_current(); > +} > + > static int test_init(struct kunit *test) > { > slab_errors = 0; > @@ -196,6 +241,7 @@ static int test_init(struct kunit *test) > } > > static struct kunit_case test_cases[] = { > + KUNIT_CASE(test_krealloc_redzone_zeroing), > KUNIT_CASE(test_clobber_zone), > > #ifndef CONFIG_KASAN