From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA1BDC7EE2E for ; Mon, 12 Jun 2023 10:53:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3CA296B0072; Mon, 12 Jun 2023 06:53:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 353106B0074; Mon, 12 Jun 2023 06:53:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1F33F8E0002; Mon, 12 Jun 2023 06:53:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 0C6D66B0072 for ; Mon, 12 Jun 2023 06:53:58 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id D56B81C7684 for ; Mon, 12 Jun 2023 10:53:57 +0000 (UTC) X-FDA: 80893785714.02.2EABE91 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf11.hostedemail.com (Postfix) with ESMTP id EAA8540003 for ; Mon, 12 Jun 2023 10:53:55 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=yqAuZVZ6; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="pBIB/2+r"; dmarc=none; spf=pass (imf11.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686567236; a=rsa-sha256; cv=none; b=WE6sJOnZLWIdtzZw90oKYrsCdKk1556VCdU4d1G9d9VIvQt4YWsJtEC4JYrYBy+4cbBp0w tiX1LsKenpzErDg8Jy8+gNRmT7N7jZ6KgjgAb9i6lCkMb1AWgQiWt4FFuXpyOGhmXmNhnt pwHfESF02kkWs68XRUBgSxDblRY3gkc= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=yqAuZVZ6; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="pBIB/2+r"; dmarc=none; spf=pass (imf11.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686567236; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TTt2k6tHEMrQxlljTt41YxlVh8IjAJSgQbZ59KJPanM=; b=066YwLc2aPYL4rqoad6HxLd6sBKvoufqGCtyfVKhgXdg4GEkcqXOCFEPcBfA09ER2+eFqt fXSo4KlLTcxP8cLZ2zrUbECsJRNKK/YPCnEhMbBsqSDYD0c3oCyPK3wV3S6o9X8VfWgVda qmhyA5v0vpexS6Yoxut4fcWatw0pyqI= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 594D22019C; Mon, 12 Jun 2023 10:53:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1686567234; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TTt2k6tHEMrQxlljTt41YxlVh8IjAJSgQbZ59KJPanM=; b=yqAuZVZ6Vjc2Smq8sWUAIDdRkMTD/lmH5yRLAzt16FYv1R4utt6cyWelZY66Lg3CEX9Ov7 9i6LY0Sjy5ryUJEOdaMZURyLnkHxRXxhazFbNQ4Y6tBmfKqV5nbTkXAh/zLnqEatHmjMe4 Zx+/g0r2DK6TC9XyXc+9+Ot+o6xzN40= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1686567234; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TTt2k6tHEMrQxlljTt41YxlVh8IjAJSgQbZ59KJPanM=; b=pBIB/2+rilUtHLT3G5tNuJaqwseizOsvgKQJVAX1iEFDdCl+NovJJ6LPiVSBSyBsCGkQmO iNUC/s+/1n/kLgBw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 32B10138EC; Mon, 12 Jun 2023 10:53:54 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id JsSrC0L5hmRiNwAAMHmgww (envelope-from ); Mon, 12 Jun 2023 10:53:54 +0000 Message-ID: Date: Mon, 12 Jun 2023 12:53:53 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [PATCH v5 3/3] mm,page_owner: Filter out stacks by a threshold counter Content-Language: en-US To: Alexander Potapenko , Oscar Salvador Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Michal Hocko , Waiman Long , Suren Baghdasaryan , Marco Elver , Andrey Konovalov , Eric Dumazet References: <20230516182537.3139-1-osalvador@suse.de> <20230516182537.3139-4-osalvador@suse.de> From: Vlastimil Babka In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: EAA8540003 X-Stat-Signature: rfgeqwgec9qbech91a1kkxzmcz7sjzr6 X-HE-Tag: 1686567235-704924 X-HE-Meta: U2FsdGVkX1/CiopcoDG9LthYbMSBsrdHWuB+WEPqmcwzGXAMcJQ89r8jE5eoJrMqZ7Ack9d8EVDuLQGoBX1f2K7wlxHg1i5OnFEoUzBJTmD7lACT43P2l/FutSvrw6frjjtQDzFaZ8fZv3D5naCpXda56KhHUIMffA3dQ0rmgwFRv48kqQVKqhnn7IwHXjwNuiUrffBy5nYs5jKECAOFxGrbvpgykDiXYUEDXBuPOSyPSJd+571RVH3NdcI9jw47CrweSmaHjiClKNJYPrueJLoeaylN4IV1geyDgSOUP48HQ1PEEQaTNyX3PLRPpKCNWfNb5XLKxSPh2AXINWu/CDiZ2DOTjY/AxIlOilpTHINkg2gI847oggK+6Q2ghct2CXOuTf/X6VkFT+P07HxH2wZEtXS9xBhhVQ+yEjy/18xDpND77ksBecaYdwvyc0cIi51SYZSnX26vbvkaZvwk3UvOJElfrnoAJd+1Mgy0WyhjYyigkJfEiVZVZu6oOOkNQHko0fVyrGh+buQOd/c24tkbI525xPsNwbB2qMfoCCY5PjNpVC1gNhX+RBnxInBSHn1T8osl+hkNJgHDnSwmWiLLgJTuwKC0txmK1VI+9jDFgKRTgtzpIg7ZTGA0dh/67H0T7vUkat2dBhlS+hrzhKVfIxKfwysYAHqk+PTgYVXOqk8hhdkzXsIscEpGX0RenREPMz7ujsWTA4w95Ixxs8O1pSueA2iASl10j51k8VVA6FIrAlpgmR9GF/0Nn3Pe80S+3Fr+C35SLUmkmPcmT+SfGdGLJ/Up269JQGQvhRAgOJDelJ7xo5ZkFH41Pp2rKMZw3NmSHo60+cdza7g9D/TgRQJAbxuC5SW3bwabzlOQN2+ETk0P+2JvgSkTuDTbRKBuJXSCZJ1uXCSQ2Mmq/ChIFeZujmE6ECpV1lgVTHTAOgYm6aBHehbhbbcdpMm84l10CHDcAbxj8rXc10f p5JrvVYp j++52nHrC/UCwXqljTHhVj2MqNmKMulLI0LufcYO9b1Qqs/gxQWtWjjFc5mICgUA3xDavNKCOd/tXzM7RVAZ9DWc930lC3TL4DTs5UOfXfXaNn+MI+fuZmMOFGECoegXvJZBQtUN9a4Lc+BWFfVhbvLPrRtJ8u7M9GAyV5bxknwPle72xmV6gMzlfuU8sHosxpi24Sz/as0ERIRUOTpS7PyeL3lYxXgEZ8Qw67DS9yd+f9MM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 5/22/23 10:40, Alexander Potapenko wrote: > On Tue, May 16, 2023 at 8:25 PM Oscar Salvador wrote: >> We want to be able to filter out the output on a threshold basis, >> in this way we can get rid of a lot of noise and focus only on those >> stacks which have an allegedly high counter. >> >> We can control the threshold value by a new file called >> 'page_owner_threshold', which is 0 by default. >> >> Signed-off-by: Oscar Salvador > Nack. > We must decouple stackdepot from page_owner as much as possible, not > add extra dependencies by sharing variables between the two. > > What you need here is a pair of xxx_iter_start()/xxx_iter_next() > functions in stackdepot.c that will hold the iteration state in a > struct and return the next stack trace. > The threshold value can also be part of that struct. Agreed, that should be a much cleaner approach.