From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B785AC369DC for ; Tue, 29 Apr 2025 13:43:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E0BB36B000C; Tue, 29 Apr 2025 09:43:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DBC0C6B000D; Tue, 29 Apr 2025 09:43:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C0D026B000E; Tue, 29 Apr 2025 09:43:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id A113A6B000C for ; Tue, 29 Apr 2025 09:43:44 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 86ECE160398 for ; Tue, 29 Apr 2025 13:43:44 +0000 (UTC) X-FDA: 83387199168.06.CB3D5B5 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf25.hostedemail.com (Postfix) with ESMTP id 1847AA0004 for ; Tue, 29 Apr 2025 13:43:41 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=QxrvqrVq; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745934222; a=rsa-sha256; cv=none; b=k+15coljkOrv5IOd3Dh2WXwaE23xLB0v/yntnhxLE285slsAoYYy1gKvQKq2P0y3b5yh6H 0dBpKo8Weupy0wbf5H1AbpvWAgN+8sYBlCSXGRbDkv+6A85iJC4GfSKPQVa7j74OQn75ee i1+V6kFbzVZXMquCQAiv7lq3gRTTpZs= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=QxrvqrVq; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745934222; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BhV4LtR6rH7tjK26pAd4SgtsGVLYFiE6TTOLMreULQI=; b=vtGbEHxZMiabtTPcCkWYCGDN//MJlDo0ja5Q/fvdZQdvxVtiQqbDznA+Q8QYNeBP8rvyc+ mp0vsT2ES+FlRP20hov/QmozqRbjCEXxdFjf6M9Nza2UYa/QDg93UhxiXxcV/ibCsFUB0o YN8Db0lUh6SBq1gIkhhm3p8PLEDSz2c= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1745934221; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=BhV4LtR6rH7tjK26pAd4SgtsGVLYFiE6TTOLMreULQI=; b=QxrvqrVq0nruLHKWXFRwa6oqSHqIg0fkklHowvXvCydo25fNiWzqnTKqrkhNi14Mg8cLqX TII04OK7U5lnSmvUGesOKhe+Uq46l3A/aGQTXo6OJPHMviZ7TSk47hx0lOgUKzO9aY6sgC Bst10qH5QrsYircWrtS8FJkLQ/m54ig= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-5-NAzfaeVUPA-PMZuMCh56oQ-1; Tue, 29 Apr 2025 09:43:39 -0400 X-MC-Unique: NAzfaeVUPA-PMZuMCh56oQ-1 X-Mimecast-MFC-AGG-ID: NAzfaeVUPA-PMZuMCh56oQ_1745934218 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-43cfda30a3cso30423255e9.3 for ; Tue, 29 Apr 2025 06:43:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745934218; x=1746539018; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=BhV4LtR6rH7tjK26pAd4SgtsGVLYFiE6TTOLMreULQI=; b=Mx9EWDWkexxDOaDmDKBE9xng50tFmhA+sgBHuJv17ZhHSNBomiNBBWRso2FnJFJOMj BFxUGSuX2w7PK/JBhBZYC28vLu3N0sx9FN9jSl1vr6OO/AvZN02ajQXzxVmM3LyBWejl qYqYPZi8jB4Dy62n9PK2/NgilIl8/ZRiOlon8PTdu/0nxZphRPJsVNXwyRBxm8IDCq7P y7vfTA3FCYP4tFXQ2EySIGdZX3ZXfo3smA5sh53joLEuFcgYDwFS2UiE3kqE1K8NJBqk lSo0WKu9AgvkUwbzgGJw19JZr589q6A0/oNuJU8EOiexJOfTP4RoymW3JOgO9TnyqvlG 4vGA== X-Gm-Message-State: AOJu0YwiRpwOSvmcAorSVOrorU9Pg/AwU7zj40WE217EleJ0013QFWBW +KQU2QEEZZGI722A3E7vrOXZ/x3+CMdBGcewl2fDLwJK937/+rhubisGl30fbjU7hEfwV4RAmBT x5thYVCjQleSrwNi1ZkM8Znq2PsG3jQHqJ2Y3hxjtIyXCvlo2 X-Gm-Gg: ASbGncsfsasOuRRyOH6mXiaB1mLXY2dB4nvRc5F//eifQSb61R+8V8FdCt1uZ622XPj g56XFSDrT9rELI0CM4lgCTkIaGN4znzSZWVm4U1h6VJ2bi4JlaeBhVbwhxdzvNwgMWpBcpaoVXO 6HGqK1Tjtrr9LJKx4lYG1hJ7rdpnbliKuYepH7BcqXxioXIPIrHiyIPhOl4pm7cf9zZfy6o7vcX gtEQMl+odrfLfumCJyh1hPRSQ6S1XzVr7PodNb5y3KnoRuhqECZyImwYlu9lw0tVsKKRsWeQajH sfDZGXISnm5rSMZ+933lByrASgweLJqjIR6AoQIL9IuEGgNVK/nQ46BWFDScRwK/w0CjDaZL3P6 vTiVpCh1ujt3hRYxmT698CtwjV4M6ur78HbjjXms= X-Received: by 2002:a05:600c:1914:b0:43c:fd27:a216 with SMTP id 5b1f17b1804b1-440ab84667fmr100200695e9.23.1745934217909; Tue, 29 Apr 2025 06:43:37 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFSWIjd33+kZMtDCsHq82gJNQDn2QfBZFviMcMkXAENMrQnDu6F7WYuOlizaDi3eZdePdfH+A== X-Received: by 2002:a05:600c:1914:b0:43c:fd27:a216 with SMTP id 5b1f17b1804b1-440ab84667fmr100200355e9.23.1745934217504; Tue, 29 Apr 2025 06:43:37 -0700 (PDT) Received: from ?IPV6:2003:cb:c73b:fa00:8909:2d07:8909:6a5a? (p200300cbc73bfa0089092d0789096a5a.dip0.t-ipconnect.de. [2003:cb:c73b:fa00:8909:2d07:8909:6a5a]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a073ca5debsm14150435f8f.38.2025.04.29.06.43.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 29 Apr 2025 06:43:37 -0700 (PDT) Message-ID: Date: Tue, 29 Apr 2025 15:43:36 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 4/6] filemap: do not use folio_contains for swap cache folios To: Kairui Song Cc: linux-mm@kvack.org, Andrew Morton , Matthew Wilcox , Hugh Dickins , Chris Li , Yosry Ahmed , "Huang, Ying" , Nhat Pham , Johannes Weiner , linux-kernel@vger.kernel.org References: <20250429114949.41124-1-ryncsn@gmail.com> <20250429114949.41124-5-ryncsn@gmail.com> <116d8920-6154-4ed1-946a-887cfe084fe9@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: F_XqOP7knGSUd0BRkfcZkzGKtjH6kjucrcPO8LwfaKQ_1745934218 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 1847AA0004 X-Stat-Signature: hg6q1r7xqaakgup96gaahgwye1a5yywe X-Rspam-User: X-HE-Tag: 1745934221-807306 X-HE-Meta: U2FsdGVkX18ospdCu6WodIdnJ+tdNibdLAzlJWU6IiTU/24R9+tRDZBR3cQKNC/IEmpmoGaNhvNrDehz6P9q/b09WXrycTh4KHPQj5iVKAokmiA04/s3Lbuw1iqNOQo49n5XqqciYd46AdgAX1Fc+m2GWbj4L54kjbjIwDhg/pnxam++96ix1IxdrA0i/tGryv5BCXlBiCtkrkr8BHtEUQUze3nXqzMB4RuQf3yKvmrK+G+vUiROEWE/WgvFp4TX8TnZuuJ+6FNEIkNi3LFEyBY36j9g4BIJfvjoEgBLuQMS8vRBfyLStoLZeAyqFEr3CJHwwexPYkKQCoWsnhnYr3VtYVAGrTikK1QfIr4PKbZHiuoWnyV1y0S+zwlLqMgVWRUJNPHo9Xo2PLH/guZBFYOXSrxkr8ZAW9URam7bI2yg5oG4hB59F/qyVIqMqxHgQ6HMaDI04cow5639pCbbp7hTDzlqKDCaR0HBfHhiifSWjcPVCthRgFcrc7MBriz2dgczeQoXXr01hcLs0xQzSvnTLYqWA4/Nu6+PalXVRXeGPn40WOnPOJbcbeej6DNO0cCj3zVlOba2vJ7qxSRYYYyJItSeurlbQTF+xlITKTOVQUWTSZEGmiUxwb7vcxYzRs5yHiEfXSEdiBuzT3bglVB21hNqHHknf7eaji28hw57XGwST9CjZOFSl4zDtivzp4MQqH3I9FJWGGApTtx8CVfUEd3Y8k0Yh/FvfK/8+tyV1RHhAiNLU95QlvkUoKac4Yaf6OyuajrxChRzrAfXfY5XslVo5hhyNAP4x18xnbm7RGrm9qbtvUUykQoMS61oXpXn9wJiJvs3uyQnF6P5ggkShcoN0fRwfwDtJpfZ+9CQdcecni1ykwsFIHQKkRY1YOhqevxTCjN7ZQ1XX/jfx2komb1h3soxD9WwJTJShmydkh4kmFct2+3ClkIc4csLUfQh88T7JUvLIsBtOFJ hrDT3KLR VgEdicPKEK1+i9LRzRWvrPWcNcCahcj9Y+fRqIqU+K2xopUuZJ2kxZlw0ofuOjlYjuTp1u1BjVPUoeYE68PS/pANUTOM6dVF12RXOGDOVI8NSIs+0evXplN2ne4uvWgsAAmm0aiujXjobO8n5qWdeQnnmu1mAnRomiD+O+OnTgY+J0quiNNiimeeh/eddweFTVqTHO3r5sf0kOElVSgyrRBR80jbtadIXm4d/z+fu5ykykeaZ0+PSapnaNRVTPirskfhKRyRiRBvCI1Lms2sUovtLJ1gNA50hzjpmCwZMhkeTIXlIeavuzdWpte7+VAh8tnRXfcVmgHNOJ3SPcFZKs7O3dz6Q9eeNsQ19IJdHut6Kc0jzYByrQndX4DV7hY5ikIuv2UJTJMa8uBTA61EVi4bzCFE7OaLw7uSD2tIv/WisdGr8YjPah76BoDdzpFSK7ECXu7NbTvVpYl1Hl2zN5AB16h2szr0lLLmdkFOMg1oEbne0FMtR94Wp169VjkqOsgHn8pRj95qnpqo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 29.04.25 15:32, Kairui Song wrote: > On Tue, Apr 29, 2025 at 8:22 PM David Hildenbrand wrote: >> >> On 29.04.25 13:49, Kairui Song wrote: >>> From: Kairui Song >>> >>> Currently, none of the folio_contains callers should encounter swap >>> cache folios. >>> >>> For fs/ callers, swap cache folios are never part of their workflow. >>> >>> For filemap and truncate, folio_contains is only used for sanity >>> checks to verify the folio index matches the expected >>> lookup / invalidation target. >>> >>> The swap cache does not utilize filemap or truncate helpers in ways >>> that would trigger these checks, as it mostly implements its own >>> cache management. >>> >>> Shmem won't trigger these sanity checks either unless thing went >>> wrong, as it would directly trigger a BUG because swap cache index are >>> unrelated and almost never matches shmem index. Shmem have to handle >>> mixed values of folios, shadows, and swap entries, so it has its own >>> way of handling the mapping. >>> >>> While some filemap helpers works for swap cache space, the swap cache >>> is different from the page cache in many ways. So this particular helper >>> will unlikely to work in a helpful way for swap cache folios. >>> >>> So make it explicit here that folio_contains should not be used for >>> swap cache folios. This helps to avoid misuse, make swap cache less >>> exposed and remove the folio_index usage here. >>> >>> Signed-off-by: Kairui Song >>> --- >>> include/linux/pagemap.h | 8 ++++---- >>> 1 file changed, 4 insertions(+), 4 deletions(-) >>> >>> diff --git a/include/linux/pagemap.h b/include/linux/pagemap.h >>> index af25fb640463..1dc3416a9c0d 100644 >>> --- a/include/linux/pagemap.h >>> +++ b/include/linux/pagemap.h >>> @@ -935,14 +935,14 @@ static inline struct page *folio_file_page(struct folio *folio, pgoff_t index) >>> * @folio: The folio. >>> * @index: The page index within the file. >>> * >>> - * Context: The caller should have the page locked in order to prevent >>> - * (eg) shmem from moving the page between the page cache and swap cache >>> - * and changing its index in the middle of the operation. >>> + * Context: The caller should have the folio locked and ensure >>> + * (e.g.) shmem did not move this folio to swap cache. >> >> The "(e.g.)" looks weird. Maybe "ensure that e.g., shmem ..." >> >> "to the" >> >>> * Return: true or false. >>> */ >>> static inline bool folio_contains(struct folio *folio, pgoff_t index) >>> { >>> - return index - folio_index(folio) < folio_nr_pages(folio); >>> + VM_BUG_ON_FOLIO(folio_test_swapcache(folio), folio); >> >> Likely you want VM_WARN_ON_ONCE_FOLIO() here. > > All its caller will trigger a bug if it encounters a swap cache, so I > kept that behaviour consistent. Let's keep that unchanged for now. I suggest reading coding-style.rst about "Do not add new code that uses any of the BUG() variants, such as BUG(), BUG_ON(), or VM_BUG_ON()". VM_BUG_ON is particularly stupid. -- Cheers, David / dhildenb