From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60CB2C61DF4 for ; Sat, 25 Nov 2023 11:53:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7DD576B05F6; Sat, 25 Nov 2023 06:53:22 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 78D2C6B05F8; Sat, 25 Nov 2023 06:53:22 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 67C156B05FA; Sat, 25 Nov 2023 06:53:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 567386B05F6 for ; Sat, 25 Nov 2023 06:53:22 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 2BDB414030E for ; Sat, 25 Nov 2023 11:53:22 +0000 (UTC) X-FDA: 81496316244.08.6D06AC8 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf11.hostedemail.com (Postfix) with ESMTP id 3649C4000B for ; Sat, 25 Nov 2023 11:53:18 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf11.hostedemail.com: domain of linyunsheng@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=linyunsheng@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700913200; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IaXvOM3rONftJCHCUQtYfnMgexznfpAuGYEL/RTyMz4=; b=c6r8i27tjwXkaz+NoOmlp/jh6n14dX1RZlCWEHpU7cClGXBN92Gw3nZcVcxaJ9d2zeyAy8 4SjBOH3ifsJFJygmZBOzviaiJ3cjm6uENy1MTsaFS34ul7IBo9Mz6NdOVUYVhJuv9gwF6k a3gKg35c8rQ1q79d/B0JliZx5bBotw8= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf11.hostedemail.com: domain of linyunsheng@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=linyunsheng@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700913200; a=rsa-sha256; cv=none; b=wQgYzq3oLebLIT47ae6c29XbvmjsHlgnOZWvK/d4kvys9oPRSBh7qogXPZZpJgdb2OTG7d NFrgAjvqQGmoAO4OcbBwoDqsrcFozrewB+QyZ0u6tKXeDKPk7zWhGeztvMmQubgE1w+E77 zFmW68x6qQ5CfHvz8XkmB6qepDDeohw= Received: from dggpemm500005.china.huawei.com (unknown [172.30.72.56]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4Scqs03j6szsRNM; Sat, 25 Nov 2023 19:49:40 +0800 (CST) Received: from [10.69.30.204] (10.69.30.204) by dggpemm500005.china.huawei.com (7.185.36.74) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Sat, 25 Nov 2023 19:53:13 +0800 Subject: Re: [PATCH net-next v3 1/3] page_pool: Rename pp_frag_count to pp_ref_count To: Liang Chen , , , , , , CC: , References: <20231124073439.52626-1-liangchen.linux@gmail.com> <20231124073439.52626-2-liangchen.linux@gmail.com> From: Yunsheng Lin Message-ID: Date: Sat, 25 Nov 2023 19:53:13 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 MIME-Version: 1.0 In-Reply-To: <20231124073439.52626-2-liangchen.linux@gmail.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.69.30.204] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggpemm500005.china.huawei.com (7.185.36.74) X-CFilter-Loop: Reflected X-Rspamd-Queue-Id: 3649C4000B X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 43ega1sc8ownhubisug3ctawj7mp6dju X-HE-Tag: 1700913198-342814 X-HE-Meta: U2FsdGVkX1/AjK2QL2kMQDGIxEe8qygN4C64yk1N6VVOeUaVYM70zpXHyc22wWxMvPvN3R5/lXXP9BTxJOElEgEQlOgxSRsYrc330MBXWxn2alZTJxDaV1cx50493DXcATL+OOB0uIOi8oZg2L6F/z0iUfU/R9scU+h/V6Sbml3gp1eobgfle3LStEX4sQDP9cQQRqltW8oyg3xNHECa8qE1JsIUPKDKWtiFVF4aF1E9UhYATJIVp+5wjfXy/EzcSUDo5DdfM0QGSvsIuUDadupCvMpgnnlC2nmyZwDJycm2be1o+19OgHq2DrE/seo1c1cRPI1CpX1+LOLrAIawe59ultG4ATo8Lz8XGZBSjBeBh5GkW0A2EQgx68QIZFTF5jcsME3W9GSekqwqghZpEfDrI1RumnRaiuxmOsCiHoMrrsfwneg1tf8V2qapKBGBRZuQPHSjRmdhacJqC+gp4ElZVR6jCQrzp1SyJS/DRF4tRSvsLuX6K8ZbDiYGO6XM3ZZDD+TUt3s+MQN8pYFz1CotnBzdI2cMo74PCnB7XM5cbQ0aUS8MK2KWzrZaqHogGbhFxsETViZ0tct0aKuFo/NIVnMe23HktghXIVDz6FRm3Zsk82r12K3iVeWLKXhiSDssUpazDNSGfuu+RJPZjNu2rTJ3Wu4Z992m0IQ0WPrvPBsS/ecyrWQwGjLuQOMih/X171pr0LhrUmLHonSvZvTsAE/HVS9FtzBxQUejkCb7/liOCT9UrzWFUETaJY+BaeHRPjFusAkr4MVHg0EwuOvSREdvtGthRV8yTbv3oid0xOkK1+P6xz28bIH9VCSoHE6OSGQ7V6Wim8ewabYR5PO/dNXtcPfTMRmTAlA9VEJXKgt1kLrpcxy6FzctKBbINqJj7n35aKKddtXOgwYk8CuZ1wKMCyE0vcyrWITwVYVlJpgq0fXvf6Q2WjOfjTJf+g7thuHBDqe1hR1GqfZ wtEg7OYO 1k99/MEyg/xvnmONWkPGp5nyOVGG7cj891Ez2vyX4Ss3VzwQWLu8dCF0+WXWQqGeCU0RBwzittS0rUwsw1dWJdRljaD9UfCJ8YHNb4FvmE5YoGfHAwXJjkTahL9N6BZm5PLt86F4GfyebGejAPYSamPtaOaWHGeShh4ryncoCf0a9PxfTkytNhsCZTnzPuaHbis1BwdyW8qYMRj7fPD/1pKvK062sN6qi6ZQUb70mJXhz5yQRk8faXbji6kNapfwQtHOskmVNhct82hEbSYHJPD4zVQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2023/11/24 15:34, Liang Chen wrote: > static inline void page_pool_fragment_page(struct page *page, long nr) It seems page_pool_fragment_page() might not be a appropriate name too? Perhaps it might be better to grep defrag/frag to see if there is other function name might need changing. > { > - atomic_long_set(&page->pp_frag_count, nr); > + atomic_long_set(&page->pp_ref_count, nr); > } > > -static inline long page_pool_defrag_page(struct page *page, long nr) > +static inline long page_pool_deref_page(struct page *page, long nr) page_pool_defrag_page() related function is called by mlx5 driver directly, we need to change it to use the new function too. I assume that deref is short for dereference? According to: https://stackoverflow.com/questions/4955198/what-does-dereferencing-a-pointer-mean-in-c-c 'dereferencing means accessing the value from a certain memory location against which that pointer is pointing'. So I am not sure if 'deref' is the right word here as I am not a native english speaker, But it seems 'unref' is more appropriate here if we mirror the napi_frag_unref() function name?