From: "David Hildenbrand (Arm)" <david@kernel.org>
To: Davidlohr Bueso <dave@stgolabs.net>, akpm@linux-foundation.org
Cc: balbirs@nvidia.com, matthew.brost@intel.com, apopple@nvidia.com,
thomas.hellstrom@linux.intel.com, jhubbard@nvidia.com,
jgg@ziepe.ca, linux-mm@kvack.org
Subject: Re: [PATCH] mm/migrate_device: remove dead migration entry check in migrate_vma_collect_huge_pmd()
Date: Thu, 12 Feb 2026 13:37:04 +0100 [thread overview]
Message-ID: <a456f6e2-0494-484f-bc93-dea2b2f53ee5@kernel.org> (raw)
In-Reply-To: <20260212014611.416695-1-dave@stgolabs.net>
On 2/12/26 02:46, Davidlohr Bueso wrote:
> The softleaf_is_migration() check is unreachable as entries that are not
> device_private are filtered out. Similarly, the PTE-level equivalent in
> migrate_vma_collect_pmd() skips migration entries.
>
> This dead branch also contained a double spin_unlock(ptl) bug.
>
> Suggested-by: Matthew Brost <matthew.brost@intel.com>
> Signed-off-by: Davidlohr Bueso <dave@stgolabs.net>
> ---
Acked-by: David Hildenbrand (Arm) <david@kernel.org>
--
Cheers,
David
next prev parent reply other threads:[~2026-02-12 12:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-12 1:46 Davidlohr Bueso
2026-02-12 2:00 ` Alistair Popple
2026-02-12 12:37 ` David Hildenbrand (Arm) [this message]
2026-02-12 21:16 ` Balbir Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a456f6e2-0494-484f-bc93-dea2b2f53ee5@kernel.org \
--to=david@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=apopple@nvidia.com \
--cc=balbirs@nvidia.com \
--cc=dave@stgolabs.net \
--cc=jgg@ziepe.ca \
--cc=jhubbard@nvidia.com \
--cc=linux-mm@kvack.org \
--cc=matthew.brost@intel.com \
--cc=thomas.hellstrom@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox