From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1863C61CE8 for ; Thu, 12 Jun 2025 07:34:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0AD696B0089; Thu, 12 Jun 2025 03:34:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 08C526B008A; Thu, 12 Jun 2025 03:34:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EDCF86B008C; Thu, 12 Jun 2025 03:34:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id D12FE6B0089 for ; Thu, 12 Jun 2025 03:34:42 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 6F04C160A7A for ; Thu, 12 Jun 2025 07:34:42 +0000 (UTC) X-FDA: 83545936404.26.3B18F0B Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf20.hostedemail.com (Postfix) with ESMTP id DBCD91C0008 for ; Thu, 12 Jun 2025 07:34:39 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=iM2RD1e+; spf=pass (imf20.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749713680; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=p3JenDZmdffOaVYnSVPt/myIgL1tW+jk0aEnlDMO+rw=; b=p32/pglpoByvcHS9AMSzKAlCQT9dMNiLtY2l4PlJ4aySjaDRfo1Sp5NGum3xGMwN+GhtMv QCxPhz87YAsTyHmnCY+dRRETVIBiuuQiNqU3dLwNxrwdcRnBrYlcHzDh/e8KMcIOH332zk kp7hvPldExyBctJRQ2WRxGagrqZrqq8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749713680; a=rsa-sha256; cv=none; b=CeObewNfOG1Evta7i6shNPzF3DztvnM2SHFmqbdjXbdadJ94CjLyJSpewgP1TPo7MD2pnp eZtuNWB3Zdfkv9NbtiKo9P/kSzLHqMku84j6FEynEt9Lfas7NLMcisqU3AzGIG8mhKay1M hbFWE6BNB4x0UsRkAkEhGO8pXh82s80= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=iM2RD1e+; spf=pass (imf20.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1749713679; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=p3JenDZmdffOaVYnSVPt/myIgL1tW+jk0aEnlDMO+rw=; b=iM2RD1e+OVdhu1iFgRsNfpAmrbYg07x8CC4+Q74z8KgEyWZ/aAOxCvi1BA3mJR8euLMdQB 49qzX5oH9h/y+wVmHNEe4TB+SotoDANZG4mtOFJOXrp8eybyRBvDB0LJG76r1MPG4m/h9K CAWVlSfGbQgjKBmHnVcnqqlI9G9qT+Y= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-482--9ojW0iAM0W64lifIEx4lA-1; Thu, 12 Jun 2025 03:34:36 -0400 X-MC-Unique: -9ojW0iAM0W64lifIEx4lA-1 X-Mimecast-MFC-AGG-ID: -9ojW0iAM0W64lifIEx4lA_1749713675 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4532514dee8so4712815e9.0 for ; Thu, 12 Jun 2025 00:34:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749713675; x=1750318475; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=p3JenDZmdffOaVYnSVPt/myIgL1tW+jk0aEnlDMO+rw=; b=eMhB0ZFBbB7eBacje0aR/RuVVF3x4U4AcFfx5BgzlN+n6T6qu4atc3nn3yOAlh2GNs a6MmF3/F9sXZL/zeYIvQopg7gCCDSo/Mn+6JqMErhyvScnNLqx4QzD0FLOJnreZIZlMk Oa6fODNoYGCLdR75PcQQL176MrcYTgZqBj8gsBo84Oo7at9f7NNJh/kh3PbupZUr6Bfe 48YCWeM9pFvs7zYYkU/d5gc+1abYVXJH5eFcANyjARQZ1NlvTeriI5iWvI2rJtLsdzPN KPrsRl2sCgO0WaePabkELy8gAVq/zo3EToh1RBqTB79seBAY/J0rEJCFNx33euEHOUZ7 AXfQ== X-Forwarded-Encrypted: i=1; AJvYcCVpfSsvczaGkqFLUBpNKxpKZ9pj0nwyy8/rd4XKLjQ2CwadGxOz+4/QHQFo+Rr6YLBmaSG1NBPypw==@kvack.org X-Gm-Message-State: AOJu0Yz2xwKXrE94URYlA1PdYDklbiMPgNq4XV+whBrLOL2lIrOZPXeM e3HqtS1rm6gaFWb2Bty1cGmsQ7LHEowo7OStVcTCjwCNhS08WlHsEPKAAoq4gNB8kobAcUl5+hq 7YRtQM3VIXYykR8L/7ukqhx+YGJbEIb2pl0M2E3uAWgiq/XtHoD89 X-Gm-Gg: ASbGncvW1H5BRQu2aokP9uRLWm3rmoHn4lL69qxBQo5Z/ghmcml4wmyohJMzlvW2u96 ZsOExM1UJJtkhsiC3LXRyD9VoolJBBPfredwZPx02juN6wJW/kZJq5H9vKU2j9dDe2Ctc9918fY +Che3IVpmhhq9ESzP717H3EgsXdfPm/Nmn6q+M/MJLEsI4UErjwlyfKOE7j5HfbXTUsnHLOo3um owbohZidlGRxwQ7kPys0bMLeuKZ29756wgIpUtTK2aYHyCbvLdGsmWdlH1EADgLwCfhNEtGf9cs P33uBIs7YFkLE6jxC3JyYDZel1byCww01X5fXym5bd9m6OCjJ+mx3U2QlffPcZTEc0FAk7DcCdU xv/1lrC+fiT+YV/dipd3Js8W7OVINLpS3asuDDhTFwbKCpI90QQ== X-Received: by 2002:a05:600c:314b:b0:442:e9eb:cba2 with SMTP id 5b1f17b1804b1-453247d6b1dmr66212215e9.0.1749713674668; Thu, 12 Jun 2025 00:34:34 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEpm8FZysBhfK5FdgNbKwxCA9LHHmCOsPng7ME2OaJNGz/MWqAuec3iQWqzq++f2gekcuzJ2Q== X-Received: by 2002:a05:600c:314b:b0:442:e9eb:cba2 with SMTP id 5b1f17b1804b1-453247d6b1dmr66211895e9.0.1749713674264; Thu, 12 Jun 2025 00:34:34 -0700 (PDT) Received: from ?IPV6:2003:d8:2f2c:1e00:1e1e:7a32:e798:6457? (p200300d82f2c1e001e1e7a32e7986457.dip0.t-ipconnect.de. [2003:d8:2f2c:1e00:1e1e:7a32:e798:6457]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4532e2384cesm11371905e9.16.2025.06.12.00.34.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 Jun 2025 00:34:33 -0700 (PDT) Message-ID: Date: Thu, 12 Jun 2025 09:34:31 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 0/3] mm/huge_memory: vmf_insert_folio_*() and vmf_insert_pfn_pud() fixes To: Andrew Morton Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org, Alistair Popple , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Zi Yan , Baolin Wang , Nico Pache , Ryan Roberts , Dev Jain , Dan Williams , Oscar Salvador References: <20250611120654.545963-1-david@redhat.com> <20250611160804.89bc8b8cb570101e51b522e4@linux-foundation.org> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250611160804.89bc8b8cb570101e51b522e4@linux-foundation.org> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Nykjbzvpr86h_skYPJn67MdYwxlHvRL1zes1BpmwujU_1749713675 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: DBCD91C0008 X-Stat-Signature: gdtcusfgdchaxt7yfrmrkcqb4ss36ea1 X-HE-Tag: 1749713679-802739 X-HE-Meta: U2FsdGVkX18wjBClI4Mwh+qAkGkq9iXSCCkMe7Gjz5XQ1XGtpwVGf9g1zEaUiz5suXJabIo+Slf59kjd90xtidn//Zq+d54ii5s0qlzu6HwR58aM0U/iTRpelj00EjdzfhDXHA8unZ56hwIqKVEt2Uv8/0xnvPsy3tAFKXpFBbyDdEt6Tq4s6QukaKNARtxOIdbhbvNihmV4uaFqSIM6LrvDPyamHvaUEs/JHWAdi6YhdIpgo+qGhgSrsKLIp62IMs1yGzpHmM85oaSB+Z3b389PRu9/fhoYLqLTJtZaRVV+FHeiO3y2J+olJIBFhsMANdkvq5p8I7VMj6ClqbHKNpAdCsEF0oOgDmEkdr61Z0ktCPusgxit1GZzUCNk9UXL8qU+Lb/ICe83w/CwQdEdhjphGqKuDba4LzGcR9NrdZFMUZf2dXgxxNL1w2vjLe6ljayKL1TlOlnE39GcHkkXyzRxdVm4Wtrmy45gY+RZ5G2TyURAivyKiF+hKpwBKQhqJSwF0DM6jsTpPSo1Fcz0kAmjIKkE6IP++beskTjAxh6TYe1FAkXQ5s/O+bGHoWqkSh4icDXV531hHjaglNLMjflyRV8+RNnUkcYKHk4ecyTPFyURRFtwus4wTOXKZdJ9mQ5psShAYwIVIAPvV4piSMjVD7yf6L2VPFKt5i8mJyqMUwwuw58gxDp5UEVCU282o7P+ZIjazJ5txolGwPc5VQVjkCmTejMzpp7xI8iZiTzjeuTLCKgQwP37FkgshyB4+0uol/HE+OtbRlbhN93D06gSMiQF+r7VMoZjHlJAwvHYuppOnUqU7nhAUWsfCud5C/hcUwJtzuktlvXJw+vSHcr54jC2oDUcFIpVUpeXYM1UGjYAG0RUWswhzE+yevjhp8SgedT0XxWIZuCsuqri9qI54T3LOi5Y4OUpKX+14if4YVClA1Bu7x04czmoPD1+ekSN/Aj3PZ6r4nHxXJ4 5rHzhuQA iVsl0+3EsNQHIDM9rrwgDnx1G/50/2SrapCH0smXTDjEy6Xqcf6m+5MUHEPlkabLq8pzFdVL+yU/qGvKSWRcL2peVLhPgnqTZrszDQtBLg/Vsb+3VHivfSTqrYVZo2PM+pshU6vVmmZH6f5C4JpzTWMr388zjy1nHexzjfTV3itcMF5GaAKaUoztoERdL2koE6qY1qy1sd5EwqOODKVCCQUVJGwmqrSN66F/EnIV8D7M1HhSpZ1vZ6/fO0coHQsY3fR2FvFOit8gMJwZSD8NTSyKFcGF8968cE2UbsI09kYJ23YC6eGZpN7W3iaFR6ESAqH2O6NEW1oz2DGPQCDLnNLpAplD++qda3hXAM2bdstklwmRIqjNbsSwYF6bvHfAdTo6hAmd2e1xOSTuOeMvnVUCyWotJWtPMl6emTQOKSy0qXXxjYooC8g23Df4m/SwBy6h5VsOOWR7/h//Ey5xKWnnEWgXLiPwic6LmDBZ6xGhslAsmGn0FYEwAWUgRYXOHYuqlX4aJalgG8cmu0GaPTQG7GW2gzJ1B/kkAwYMJF8FFgw3eoEtsCKm7ZxzdWkznhC5vUzFEFZRwNlqLkYAK5d8CoA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 12.06.25 01:08, Andrew Morton wrote: > On Wed, 11 Jun 2025 14:06:51 +0200 David Hildenbrand wrote: > >> While working on improving vm_normal_page() and friends, I stumbled >> over this issues: refcounted "normal" pages must not be marked >> using pmd_special() / pud_special(). > > Why is this? The two patches for that refer to the rules documented for vm_normal_page(), how it could mislead pmd_special()/pud_special() users, and how the harm so far is fortunately still limited. It's all about how we identify refcounted folios vs. pfn mappings / decide what's normal and what's special. > >> >> ... >> >> I spent too much time trying to get the ndctl tests mentioned by Dan >> running (.config tweaks, memmap= setup, ... ), without getting them to >> pass even without these patches. Some SKIP, some FAIL, some sometimes >> suddenly SKIP on first invocation, ... instructions unclear or the tests >> are shaky. This is how far I got: > > I won't include this in the [0/N] - it doesn't seem helpful for future > readers of the patchset. Yes, trim it down to "ran ndctl tests, tests are shaky and ahrd to run, but the results indicate that the relevant stuff seems to keep working". ... combined with the Tested-by by Dan. > > I'll give the patchset a run in mm-new, but it feels like some more > baking is needed? Fortunately Dan and Alistair managed to get the tests run properly. So I don't have to waste another valuable 4 hours of my life on testing some simple fixes that only stand in between me and doing the actual work in that area I want to get done. > > The [1/N] has cc:stable but there's nothing in there to explain this > decision. How does the issues affect userspace? My reasoning was: Getting cachemodes in page table entries wrong sounds ... bad? At least to me :) PAT code is confusing (when/how we could we actually mess up the cachemode?), so it's hard to decide when this actually hits, and what the exact results in which scenario would be. I tried to find out, but cannot spend another hour digging through that horrible code. So if someone has a problem with "stable" here, we can drop it. But the fix is simple. -- Cheers, David / dhildenb