From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3733CC5474A for ; Wed, 28 Aug 2024 06:34:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C2DE16B00B1; Wed, 28 Aug 2024 02:34:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BB6986B00B2; Wed, 28 Aug 2024 02:34:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AA4EB6B00B3; Wed, 28 Aug 2024 02:34:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 8642D6B00B1 for ; Wed, 28 Aug 2024 02:34:58 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 023A91A1D0C for ; Wed, 28 Aug 2024 06:34:57 +0000 (UTC) X-FDA: 82500691476.01.75EFF8F Received: from pegase2.c-s.fr (pegase2.c-s.fr [93.17.235.10]) by imf16.hostedemail.com (Postfix) with ESMTP id 47567180006 for ; Wed, 28 Aug 2024 06:34:54 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=none; spf=pass (imf16.hostedemail.com: domain of christophe.leroy@csgroup.eu designates 93.17.235.10 as permitted sender) smtp.mailfrom=christophe.leroy@csgroup.eu; dmarc=pass (policy=quarantine) header.from=csgroup.eu ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724826806; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OL6ocaP88ZibPSKFClSCWWAKIYu4SwcnRj2Y3FXVdBc=; b=gk4N1NEjYw364p0r5dWQV5f/M75PwoNzcbq8ucGoql67LFwPlv3SIbHOw2nzBQdkjTp9l1 sCV0miA9VLZQZPatj+9a1hX4eTgmrK7c46mrMTBGVg9RTDm2RqUNTnAgb21Kn/KupIvvZM XGnOTUomIOVS0o54EW0X2rIFpdjxb2Y= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724826806; a=rsa-sha256; cv=none; b=y5e0vZDVVAWRoNa+6tKq2iXr323Cs2m7VC9OQY8xnvkEjOxITFbFuyP9zWmhW/xXGPlDYg 9T6sz42lpCrDhgnWt6gdP9KOq9jA86qS+GgBgBivxuJsxcRcCTrth11Z488Fu6Ww24UjWU mZOw48bpM9iAFgJxlaoDaFp/9J5G3CM= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=none; spf=pass (imf16.hostedemail.com: domain of christophe.leroy@csgroup.eu designates 93.17.235.10 as permitted sender) smtp.mailfrom=christophe.leroy@csgroup.eu; dmarc=pass (policy=quarantine) header.from=csgroup.eu Received: from localhost (mailhub3.si.c-s.fr [172.26.127.67]) by localhost (Postfix) with ESMTP id 4Wtvlv5gSRz9sRs; Wed, 28 Aug 2024 08:34:51 +0200 (CEST) X-Virus-Scanned: amavisd-new at c-s.fr Received: from pegase2.c-s.fr ([172.26.127.65]) by localhost (pegase2.c-s.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6jPb3ZkzpTtP; Wed, 28 Aug 2024 08:34:51 +0200 (CEST) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase2.c-s.fr (Postfix) with ESMTP id 4Wtvlt44Xsz9sRy; Wed, 28 Aug 2024 08:34:50 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 72A688B77E; Wed, 28 Aug 2024 08:34:50 +0200 (CEST) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id vzIG7P3XR8ze; Wed, 28 Aug 2024 08:34:50 +0200 (CEST) Received: from [172.25.230.108] (unknown [172.25.230.108]) by messagerie.si.c-s.fr (Postfix) with ESMTP id C02CD8B764; Wed, 28 Aug 2024 08:34:49 +0200 (CEST) Message-ID: Date: Wed, 28 Aug 2024 08:34:49 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 07/16] powerpc: mm: Support MAP_BELOW_HINT To: Charlie Jenkins , Arnd Bergmann , Paul Walmsley , Palmer Dabbelt , Albert Ou , Catalin Marinas , Will Deacon , Michael Ellerman , Nicholas Piggin , Naveen N Rao , Muchun Song , Andrew Morton , "Liam R. Howlett" , Vlastimil Babka , Lorenzo Stoakes , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Huacai Chen , WANG Xuerui , Russell King , Thomas Bogendoerfer , "James E.J. Bottomley" , Helge Deller , Alexander Gordeev , Gerald Schaefer , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Sven Schnelle , Yoshinori Sato , Rich Felker , John Paul Adrian Glaubitz , "David S. Miller" , Andreas Larsson , Shuah Khan , Alexandre Ghiti Cc: linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, Palmer Dabbelt , linux-riscv@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-mm@kvack.org, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-kselftest@vger.kernel.org References: <20240827-patches-below_hint_mmap-v1-0-46ff2eb9022d@rivosinc.com> <20240827-patches-below_hint_mmap-v1-7-46ff2eb9022d@rivosinc.com> Content-Language: fr-FR From: Christophe Leroy In-Reply-To: <20240827-patches-below_hint_mmap-v1-7-46ff2eb9022d@rivosinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Stat-Signature: oesfgzys5f1jyk6es3o9detr68ahgfzr X-Rspamd-Queue-Id: 47567180006 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1724826894-577538 X-HE-Meta: U2FsdGVkX19+rwGgtQmjxLp20uIEmvzQJBBggIQYFQj3T/FTdCmwCGM8Qibuwb6I6EJKr6rxR6WBa3pkVdxbBERdzFL0Lh5aOqFIHlG7eBvQhu71C62NuKFjMtoU48gpfGWRTVKQFUSH1zKTDx7CQ4oizaQP100FhovOo+XgpDVz+a950se+jtcAVAqNLYDUX/n8EVVGErqjPXG+C9xZbE95dwBALfor/6SqFlmBr1HersP6EbLrjp3po8AVlIhP7V3UNMp5YLlI259CEgt6YmtKbgyoTKsbkIR44drUjnATYvjWBXmk6kHPo7HjlDKAr1Ta2Ky5QUOJzNAV8dB3udENzTdaLD5r8rQ7/Yx3GVOzY58cFbiaHhGvOtI0E8llCdLx6TfDNoQiNt8Co7lt60tS9Wos/to74e1XklPq7b+vg/Ts61SzmyEIydQRcWKAzIIapY+m+MixK8V0FNtpsKi3P7yS6DoSBYx2EVXwLFmoxmny5ip5zcmFUlGmBb7GvvDPtJJtaaLGTT0/0SdAszQg3Yc1PZbiSXo9KCnwwE6zUB2KGpOzkRPM1uhfd8bO3WY0WavmPA/dKiiM6UrwpFs6fPjn1AThaGcJclT1xxMFD64ZB+RecKzpi+LziuFaOiIdMuSeCScyYcDa9F5I85tc6gffro1YvS85bkm+cqX/D82qR+43dzKg0sJUZD6aNIMRYIZ4c5K2t6izvajL7sGDoJLhJiE/pzp2HpF+3BO2Iw+G8sNTAjjGXp5BBaNW511HQkCi3tyYMn0YH8SJVKYcKSGQA/0f2DlnoozhDMmpBn7uVSP7RLrXiZ2qhx6DIJHhIGs6QbBj8s+U+p+u863mckx3vO/CRxuUkWyxn+9Idyww7sMUdXlwvYeaeSAjw4RWJ+LeBxruIDHvf69IeoPG4u1KaO6gy0N6Mym0x3mgG4yhxDTeQmUFLtngVF6bOdqygf//fIzYkCq115j m0cy3qJd GJiku/DdbZeOhslZbupVbDFYbSdcwn8DTYtdUAwO7JdhFHwBc8LgzEg3FnzGegNJOu/Rih9vzdtK04sbqPN0cJ1HTudk68oZjpd+0TkA46eVCIKYpItZrdelpEB2eqH/FZAQ4ktXkVwORK9HOdt85tLpxGW0W9vW9nDUcdxhdpuoM3WvMVsssYfFHpyQSP6Wm4pot7RgdHMqcIqk98SJGwJ4axiQc9BLmftnvGM4HJrbhO7VEqJWzm24LXg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Charlie, Le 28/08/2024 à 07:49, Charlie Jenkins a écrit : > Add support for MAP_BELOW_HINT to arch_get_mmap_base() and > arch_get_mmap_end(). > > Signed-off-by: Charlie Jenkins > --- > arch/powerpc/include/asm/task_size_64.h | 36 +++++++++++++++++++++++++++------ > 1 file changed, 30 insertions(+), 6 deletions(-) > > diff --git a/arch/powerpc/include/asm/task_size_64.h b/arch/powerpc/include/asm/task_size_64.h > index 239b363841aa..a37a5a81365d 100644 > --- a/arch/powerpc/include/asm/task_size_64.h > +++ b/arch/powerpc/include/asm/task_size_64.h > @@ -72,12 +72,36 @@ > #define STACK_TOP_MAX TASK_SIZE_USER64 > #define STACK_TOP (is_32bit_task() ? STACK_TOP_USER32 : STACK_TOP_USER64) > > -#define arch_get_mmap_base(addr, len, base, flags) \ > - (((addr) > DEFAULT_MAP_WINDOW) ? (base) + TASK_SIZE - DEFAULT_MAP_WINDOW : (base)) > +#define arch_get_mmap_base(addr, len, base, flags) \ This macro looks quite big for a macro, can it be a static inline function instead ? Same for the other macro below. > +({ \ > + unsigned long mmap_base; \ > + typeof(flags) _flags = (flags); \ > + typeof(addr) _addr = (addr); \ > + typeof(base) _base = (base); \ > + typeof(len) _len = (len); \ > + unsigned long rnd_gap = DEFAULT_MAP_WINDOW - (_base); \ > + if (_flags & MAP_BELOW_HINT && _addr != 0 && ((_addr + _len) > BIT(VA_BITS - 1)))\ > + mmap_base = (_addr + _len) - rnd_gap; \ > + else \ > + mmap_end = ((_addr > DEFAULT_MAP_WINDOW) ? \ > + _base + TASK_SIZE - DEFAULT_MAP_WINDOW : \ > + _base); \ > + mmap_end; \ mmap_end doesn't exist, did you mean mmap_base ? > +}) > > -#define arch_get_mmap_end(addr, len, flags) \ > - (((addr) > DEFAULT_MAP_WINDOW) || \ > - (((flags) & MAP_FIXED) && ((addr) + (len) > DEFAULT_MAP_WINDOW)) ? TASK_SIZE : \ > - DEFAULT_MAP_WINDOW) > +#define arch_get_mmap_end(addr, len, flags) \ > +({ \ > + unsigned long mmap_end; \ > + typeof(flags) _flags = (flags); \ > + typeof(addr) _addr = (addr); \ > + typeof(len) _len = (len); \ > + if (_flags & MAP_BELOW_HINT && _addr != 0 && ((_addr + _len) > BIT(VA_BITS - 1))) \ > + mmap_end = (_addr + _len); \ > + else \ > + mmap_end = (((_addr) > DEFAULT_MAP_WINDOW) || \ > + (((_flags) & MAP_FIXED) && ((_addr) + (_len) > DEFAULT_MAP_WINDOW))\ > + ? TASK_SIZE : DEFAULT_MAP_WINDOW) \ > + mmap_end; \ > +}) > > #endif /* _ASM_POWERPC_TASK_SIZE_64_H */ >