From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EE3BC433F5 for ; Thu, 14 Apr 2022 21:49:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C87E96B0071; Thu, 14 Apr 2022 17:48:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C369E6B0073; Thu, 14 Apr 2022 17:48:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AD8456B0074; Thu, 14 Apr 2022 17:48:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.25]) by kanga.kvack.org (Postfix) with ESMTP id 9FB716B0071 for ; Thu, 14 Apr 2022 17:48:59 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id 7AC40837BA for ; Thu, 14 Apr 2022 21:48:59 +0000 (UTC) X-FDA: 79356825198.21.C6C2751 Received: from mail-io1-f51.google.com (mail-io1-f51.google.com [209.85.166.51]) by imf31.hostedemail.com (Postfix) with ESMTP id 27CFA20002 for ; Thu, 14 Apr 2022 21:48:59 +0000 (UTC) Received: by mail-io1-f51.google.com with SMTP id 125so6825838iov.10 for ; Thu, 14 Apr 2022 14:48:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=OmTrbVZbb3w4KmRSUrb4q7Rzh5oX9eyi3T1MDFP0KjU=; b=L0ITK16Dy0IulWrdQyDKQ385h5ypzAheqavuhQtIQ4WthfcqHAKDNmY714eWVBWVkd 0lH5+srAWBGwoZGuRFGvxgF5ndFpH5MI5HwM+B2POrV/utMgPDIQYEMYFpwBaugtYjn3 RKd+NKmkrd+Wq7xUVVUwT07zs/glJxUNPjTEU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=OmTrbVZbb3w4KmRSUrb4q7Rzh5oX9eyi3T1MDFP0KjU=; b=v1kY0q+c35pyD4TNZS0xKOLxHahIhM+/oSZpx3ovyCsJWQ0DSFdiVAogBN/D3C2gQc mR3L3cmr3b5cnL2IQ1OHxRX1qWSR/JFTFLv/Z4snInFc1nJGDYv4fty1VyUGt1fz9srp sHfQIrFVuUKSz8bU7OXPfcUQCNsU7Qs0i2CBB28/Pz6nH8ZZCg0TORnBxNQRXMLcxgmS fZm/ULzVGho2re6vqiUiqPnnymHJ8WFA8yRwtjkFtxulLZAM3LRnqb7iVM8LhYgYk3BL T9kwCvt4DgAWRiGHClHB+4lJ8oG97oY0W2dilEMFgaP6y4WULTHZgbSAVA/v5Ti7MxAP UEQg== X-Gm-Message-State: AOAM530QtrE2BTk8oMevtWSP8tCZCDQX3uMXyQACBR6s7eL7N8DVKXPC VFNvqlba0TDO93cjiWntqGueXw== X-Google-Smtp-Source: ABdhPJwFB9gnU6H5kQKv6sg6zZUUef1cdcX0RES3LTxpZRh8PGSuFNjTFiSA6oTKwMbW7jV7ifdjtA== X-Received: by 2002:a05:6638:2047:b0:323:7f2c:f5c4 with SMTP id t7-20020a056638204700b003237f2cf5c4mr2095401jaj.88.1649972938520; Thu, 14 Apr 2022 14:48:58 -0700 (PDT) Received: from [192.168.1.128] ([71.205.29.0]) by smtp.gmail.com with ESMTPSA id w3-20020a92d2c3000000b002cbca0cd15fsm1681010ilg.8.2022.04.14.14.48.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 14 Apr 2022 14:48:58 -0700 (PDT) Subject: Re: [PATCH 3/4] selftest/vm: support xfail in mremap_test To: Sidhartha Kumar , shuah@kernel.org, akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Shuah Khan References: <20220414171529.62058-1-sidhartha.kumar@oracle.com> <20220414171529.62058-4-sidhartha.kumar@oracle.com> From: Shuah Khan Message-ID: Date: Thu, 14 Apr 2022 15:48:57 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20220414171529.62058-4-sidhartha.kumar@oracle.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Stat-Signature: hgoprntiatzhiwpzhem4n8afwfxyyho7 X-Rspam-User: Authentication-Results: imf31.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=L0ITK16D; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf31.hostedemail.com: domain of skhan@linuxfoundation.org designates 209.85.166.51 as permitted sender) smtp.mailfrom=skhan@linuxfoundation.org X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 27CFA20002 X-HE-Tag: 1649972939-886453 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 4/14/22 11:15 AM, Sidhartha Kumar wrote: > Use ksft_test_result_xfail for the tests which > are expected to fail. > Same Nit about commit log lines. > Signed-off-by: Sidhartha Kumar > --- > tools/testing/selftests/vm/mremap_test.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/vm/mremap_test.c b/tools/testing/selftests/vm/mremap_test.c > index 98e9cff34aa7..ace9c3596ed7 100644 > --- a/tools/testing/selftests/vm/mremap_test.c > +++ b/tools/testing/selftests/vm/mremap_test.c > @@ -269,7 +269,7 @@ static void run_mremap_test_case(struct test test_case, int *failures, > > if (remap_time < 0) { > if (test_case.expect_failure) > - ksft_test_result_pass("%s\n\tExpected mremap failure\n", > + ksft_test_result_xfail("%s\n\tExpected mremap failure\n", > test_case.name); > else { > ksft_test_result_fail("%s\n", test_case.name); > Thank you. Looks good to me. Reviewed-by: Shuah Khan thanks, -- Shuah