From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F4073C02182 for ; Wed, 22 Jan 2025 16:10:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8D9066B0089; Wed, 22 Jan 2025 11:10:57 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 83B436B008A; Wed, 22 Jan 2025 11:10:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6DBB86B008C; Wed, 22 Jan 2025 11:10:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 4EFF16B0089 for ; Wed, 22 Jan 2025 11:10:57 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 46E8F140443 for ; Wed, 22 Jan 2025 16:10:50 +0000 (UTC) X-FDA: 83035576260.03.CBFAB5E Received: from gentwo.org (gentwo.org [62.72.0.81]) by imf29.hostedemail.com (Postfix) with ESMTP id 64A72120009 for ; Wed, 22 Jan 2025 16:10:48 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=gentwo.org header.s=default header.b=szdwTv1W; spf=pass (imf29.hostedemail.com: domain of cl@gentwo.org designates 62.72.0.81 as permitted sender) smtp.mailfrom=cl@gentwo.org; dmarc=pass (policy=reject) header.from=gentwo.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737562248; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SEsQ4OoslH9WStDSTKsMgND6WCTQGn3JeyP9TiaCzBk=; b=pkI6WXcwb/7KMYXnJ1uTnN21DkUt3LBBNcG+W1RTN+ezNl7KUpcDbG3tvrrEd64cp2zV0I KxZdxlm2cB4E846MBhhlQVjctDyvCb6bQuybq5HCJOrfhX3wVPrLcDUZMeDuub2esp2bmA wFrtOoelAvOHzADjx7zrcAc5jrCu4fI= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=gentwo.org header.s=default header.b=szdwTv1W; spf=pass (imf29.hostedemail.com: domain of cl@gentwo.org designates 62.72.0.81 as permitted sender) smtp.mailfrom=cl@gentwo.org; dmarc=pass (policy=reject) header.from=gentwo.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737562248; a=rsa-sha256; cv=none; b=8D9aX2XHpbGU1EQYsWIxkZyEyYScbxsiaJiAbkAzsqqr4ouYsywuyJJjvstHgoI+EQkb55 smEXWIcnViQE1yaQrkkNV+fOCuOdQazReSe1bj4QB1WxpEclRm9cLgLodLwVAlwUVsxieV LsLcDs6aKiyP4v2aXwv08Y1HsnvdH3k= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gentwo.org; s=default; t=1737561774; bh=Ic8MsEM2Z9i1aKlQU87fEU3YTUdutszRsehAgkOZ9kM=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=szdwTv1WCR2x1PRnjNvCvdSND2MCEsqxtCBZNhuaNX60ubKsKw+pWZuejtn6l/xNC zX7aejHqMDlATIrQxYeB3+l19h4XI9gVztirBFluoen5ZplSvUkooeBiV8IYTAH9kK aAUSeXSNjgl/A3xTnxXmUyoaHwVo7lCyWzxbq3+E= Received: by gentwo.org (Postfix, from userid 1003) id 22039401F1; Wed, 22 Jan 2025 08:02:54 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by gentwo.org (Postfix) with ESMTP id 1F8EC400CA; Wed, 22 Jan 2025 08:02:54 -0800 (PST) Date: Wed, 22 Jan 2025 08:02:54 -0800 (PST) From: "Christoph Lameter (Ampere)" To: GONG Ruiqi cc: Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Vlastimil Babka , Kees Cook , Tamas Koczka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Xiu Jianfeng , linux-mm@kvack.org, linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/slab: Achieve better kmalloc caches randomization in kvmalloc In-Reply-To: <20250122074817.991060-1-gongruiqi1@huawei.com> Message-ID: References: <20250122074817.991060-1-gongruiqi1@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 64A72120009 X-Stat-Signature: taffbzj49agrq1xy9fi4cs6to3j7jtp9 X-Rspam-User: X-HE-Tag: 1737562248-258757 X-HE-Meta: U2FsdGVkX19genH9nXwWEucD/MN0aF4OXLvKEpWBYNjVBb8TQlVIKvOnb1wbe9n7tp20BaOiR59DsD0l4VXlEWUHm439mCYaoJD/2MoAk1aaAqESj+lt5y8hHhB4c2WkSIIu7OE4qArrUG258p2ragshORp36X/uRkIruVqytP6TKMd+4fIjE4XEDrX8AJ/hEyY9jrw7bbpNERcdq0Wklyl7DCT+5Jgt9uwkH0IR4uKCJ7C1wx6EAPpMP6VGxvpMO0MoPrvYqFg3TBjOfgN52MI6y4CUvZ+QHAqiNgJYxCmcyyyz6X6rJ46In0chQD8ChEOjz741Q8WNlPvdIl7dM95wDcsu7vdpGyqArq4hNgXtxvRd2+P+k0lE7+Tg6ycQSe4Xc4GU4ABRSRir9WZY5bTOB1swfo0yF+3vquVPtBYMHfmJVhRBWaf0ddPqHazzAiWVqeYXD2tz33TzCbNh1zMny6nohnMaiTEJ1fPgX+Ll59Sz++8AFNp+p2UzYKhW5hpIIk07qd4Ec4oTW+ZhAUe1/vV8fiMzw5UVTRCu3Z6BHmJ7psgls5XwyPXwRKzlXd1v/07uP3cvxCBwoHCDclV4eSVTc1DxIpkmT/fKhKOQdLusVfU8Xz2hgcLeCYv9QuDuTDWyBdmC0NH1WrO7b/OTldyUITNRKPYfH0xEhMrAj/GYemDoOLpESZEAlsS3sqoBWKxrJLxpeWXBQKmT0kV/DcgkO2L6L1dKGr1JullviwKc3PYBDLTzFCOyjqjp8/k677vIyylmb+nkziHkQjk9VQnK0KVeH28cwFfGg/Fyt4TqDqG4RGrZgX7xzEGAFy855wpF8ojeKXD0nIIbkvY5SlFBptI5KFohLgTBub/f1nN/N8HzlfkFd/Z+Lt0tyPRLa6NldhtnanH0BE+yeAoLWtLJA2OIJPGsuWsPVQk88XBhrxuSeNKi0nG+69x1nPXIPIIA4kqFGRuX5j3 1ovS0o5A bvAN+N6DvlsSXaa2W9ulHJ/bR4XFBNsrxB940I5sRgIdv1oiGfrFgk/oN2uP48ulsjpUR/xDQXnveGoR4fQpgqWW+DH24FjGcMqVJx35ZdtMiq1bScyXhikYrfqoBumj9o2iCYQXTtu8ZSQZdo9uLZw812qjeQ+ysRchy4JZoQuu9lMGJ29ZeokcTd7SYQZkJQRtlbNyYzw5WkAK5ykOUUmLE0VnajJkSEQh8WQqtgYfkwXxqM74OUUR8SeNjPG51ELEXy8yf+TkUdwKSQ5wnZ3JnYvZzXQg2aCeHNxZd5ejCwho2qcN2+vcuvB7zTGJvjxAF X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 22 Jan 2025, GONG Ruiqi wrote: > > +void *__kmalloc_node_inline(size_t size, kmem_buckets *b, gfp_t flags, > + int node, unsigned long caller); > + Huh? Is this inline? Where is the body of the function? > diff --git a/mm/slub.c b/mm/slub.c > index c2151c9fee22..ec75070345c6 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -4319,6 +4319,13 @@ void *__kmalloc_node_track_caller_noprof(DECL_BUCKET_PARAMS(size, b), gfp_t flag > } > EXPORT_SYMBOL(__kmalloc_node_track_caller_noprof); > > +__always_inline void *__kmalloc_node_inline(size_t size, kmem_buckets *b, > + gfp_t flags, int node, > + unsigned long caller) > +{ > + return __do_kmalloc_node(size, b, flags, node, caller); > +} > + inline functions need to be defined in the header file AFAICT.