From: "Christoph Lameter (Ampere)" <cl@gentwo.org>
To: GONG Ruiqi <gongruiqi1@huawei.com>
Cc: Pekka Enberg <penberg@kernel.org>,
David Rientjes <rientjes@google.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Andrew Morton <akpm@linux-foundation.org>,
Vlastimil Babka <vbabka@suse.cz>, Kees Cook <kees@kernel.org>,
Tamas Koczka <poprdi@google.com>,
Roman Gushchin <roman.gushchin@linux.dev>,
Hyeonggon Yoo <42.hyeyoo@gmail.com>,
Xiu Jianfeng <xiujianfeng@huawei.com>,
linux-mm@kvack.org, linux-hardening@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/slab: Achieve better kmalloc caches randomization in kvmalloc
Date: Wed, 22 Jan 2025 08:02:54 -0800 (PST) [thread overview]
Message-ID: <a424b98e-87dc-4f1a-e18b-28ed28b555ef@gentwo.org> (raw)
In-Reply-To: <20250122074817.991060-1-gongruiqi1@huawei.com>
On Wed, 22 Jan 2025, GONG Ruiqi wrote:
>
> +void *__kmalloc_node_inline(size_t size, kmem_buckets *b, gfp_t flags,
> + int node, unsigned long caller);
> +
Huh? Is this inline? Where is the body of the function?
> diff --git a/mm/slub.c b/mm/slub.c
> index c2151c9fee22..ec75070345c6 100644
> --- a/mm/slub.c
> +++ b/mm/slub.c
> @@ -4319,6 +4319,13 @@ void *__kmalloc_node_track_caller_noprof(DECL_BUCKET_PARAMS(size, b), gfp_t flag
> }
> EXPORT_SYMBOL(__kmalloc_node_track_caller_noprof);
>
> +__always_inline void *__kmalloc_node_inline(size_t size, kmem_buckets *b,
> + gfp_t flags, int node,
> + unsigned long caller)
> +{
> + return __do_kmalloc_node(size, b, flags, node, caller);
> +}
> +
inline functions need to be defined in the header file AFAICT.
next prev parent reply other threads:[~2025-01-22 16:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-22 7:48 GONG Ruiqi
2025-01-22 16:02 ` Christoph Lameter (Ampere) [this message]
2025-01-24 15:19 ` Vlastimil Babka
2025-01-26 7:17 ` GONG Ruiqi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a424b98e-87dc-4f1a-e18b-28ed28b555ef@gentwo.org \
--to=cl@gentwo.org \
--cc=42.hyeyoo@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=gongruiqi1@huawei.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=kees@kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=poprdi@google.com \
--cc=rientjes@google.com \
--cc=roman.gushchin@linux.dev \
--cc=vbabka@suse.cz \
--cc=xiujianfeng@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox